Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 12 Dec 2023 10:03:43 +0100
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18240: Undefined behaviour in cash_mul_flt8() and friends
Message-ID: <ZXgh74Ykj3iWvXKr@paquier.xyz>
References: <18240-c5da758d7dc1ecf0@postgresql.org>
 <ZXbi3xo7QhQIe1YN@paquier.xyz>
 <2171714.1702307153@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="bsc2wVZHjdfGHuxq"
Content-Disposition: inline
In-Reply-To: <2171714.1702307153@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/ZXgh74Ykj3iWvXKr%40paquier.xyz>
Precedence: bulk


--bsc2wVZHjdfGHuxq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 11, 2023 at 10:05:53AM -0500, Tom Lane wrote:
> Yeah, approximately none of cash.c pays any attention to the risks
> of overflow/underflow.  Improving that situation would be a good
> finger exercise for some aspiring hacker, perhaps.  Although I bet
> somebody will ask again why it is that we continue to support the
> money type.

AFAIK, we discourage the use of money in the wiki for quite a few
years:
https://wiki.postgresql.org/wiki/Don%27t_Do_This#Don.27t_use_money

And numeric has much better code coverage and support.  I am wondering
whether we've reached the point where it would be better to remove it
entirely from the tree, and just tell people to use numeric.  This has
a cost for upgrades, where we should cross check for its use but there
is already check_for_data_type_usage() to do this job so the facility
is there.
--
Michael

--bsc2wVZHjdfGHuxq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmV4Ie8ACgkQnvQgOdby
QH2rdRAAmso4GlweWTBjBgLqi++y4+R23J3xjbYx7m5TFYDVY1UZ+raSRXfufzkw
TdV3j2MZkFomC/3WEYg+J09rDPPK2gn1WYm4o50F9YM9/BUeu1DBIvrbZLZ9aY1u
g/HxIHX8LUxyoRgT7SgvYteT4p0m5OA6jakYJdpe8TNhSAKQ7YjCpLiaaVOCqCI8
yETZ21C+KImIk6ZBUD4i53xl2oRUmWri293xSG/fyUf6IBmPFgNnFNPSQU5CO5nP
MJwMPtj8Ghy5t88hKdP5ARz+0mcFpKqvNFr8mr1idVatUXkEK7gVatzbTAO0m8ru
m6VmjA5MmeMbq2Fs8GLGPZrwxl4GfVcHe2HcGimFsACSqe9lGNgjnNu11PD74zE7
OErBy8kHULYgbPq3fzA+1oQ95mfPiigIaAKHKDmHHAgyco8sVQ6KHi4/p5EwbH8D
u7Xu1EL7UIxL3vFbc+P7ErBktDD/IbLlMJK2UZr6H0BGEkfno+t1c87R2oJZYxzd
HuVjCc1uCfLNKvGNIuT0E3PW9blLMsC7myJ1HRS64MCebyCYoWJpSzU8fF2G/j1g
n94LeUfu4yB1VhFAem+rE4YOw1NI9NHgrHVe4uv527eq5WDgywRFjjbRRRq+0I0C
QEoaMZITn9NF+r+Feg1rcpLT5wDOG0yAdFNF7pyrIbneu/fBJHE=
=krti
-----END PGP SIGNATURE-----

--bsc2wVZHjdfGHuxq--