Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rMscq-007NPj-Se for pgsql-bugs@arkaria.postgresql.org; Mon, 08 Jan 2024 16:37:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rMscp-006BTx-B1 for pgsql-bugs@arkaria.postgresql.org; Mon, 08 Jan 2024 16:37:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rMscp-006BTp-0c for pgsql-bugs@lists.postgresql.org; Mon, 08 Jan 2024 16:37:19 +0000 Received: from lana.depesz.com ([88.198.49.178] helo=depesz.com) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rMscm-000VGa-79; Mon, 08 Jan 2024 16:37:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=depesz.com; s=20170201; h=Content-Type:MIME-Version:Reply-To:Message-ID:Subject:Cc:To: Sender:From:Date:Content-Transfer-Encoding:Content-ID:Content-Description: In-Reply-To:References; bh=T61qg3RTfuoYBzFkBtn6DlPlMk4EdDOeHRr87YUstTc=; b=sJ PcrVG28yVpCmS1hG72nvPCavB9z6656rfLSY93ZLLjqXERiRy7piwmtvAg75q3EQAggESrpZcYBox 5GG94Yox0X+smr5lOjGzaUM5bWJxavFI8wma7+eVac71gIV9xG2DVZ/ovZWGJVTvoYiLVisx+ZMBK GNEFrQoV3JyP++s=; Received: from depesz by depesz.com with local (Exim 4.96) (envelope-from ) id 1rMsck-002hva-2V; Mon, 08 Jan 2024 17:37:14 +0100 Date: Mon, 8 Jan 2024 17:37:14 +0100 From: hubert depesz lubaczewski Sender: depesz@depesz.com To: PostgreSQL mailing lists Cc: Robert Haas Subject: Wrong datatype in docs for wal_summary_keep_time Message-ID: Reply-To: depesz@depesz.com MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, I was reviewing new changes, and found out that we now have "wal_summary_keep_time" setting, but the docs (https://www.postgresql.org/docs/devel/runtime-config-wal.html#RUNTIME-CONFIG-WAL-SUMMARIZATION) say that it's boolean, while it is integer. The fix is simple: #v+ --- config.sgml 2024-01-05 10:43:17.776276803 +0100 +++ config.sgml.fixed 2024-01-08 17:35:54.202968175 +0100 @@ -4179,7 +4179,7 @@ - wal_summary_keep_time (boolean) + wal_summary_keep_time (integer) wal_summary_keep_time configuration parameter #v- Best regards, depesz