Feedback-ID: i0fe9450f:Fastmail
Date: Sun, 14 Jan 2024 09:55:03 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Jonathan S. Katz" <jkatz@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, David Rowley <dgrowleyml@gmail.com>,
	exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18240: Undefined behaviour in cash_mul_flt8() and friends
Message-ID: <ZaMw56yDOtjxFfut@paquier.xyz>
References: <3453263.1702739958@sss.pgh.pa.us>
 <ecdf4a19-e97d-42c8-be45-fb5a46166160@postgresql.org>
 <1673413.1703442075@sss.pgh.pa.us>
 <ZYjSZZu1UGUlXWXa@paquier.xyz>
 <ZYlSJREbhM_qNZIT@paquier.xyz>
 <1851211.1703519939@sss.pgh.pa.us>
 <ZZ9AdxEEwHD8CWJ5@paquier.xyz>
 <9115f2e8-8dde-4545-868c-9becb2260aef@postgresql.org>
 <484395.1705077198@sss.pgh.pa.us>
 <e52ef545-5ec4-410f-83b8-8078e4fd4655@postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="aYVDmcKZ2ssthnbo"
Content-Disposition: inline
In-Reply-To: <e52ef545-5ec4-410f-83b8-8078e4fd4655@postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/ZaMw56yDOtjxFfut%40paquier.xyz>
Precedence: bulk


--aYVDmcKZ2ssthnbo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 12, 2024 at 10:50:25PM -0500, Jonathan S. Katz wrote:
> On 1/12/24 11:33 AM, Tom Lane wrote:
>> What'd have to happen is that people would have to upgrade to a
>> version of btree_gin/btree_gist that deletes its money support
>> before they could pg_upgrade into a core version that lacks money.
>> So we'd have to ship that version at least one major release before
>> nuking the core support.
>=20
> Hm -- what about people who skip versions (e.g. 16 =3D> 19)? Would they h=
ave
> to stop at 18 first to perform the upgrade? And does this only affect peo=
ple
> who use btree_gist/gin for moeny, or all btree_gist/gin users?

That's exactly why I am worried about a schedule being too aggressive
here.  Less runs of pg_upgrade means less headaches and less downtime.
I'd guess that we should have at least 3~4 years between a deprecation
in the docs and the actual removal.  It seems like this is what we
should do now on HEAD, aiming at a complete removal in 21~22 when 17
gets out of support (even if pg_upgrade support is down to 10 years).

>> v19: remove it from core
>>=20
>> Note that in v18, people could still use money even in
>> btree_gin/btree_gist, just by installing a non-default extension
>> version.  So their C code for money would have to stay.
>=20
> Yeah, but for what we support directly in PostgreSQL, we will have made b=
est
> effort. If someone _really_ wants to do something with "money" in the way
> you describe above, then they're committed to it.

By the way, let me know if you have any objections about the patch I
have posted upthread that reduces the dependency to money in the main
regression test suite, replacing things with varbit while keeping
coverage the same.  I have a few second thoughts about the change in
create_table, so I'm tempted to leave that part out for now, switching
the rest.
--
Michael

--aYVDmcKZ2ssthnbo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmWjMOcACgkQnvQgOdby
QH0VIQ/+P/sLIN5PqQBjtsNQ6QO529GaHfLMV29O3mZRpEQ4+dOdwGP9dObjvJz0
i3+Q3a6hHg0BdJNfYcLHvGkSvJbqGwPkNqRy9IF1uCioR62JcZrYKyeZsioK0m7X
cchuj4haBH0pF29OV/itNYEe6jDO4U4JjeH1kihMGj8Ag6jsmRE+rhrstREr7xg7
eCAKUZFQI+QVR0A4B2xRZUyDKmsEDOPsRu6Vt/KRF1F7BBipOL8pDQreAQRS+kbg
Bfferhht6CKpFMcO9ZHMB/UWF/OSRwUP8pxgX2Ccc8mt5AJUIJDH22DQcQKcv8/Q
mRdNh4Blx89+4Y5CiofPjxJgYXXTVh/nNZnQ0pHEzeRLlJTne4xU9vo+Fk+fUSiv
6t5WEThWHkDrkr3MGmqZFJ0vp/uIu4FnGB+ATdG6wZWpFcVXjnUQB3k3GF4YbD7R
Tw0VZgn6EjcnJTq5AGjLMLp03P4+cgBi5s8DReEDLC/w37bm6oXrX68ikuAZHcMO
f+p5q9+8dGpZHEzZbR1nctg7jZEMxUtcgkld4PbgGGzHjNMUhiITGhFiH11EOtyo
5oCF0ZaCHri1+9phc26GyWlp1om6oe8e2Zfir2TWzcVhRZbKDCI1erahQabAQoDm
ZdEI7FXIBepGJ9VespOGvjIplSaL1JXugRXX51CeVV9Dbg80NP4=
=sIwq
-----END PGP SIGNATURE-----

--aYVDmcKZ2ssthnbo--