Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rP9zn-009dPT-8H for pgsql-bugs@arkaria.postgresql.org; Sun, 14 Jan 2024 23:34:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rP9zl-00CrWB-Pj for pgsql-bugs@arkaria.postgresql.org; Sun, 14 Jan 2024 23:34:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rP9zl-00CrW3-HI for pgsql-bugs@lists.postgresql.org; Sun, 14 Jan 2024 23:34:25 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rP9zi-001nGE-6s for pgsql-bugs@lists.postgresql.org; Sun, 14 Jan 2024 23:34:24 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 5C3CF3200AD9; Sun, 14 Jan 2024 18:34:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 14 Jan 2024 18:34:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1705275258; x=1705361658; bh=g+iw7bpJJf zz6pPpr7v3pd1gJR90wYOZIMWUyy905Lc=; b=AJzD8XPjeApwOu2O/JtGxC154W f7DPbnGtyyY7+h5Lffe3/3G9TDD/T2PMThVTkWP+OCQBVsC5BXzBAGy8cBsp//CZ Z1QeH3uNoLnEAlV7ykWD/yRfu38Iy1KvTyGr4TkbMtN0HIy6aXGMwWSV0hvDj1Jz /zOZoR2JhBSa2d7rrokmTDDRQZzJ5P7UaOVcTwSnZVZFHVsLaLUnVdmhNLRn6dz4 bKf21/NgfMIAHOO8+AedU2HGhRJp4PGhgEB395zDtFLJpThbpnXUNuZ93RguTSPx 1nKHfkH92HsimrZVElMmjnun63DYdIUz6Xe0TsFPxWR71OSnqGOFoCqC1fRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1705275258; x=1705361658; bh=g+iw7bpJJfzz6pPpr7v3pd1gJR90 wYOZIMWUyy905Lc=; b=S6c+YtoEjNhDEyYHACpPuq2m8g0f1o/JuoC0iWNLWvIX Yqy/IrHt8vCX7AmNWnsTOF/goebYOorEVzyerNYxPdJPSPU5jZdWdr40DMe4hPU2 0c+u4+Ul3rbWv8ACfRx2vV53o0rLN1jDuUvghyyB5VDEAFCOhD9wQloUQg3fPwf3 rc0VXxoMkxJQq7UPZK3e5nDi+ISBQV6CftrxBtqdWO1fn9Ow6eBcxkc8KZy7c6ni /2KNOGjMdDqHjB8OJEnOf2EBIbaAhOHHoijLHgYEq1QceCc5m3mRe4VZ7vREGbfh FQaTa21kXeDRYcmIq/aUloxqfzBdKIXvPkSMZQLChg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdejtddguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepjeejtdelleeggeelffduhfej tdeuvdekkeethffhuedvvdeuudeugeefudevtdeinecuffhomhgrihhnpehgihhthhhusg drtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 14 Jan 2024 18:34:16 -0500 (EST) Date: Mon, 15 Jan 2024 08:34:05 +0900 From: Michael Paquier To: Dmitry Koval Cc: Tom Lane , pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18274: Error 'invalid XML content' Message-ID: References: <18274-98d16bc03520665f@postgresql.org> <1616257.1704651529@sss.pgh.pa.us> <5588db01-45be-48ff-b158-85f789bc502c@postgrespro.ru> <1314313.1705259848@sss.pgh.pa.us> <0eea123f-388a-41ea-9df3-d4606cf9ed8d@postgrespro.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iWtyTwUP7Uq7OQfw" Content-Disposition: inline In-Reply-To: <0eea123f-388a-41ea-9df3-d4606cf9ed8d@postgrespro.ru> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --iWtyTwUP7Uq7OQfw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 14, 2024 at 11:58:07PM +0300, Dmitry Koval wrote: >> Is there some downside to XML_PARSE_HUGE? >=20 > I didn't see any problems during simple testing of patch with the > XML_PARSE_HUGE. > Extended testing will be performed soon. > Then (I hope) we will send a trial version of PostgreSQL with a patch to > customers who use XML. If one looks at the libxml2 like this mirror at [1], it is possible to see that the flag is only used to lift internal hard limits, for stuff like XML_MAX_TEXT_LENGTH and XML_MAX_NAME_LENGTH for size control, or max node depths. Knowing that we have full control of the memory contexts for the XML nodes, just enforcing the huge flag does not seem like there's any downside for us. (Right?) [1]: https://github.com/GNOME/libxml2 -- Michael --iWtyTwUP7Uq7OQfw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmWkb20ACgkQnvQgOdby QH0dhxAAlRdXwPS5Lm7SqIkeFlkhSSoSQuoaCEi2JgIN8OXDLeJgi8TcsPtzsT1z XIPJ/AWxDvYTypxfO2LMqCFG8kEXHclsnzG3jlmhksHTTtV3AY4FgXgDMQQ0gAqU kqUk0Tb/cxFFy0axyGfOPpUbepiiXHEcMNxNtvEEethX30FS5jlF5+1Y+3BScnE1 pKe1EFvmn4ByWtX+MQ9mKC5O5As0xDib3WvTM1EAzEBbwczZhEGjUW45X5J4Wvaa 25w2ks5owyJsk2SDwgfEijcjk6Oh5zsowPbcurHxQRx4aVtT/HCJ8bnmdDizp6PG vVW3mIrQ10/OZbfmwUaAFv51E2gZ+zr2Vw+QdIViDwR79VnTi8SxLUgOYG7pkFJK /BCY7Yun7TgD2Xht3RZn0cRwmoUOwkdW5+8CY5Rpw1BVB3zBArvlTPAdUQSNO9bH V2I6sD/ZYCwW0CqjmLoU/WYW6Td6PVd4K6giBepuvpdnba9Ifh1Wv8TaZZ4L7bYH QU9tMTAf7xknQNp2FlBq7RlECgWm/GvdcDVkZhz4hxJkKgRL3x4iA6Vxmo/W2tTI 3+//kqJiIU5t9hwMayMl+Izjn/BeD4zqvW1b51s8YHFVmX3ZnUb3Tw1IWT4Ig4W9 uwisKqaHsi5qGMhEDyqDko590Rz2C6WhKad1NmbgjfmeWk9MGHo= =M11O -----END PGP SIGNATURE----- --iWtyTwUP7Uq7OQfw--