Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 24 Jan 2024 08:26:48 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: feichanghong <feichanghong@qq.com>,
	pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: MarkBufferDirty Assert held LW_EXCLUSIVE lock fail when
 ginFinishSplit
Message-ID: <ZbBLODpC44kSSv2I@paquier.xyz>
References: <tencent_A3CE810F59132D8E230475A5F0F7A08C8307@qq.com>
 <053bc845-3cb5-445e-8ea4-00f6c678ee25@iki.fi>
 <tencent_0F9D2F03B4F3E2C3DE4483E31B4147C9F605@qq.com>
 <d8f0b068-0e6e-4b2c-8932-62507eb7e1c6@iki.fi>
 <tencent_BEFB72867BA7CF879B492487284296D2F606@qq.com>
 <f8fa079c-c88c-4a4f-9c36-3854d12ddf70@iki.fi>
 <Za78YVcqNA8nAnn-@paquier.xyz>
 <f5eb802a-e98d-438e-9fa8-1694f767e5ea@iki.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Fsx4rdRNwuIzRc+M"
Content-Disposition: inline
In-Reply-To: <f5eb802a-e98d-438e-9fa8-1694f767e5ea@iki.fi>
Archived-At: 
 <https://www.postgresql.org/message-id/ZbBLODpC44kSSv2I%40paquier.xyz>
Precedence: bulk


--Fsx4rdRNwuIzRc+M
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jan 23, 2024 at 09:12:25AM +0200, Heikki Linnakangas wrote:
> I can see that being useful in general. It requires a bespoken callback
> function, though. One nice thing about this test was that I didn't need to
> write a new C module, only that snippet at the injection point and some SQL.
> In more complicated tests a new C module is warranted, but I think a lot of
> tests - like this gin test - can be written without it.

FWIW, I don't mind if src/test/modules/injection_points/ is used as a
single point across the tree as a library storing a large set of
callbacks.  All these don't have to be generic, and I think that we
should remain a maximum flexible for bug fixing and advanced testing.
I'm OK to leave the call up to the committer because it comes down to
invasiveness in src/backend/ vs invasiveness in the number of
callbacks or the logic inside the callbacks (sometimes it makes sense
to me to also complicate more the backend), and I'm OK with what you
are doing here for this thread.

> Perhaps if the argument was uint64 instead of a pointer, so that the
> 'injection_point' module could contain ready-made functions that do things
> with the argument.

I am not exactly sure to understand what you mean here.

> Overall I feel we should not bother with injection point arguments for now,
> though. Let's wait until we have a few more tests that would benefit from
> that, and then we'll have more information on what the ideal interface would
> look like.

Yeah, I am not sure if that's worth having for now, but that's always
good to keep in mind that the infra can be extended to handle such
cases even for stable branches.
--
Michael

--Fsx4rdRNwuIzRc+M
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmWwSzgACgkQnvQgOdby
QH2EsxAAiAS7Yqtay8+61lNmtkiuA+LFdP2ke9THS9zxcCmG2VKgapWMktR6k9Ke
uFzw1Ik6or1mmMpAB2N8kUeT62ztZYRgtM/UVXzXHz/pZByRos/OvYJq8OzDdz0m
bclTwkFyT6VpFd6f88Ns2jNE1OFzHwtSoys+HsH/lBScLYHi8KdmfAen+i5WpTaM
GW8p/blw8OlDmx7eYVks3qrF7okAMAYcU3ugPAetLZsps1SnibsWZ7oX+wDRtnMl
6R1tkdSGsBqhjAT4RFpjoPRJ5kRgmBjEwcyg7hfZbQUHd/pqwijgdQixFZsWDo1h
LkTU4Yt5hYuCyjUe/KtrXAMOMR2ofmN8qBlTWYtE+ss/s9M4U6d3sPsnjwyJm7Cb
d6DbK6w21DxhwmEl2DPqtAOpm3sHMzu7rkF3Ly/n59WgfX5sorqIWhr/btHb9lFI
vDVs96vGkCzKB6ngO+goZLbKmI5ILgF5gaEeqmgt3ivfza3P5DNwoENMKVPp7Zru
Psclr6FwmfZGzDPc8a1y8ZOYKgpRDUBfyLNnVQiIA+ByB8x6/KSGnqWf+t7K0rCr
HYeJdPlojjyfGCTuJFON84H6MosNFNm0ePGLe+GogE22P0kJVdRhJIyvE1cuBBMA
+tZVdn4qQp1YjoPNoh6NElH7hpcRLEK1EjCcyCO5zuG8tCAe7rE=
=ivhV
-----END PGP SIGNATURE-----

--Fsx4rdRNwuIzRc+M--