Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 24 Jan 2024 15:12:53 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Tender Wang <tndrwang@gmail.com>, Richard Guo <guofenglinux@gmail.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18297: Error when adding a column to a parent table with
 complex inheritance
Message-ID: <ZbCqZRvFu2iWHvo4@paquier.xyz>
References: <18297-b04cd83a55b51e35@postgresql.org>
 <CAHewXNkjMSzka_sGjtSysDRZpG93j5a=8ebq6f3Gcuo-xAGygw@mail.gmail.com>
 <CAMbWs48DPeuusHFaZ8xk=ag6TbhfqtF9KUEUMmb3nY7zPYCBdA@mail.gmail.com>
 <CAHewXNnhOgY4jTHKa2F1zJdtxUECmEMzV_VANnCNTuL3+_Bx6A@mail.gmail.com>
 <38de09cc-70f3-28ee-fe67-ae13cba23e61@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yX8KJ+p/kEJ4A6Yq"
Content-Disposition: inline
In-Reply-To: <38de09cc-70f3-28ee-fe67-ae13cba23e61@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZbCqZRvFu2iWHvo4%40paquier.xyz>
Precedence: bulk


--yX8KJ+p/kEJ4A6Yq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 18, 2024 at 12:00:01PM +0300, Alexander Lakhin wrote:
> Thank you for working on this!

Yep, this one is obviously wrong so I have applied and backpatched the
fix for tablecmds.c.  =20

> (Maybe it's possible to slightly modify an existing hierarchy with tables
> a, b, c in inherit.sql for the purpose of the check added.)

I was wondering about that, but decided to keep a separate test as
suggested as the other tests with inheritance are already tightly
linked to their own assumptions, mostly with renames and constraints.
--
Michael

--yX8KJ+p/kEJ4A6Yq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmWwqmUACgkQnvQgOdby
QH030Q//XoLDgCy0IS1QgyFSAqOPzghdCY0SFWChSmwRQh6ymFrAkvJjPRbJ4fxg
TV4fw13jkDdq4hdAhvxPYTogcdn2TWvykjUkUTxRtgZ5ryyZP4tX5hx5GZ31bC77
16zUljWzXGy7vg46c5SHguPsNo8rwMdcBT9OKubCmPyQ15vWGd624UF3dsg5j/7K
Ld7nbs+gvRNEjPoDN+VPgfDK6j8DwMj/VpgWsH5RZl2uy30b2EIgMj0Va1Pn9yBn
f7e3oo918LKXQ8FmhhZkbdL9RzufNpZbo/eIa2GL+lFs8e8KsSPJG+9IxCP+KGb1
4DEXDxGPf97xfLftX3agvaFJAP/QSKbZw0MmQJbc6Q65hDcrj1EIRNfuy75XjPhd
ku4B7opmEmd5jcgMTAqgiWsUjuod0SLAYdzcu4VL7AnaGbI1PcA7dt2L85LimYVk
XMVbJNdjiGRV4W7ggJFqezsWyeBopUOSlfQ7Eewo3EJdSIXyh4igLaf5BdHcoxbP
HG/gDyqiL4rPfxBOlJxOieW/zXzsQPUkz3vyKmMY12Gju2NtBtZioLttKKnzkBXA
AMac8WxwfSzmV9OcWehs1+Oo+Id3hDCUhZlbrWTlQkGtCQ0GwhqN/CmYU688F2mQ
us4cfX/Cg1zlJWisjaeh4NOrxGUXuQE2TXWVbYiugrgnoa9dLoc=
=5STM
-----END PGP SIGNATURE-----

--yX8KJ+p/kEJ4A6Yq--