Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 24 Jan 2024 15:20:42 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tender Wang <tndrwang@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>,
	Richard Guo <guofenglinux@gmail.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18297: Error when adding a column to a parent table with
 complex inheritance
Message-ID: <ZbCsOi3HBPAkwN83@paquier.xyz>
References: <18297-b04cd83a55b51e35@postgresql.org>
 <CAHewXNkjMSzka_sGjtSysDRZpG93j5a=8ebq6f3Gcuo-xAGygw@mail.gmail.com>
 <CAMbWs48DPeuusHFaZ8xk=ag6TbhfqtF9KUEUMmb3nY7zPYCBdA@mail.gmail.com>
 <CAHewXNnhOgY4jTHKa2F1zJdtxUECmEMzV_VANnCNTuL3+_Bx6A@mail.gmail.com>
 <38de09cc-70f3-28ee-fe67-ae13cba23e61@gmail.com>
 <CAHewXN=dPJDvaoME0G9vyemUmY-TpDuqQfcHJRWfUvSWX1p=rQ@mail.gmail.com>
 <9481c16e-8477-eb73-4e20-91bb1a13e2e0@gmail.com>
 <CAHewXNnx5t1ODMY1fw1ajCLHkfUd4o9sARX2c+rSGjUUbmo4uQ@mail.gmail.com>
 <2f37c3f3-4701-5efd-c007-2b1cc310a93a@gmail.com>
 <CAHewXNkf7Th5-5F_fgWcAb88jOJx=K03J=P17cLjfEMM2BQahA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="krhbU2kGLgDGG2cC"
Content-Disposition: inline
In-Reply-To: 
 <CAHewXNkf7Th5-5F_fgWcAb88jOJx=K03J=P17cLjfEMM2BQahA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZbCsOi3HBPAkwN83%40paquier.xyz>
Precedence: bulk


--krhbU2kGLgDGG2cC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 23, 2024 at 11:19:57AM +0800, Tender Wang wrote:
> Your reported two issues have different code path, and duplicates do not
> processed.
>=20
> I am considering whether there is a unified way of handling this, otherwi=
se
> each one will have to be dealt with separately.

Yes, I don't agree with what you have posted on [1], inventing a new
way to handle what is basically a way to remove duplicated
ObjectAddresses, and that's what we use in the DropRole() path.

The problem reported on this thread has now been fixed as of
bb812ab0917e, so why not moving the rest to a different thread with a
proper subject?  This will attract a better audience for the topic
dealt with.

[1]: https://www.postgresql.org/message-id/CAHewXN=3DdPJDvaoME0G9vyemUmY-Tp=
DuqQfcHJRWfUvSWX1p=3DrQ@mail.gmail.com
--
Michael

--krhbU2kGLgDGG2cC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmWwrDoACgkQnvQgOdby
QH3zjg//fN2bfDZk60TfXsQyLnwnbktkeQf50LhPRxBpWk8ZyG1QRV8Pj54s7ZQ3
jzHxhymP1OHvurSk+cUK8Z0yqPJ5On4LhD5xZOQR9pLKdRQTUKrIe+GQQTxtRJDu
OQfxiMJTlRXMTjHO4Qlhzt6auAPwtfgNcn8EEM+az1F+L6G0mTGHMGjrzxJdrGaV
Sl+Wo+nI3I/M9e45moEQY9Lv3uK31W+bRSu3CEuic9uLlowb1hw1cokRSywaBBrV
SFZHFXRhCoFXERZShn6mq6vAeihduyWutloI6MR+cyncQVncYAs6GCF3xz6tkg5U
/lRd7akQGuC+IRPespisQkCgBe66S3D3A1bpKMoMQpTuRTfd9lBqPIRvp5LUUkhK
ELwNKGhbhqN65bjSTCT4mHd6fl5bcepFGIWsilmQYJNLo4QyWZvPn6F/aR4Jl4Bs
vnTTBe83SwVDeWla74aUYWGLZJHfb5uk8dukzjln5G32OjX6Stt6IjXPdE0Ng+Pz
nuv7zc/ggRj9c3CzQPyQA8Rtk1B+QC3yJquf7XGcBNtUQx6zCfYLELrftD0IScyd
/eMrsYn3miAomxACtWgwDsQdy2QZtECOkKA1U3IrGQYkQB9OY+iCSO0k1ZK8my15
J5vwzgKvoiq8rtXo+tgt+wHmiJxVGjRBcH4Qurn4by1wCSoS3yw=
=e57A
-----END PGP SIGNATURE-----

--krhbU2kGLgDGG2cC--