Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 5 Mar 2024 09:56:12 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: Ronan Dunklau <ronan.dunklau@aiven.io>,
	pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: FSM Corruption (was: Could not read block at end of the relation)
Message-ID: <ZeZtrE9rwHDY4YLK@paquier.xyz>
References: 
 <VtPLBUerbMM8BSDLQwIMV9Co_38iHS1TXE4V09x2ZVFhPkZMNE8LwgPSIzB8PHkVFXykGx04QNAzZVjJFAnU1w==@protonmail.internalid>
 <3549385.iIbC2pHGDl@aivenlaptop>
 <20240304230503.a4.nmisch@google.com>
 <3470254.QJadu78ljV@aivenlaptop>
 <20240305001346.35.nmisch@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dQkawD2YJxuXA3T6"
Content-Disposition: inline
In-Reply-To: <20240305001346.35.nmisch@google.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZeZtrE9rwHDY4YLK%40paquier.xyz>
Precedence: bulk


--dQkawD2YJxuXA3T6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 04, 2024 at 04:13:46PM -0800, Noah Misch wrote:
> I agree each AM can use generic FPI code.  I'm looking at code like this =
as
> needing change under this candidate design:
>=20
> static void
> spgvacuumpage(spgBulkDeleteState *bds, BlockNumber blkno)
> {
> ...
> 		if (PageIsNew(page) || PageIsEmpty(page))
> 		{
> 			RecordFreeIndexPage(index, blkno);
>=20
> The change there would be fairly simple, but non-core access methods may
> require similar simple changes.  That's fine if this approach has other
> reasons to win, but it is a drawback.  A grep of pgxn code shows "rum" as=
 the
> only module containing a RecordFreeIndexPage() call.  No module contains a
> RecordPageWithFreeSpace() call.  So this drawback is all but negligible.

This design does not sound that bad to be, FWIW, if what you are
discussing impacts data inserts enough so be noticeable in the default
cases.  There are not that many out-of-core index AMs out there, and
"rum" is as far as I know not supported but any of the major cloud
vendors.  So contacting the authors of such AMs and raising awareness
would be enough.  So I would worry much more about performance.  My
2c.=20

(You should be able to implement a cheap test using two injection
points, from what I can read, if you need coordination between three
actions.)
--
Michael

--dQkawD2YJxuXA3T6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXmbawACgkQnvQgOdby
QH057RAAnWuts0OlP+eCACSrSdbCvaPJ50rIEw/XnU2CgQAy4kEIXI7Vm1JBjC6+
fNlmI5PWnkHRwO1QqwOeTwoayxbOljucM17I/uj4p97DipKu6MCKMCGiu/8O2t27
o2jiC/97+a0al46ScWt69wLQJ9J+5aTTQZmz4feyD0gaprhOynKkx7V4mb7lYlT8
/k/h9FPGSb6SIGif1nTJcfauIaO1n5H+kLuYV//0rorKUVgJlTKLh353QfMRjLkK
b2NQ0f/vmd1pbhwGQeIBT1BXUUa4aYSHx71p/ntze56d94fBSDAQQZKSVhYGpG4i
X7PPoQ/UdanElKHFxoo2pbaIm8KmqkUp9kTXAeYzouZHBkJy+q2bLYz3+OvrkfaL
GmprT1K6aACXui/EXkZVOWSqL7pcXEUgRuWz35C4nWDUteHXAeZqrz5mWSpwxO2o
IF2QaUfx6WgBpXqDnH5yz8GANYr81g3HUHySyk5ydkETQdivTvy5DWCg3vwV49tz
PO4GkOPa6sLjQ6o0WAs/mVSFVnPjPEQR2HR9IMk1sIF9titYyYf9IT2zoRUMwcdv
k9Gre4wH6a+MffO1hJW3JHvPBn6ucaih0pnJ2kiM2llT2jj2b4Is3uFBeJeof85j
rl2IBDIAzxRl5QAdUPfe1ssxPTqYoSXnb5W2ShcoWXxx1TreBug=
=voeW
-----END PGP SIGNATURE-----

--dQkawD2YJxuXA3T6--