Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ri0uB-00EcCc-7I for pgsql-bugs@arkaria.postgresql.org; Wed, 06 Mar 2024 23:42:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ri0u8-00FpmH-VD for pgsql-bugs@arkaria.postgresql.org; Wed, 06 Mar 2024 23:42:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ri0u7-00Fpm9-D1 for pgsql-bugs@lists.postgresql.org; Wed, 06 Mar 2024 23:42:33 +0000 Received: from fhigh3-smtp.messagingengine.com ([103.168.172.154]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ri0tz-003Dbo-2V for pgsql-bugs@lists.postgresql.org; Wed, 06 Mar 2024 23:42:30 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 2FC2011400CE; Wed, 6 Mar 2024 18:42:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 06 Mar 2024 18:42:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1709768543; x=1709854943; bh=S/Uitnp3rD lzSsuNT10Rd2VfGU0fStKPg+AzMCgiV34=; b=nFObY4a0fLf7IC+eLf+Qnw6Eed mUApAO1w6zMRewMEkGnaG3eQhL2eYqbbezh3w+RPnZAW91AdsGpPJGUuog5Ca9yT 9ddeuuNm8TWRQSB7N/Lay6soYbOsWSmOg15SvQPAC9ueVlLO/x+QPGaGuIVrOr3O rtb+GdguUdy+0ESTMY+JagtsMVbtib1+zpAyYfLmKa0SFjeqiwNtDreTuL/JF115 d5smNiWxmfCT/lx0BD3IedTU+GiqgMGFC8BDBCkruK2J+h+q68t3q40026p4rys1 pAOqimQa5fR/0LFOELWao3hPTumHIQuWq/JzcUSYi9LrODJO4okeRGyaUa+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1709768543; x=1709854943; bh=S/Uitnp3rDlzSsuNT10Rd2VfGU0f StKPg+AzMCgiV34=; b=SH4ThBok5f72G6GHgAk7TT+JmEB0woteLovFWD+0obsd 9Dx8+ZtQ+L3+LnBiZaSBCOIxcYjExcRXrh0hI4pmSQq4Kc+uvh+rM+IKcR7Wlrx9 pW3ekdWRlm9ADZxf/1fILzOlv9JZflpgRcpz/O2UHC3z/AM595YHctu9V/xw7hfo ZWu6dQzBQ17aZctDRS6mReIg9/JDK/8qfUggQInaZdPUh0FWNCtH6G2gXYZF98yH MnxL6n78DqmXxaX5jD0oZ2onGdxCdAvliesqWsa0wdQklftJYLopW1ViOCO8woCf m8j444+QvuGCIycx50mmIDN0IUOEjEjemQxEKAzwLA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledriedvgdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Mar 2024 18:42:20 -0500 (EST) Date: Thu, 7 Mar 2024 08:42:08 +0900 From: Michael Paquier To: Tom Lane Cc: Tender Wang , pgsql-bugs@lists.postgresql.org, Alexander Lakhin , jian he Subject: Re: BUG #18314: PARALLEL UNSAFE function does not prevent parallel index build Message-ID: References: <162802.1709746091@sss.pgh.pa.us> <387720.1709766110@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CMxUGo4IjKo8Y0er" Content-Disposition: inline In-Reply-To: <387720.1709766110@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --CMxUGo4IjKo8Y0er Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 06, 2024 at 06:01:50PM -0500, Tom Lane wrote: > Sure, but the current patch just trades one set of errors for others. > As I said, if we care about this problem then the right fix will > involve serializing/deserializing already-const-folded expression > trees instead of expecting that the workers can regenerate those. > I don't personally think it's worth the trouble, especially not if > we can get rid of the need for exception-using functions to be marked > parallel unsafe. I don't know if that's worth tackling either. It sounds like this is just something we should do only if someone comes up with a good use case for it, outside of the subtransaction handling in the workers. Anyway, I've just reverted the change for now. -- Michael --CMxUGo4IjKo8Y0er Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXo/1AACgkQnvQgOdby QH2yug//bMta2aMFqyPwDA0fA8vcdAasKpmY64rTwuDMwB31GGmhtZmRjFl9Qxrn jcRESfZ+WeaqDg3PSeKV9mNeBx+4V5qQ3rwkkg1i0Cd7mct8oVgyb0nP6yhdIfkt jhlr3cyUU76KM0NALjf+lulMqYjxi0hgRHYwxgy2FQKBfCDIQPIonHDSG0UIiops AKeFrhgsvm64zm4Mw0adED184N3aKQI7oh2/pF/RXSzmh1dmOQFoUBhsgSmZRr+7 ZI65l5iALgvvm5gyRZkDhbPigmWUWjmOv594B5zeXon/gW4q6u9HouBYDaPEHXSf Qi3hgHPQLonDSKmQnP7KVkR+6phEyfHPy26GvNxaHmlt5+rQ3TzsxDgSHNDCVmU6 Rkdxe943nHV7v+MkvSsrH26y7I4mv7YX0EafGiq43/q+zuuCGYpwfC1MFRXQx+tW f+6DpLQLqCBZiT8RP1r2TOSjgIyQIglz9AjuGduaPnA+aDrdhGmwVvd39UMe2qvY ceS5f6WlMmsqgNeYzFfSl6uH0/nMtA2KO+hZy5zDq22Jtqx8SCLkxt3UguKQCB/f qxS9ZZ/sj+MONfBM/pIqAeIIvnwBKpwGrlJD8E/dv0XqkBQTl/BPomCEYGm/lHzf IXF9EhJExQ2gH5DGAv3I9pOaKIqi/+wbqiowsAj8RxILlmkx91c= =N2v6 -----END PGP SIGNATURE----- --CMxUGo4IjKo8Y0er--