Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 18 Mar 2024 15:35:38 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, vignesh21@gmail.com,
	sawada.mshk@gmail.com, wangsh.fnst@fujitsu.com,
	osumi.takamichi@fujitsu.com, pgsql-bugs@lists.postgresql.org,
	Andres Freund <andres@anarazel.de>
Subject: Re: "unexpected duplicate for tablespace" problem in logical
 replication
Message-ID: <Zffgupps4Gv9BVXL@paquier.xyz>
References: 
 <CALDaNm1NjZDJGEoYaRPMGsXrOMQwJ2bK4EXC-wvoSSM77XX95A@mail.gmail.com>
 <20240112.173746.1710988914918513917.horikyota.ntt@gmail.com>
 <CA+TgmoYuONjrkcSDJC60RoaVQ_q3JP5H4b-5uiK+tanONYJYbA@mail.gmail.com>
 <20240116.105804.1924548897701268962.horikyota.ntt@gmail.com>
 <CA+TgmoYADF0ddp4JO_a8AiUDKCLFGTAw7ii8OniLBzmwVG8njg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="JbaENzg8i3A8wrxo"
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoYADF0ddp4JO_a8AiUDKCLFGTAw7ii8OniLBzmwVG8njg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Zffgupps4Gv9BVXL%40paquier.xyz>
Precedence: bulk


--JbaENzg8i3A8wrxo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Feb 02, 2024 at 10:49:17AM -0500, Robert Haas wrote:
> Andres, what do you think about this idea? I wonder if you just
> momentarily forgot about temporary relations when coding
> RelidByRelfilenumber -- because for that function to give well-defined
> answers with temporary relations included, it would need the backend
> ID as an additional argument.

No idea what Andres thinks, but seeing that pg_filenode_relation()
uses in input a tablespace OID and a filenode OID while ignoring the
prefix that would be used for a temp relation path (with a 't' and the
backend number), it is clear that the current function is not suited
to make the difference between temporary and persistent relations as
we'd need to have a priority order to choose one over the other.  And
that may not lead to the correct choice.

Ignoring temporary relations entirely makes sense: one cannot get a
regclass from only a tablespace and a relfilenode, the persistence, as
well as a backend ID would also be required.  I've not checked the
patch in details, but it's to say that the idea to cut temporary
relations sounds rather right here.
--
Michael

--JbaENzg8i3A8wrxo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmX34LoACgkQnvQgOdby
QH3rIA//XnDkD2a3EhIpWV5fsDxQEjkYlJ2t+w4t3jE5g8FuDQVQNUMbs8SlwIRB
5CvSmA/mmy97JzHot34aPzXNBKZNWUMIfE6f2WwXK6t8Gax6tUu71oX+0t9bJcKE
stfB9HlAOKaSVfg22hDEzgCGLg3DKL3O+POlL2BQaHQU9qnNMET3UO24UpO2Obqb
Oxu5vBflCVEBVCFFEplVVNgXlW18M60jAE/Ks7WQ3GkpwnB3cScTqzPDuix3B11F
i7cNWpBokURNM4eOWBy964jJ55/C3pNy9SeqJOOBUs0/MaIzXrHl5iPWnlnoFkW7
TJ6UpZGIYoQGIa0x1DNFPd1CKSLtfFK3ZhUfNwhxrBp54yVGeK+rJ7y+uNjhxzyz
h9fJnGp3gF2ENliDZh0R653GSg4Mdrx+/z/0rAJg5rPjIkGNpo7xiAUHeASDZ9qN
jRIUsT7IQwVO7iNf1MqIyXg5w11Yxga2j0gO1tbtJt/oSNGA2vwlrSx5R5KzuR+7
pREDy5XCy/MedC9Czf5LF5D50AgpP24I0S1x4OL9MQ9fO356vZUIRcm/IheX/7Xn
f4YhCDfQvdqOxKYAHnBkAbk7kqtI4tZ5Z6TukEVI3bx1cgm1Yn1E3j8Tvklv2/Rf
orxvTuBtKl1OVUpD8IanIltaP51WFoKRvujmGDTUhe9m5ebSGrU=
=yWO0
-----END PGP SIGNATURE-----

--JbaENzg8i3A8wrxo--