Date: Tue, 19 Mar 2024 19:54:49 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Christophe Pettus <xof@thebuild.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	Wolfgang Walther <walther@technowledgy.de>,
	PostgreSQL Bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be
 loaded
Message-ID: <ZfolyUQw9z1zxX58@momjian.us>
References: <855a1b16-0dc0-42b2-8f90-79eb49cf2893@technowledgy.de>
 <F5A214FF-1BED-4935-B4FF-4679CCF463D6@thebuild.com>
 <CAD5tBcLWM+QT0+VKWUHiBX2Ey5eCc8jVL5APb1U5iaePV_eAvg@mail.gmail.com>
 <A9F65857-A286-4EB8-96CE-EA5C1636A05C@thebuild.com>
 <CA+hUKG+H80zJTmNnRbAQb+py2xpzNUtmoacbfnyAi2c5d1imGg@mail.gmail.com>
 <E5D4E3AE-C926-48C5-84DC-57E3E9357675@thebuild.com>
 <CA+hUKGJW_ht0VYsr7bzF8-FLZW_o3Ys6Xm5w10GU5WBHtfv+zg@mail.gmail.com>
 <3561573.1710771812@sss.pgh.pa.us>
 <CA+hUKG+Tq3GK7bPd03N0Eox3YY4-Hjd7qQjo_QZFjdbhTqQGQA@mail.gmail.com>
 <CA+hUKGK9LUq=uygBRFt3vFO1RL+_scsT4+hMkvea_zTttHZ59Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+hUKGK9LUq=uygBRFt3vFO1RL+_scsT4+hMkvea_zTttHZ59Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZfolyUQw9z1zxX58%40momjian.us>
Precedence: bulk

On Tue, Mar 19, 2024 at 11:48:50AM +1300, Thomas Munro wrote:
> On Tue, Mar 19, 2024 at 10:17 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> > ... (though my patch could be a little sneakier and steal
> > all the bytes right up to the = sign to get more space for our
> > message!).
> 
> Here's one like that.  No musl here -- does this work Wolfgang?  Do we
> think it's generous enough with space in practice that we could just
> always do this for __linux__ systems without anyone noticing (ie
> including glibc users)?  Should we be more specific about which LD_*
> variables?  Do people not doing hacking/testing ever really set those,
> eg on production servers?  This code path was once used by up to a
> dozen or so OSes but they're all dead, only Linux, Solaris and macOS
> left, and I don't have any reason to think they suffer from this
> problem and Macs don't even follow the SysV LD_ naming convention,
> hence gating on Linux.

So this would truncate the process title on all Linux that have an LD_
environment entry, even those without musl?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.