Date: Mon, 25 Mar 2024 18:35:06 -0400
From: Bruce Momjian <bruce@momjian.us>
To: walther@technowledgy.de
Cc: Thomas Munro <thomas.munro@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
	Christophe Pettus <xof@thebuild.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	PostgreSQL Bugs <pgsql-bugs@lists.postgresql.org>,
	Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be
 loaded
Message-ID: <ZgH8GiD0CqYrTPQq@momjian.us>
References: <ZfrmN4WHuJgD95fw@momjian.us>
 <CA+hUKGJzC4rr2Yr=QZyx9W83Wv=TVJHndKF1anjNLNXVUM7TqQ@mail.gmail.com>
 <f98cd8de-1c66-491a-8409-e62c09932080@technowledgy.de>
 <36690fcf-f0c8-4d60-af49-6a7efa0e2b14@technowledgy.de>
 <CA+hUKGJAkTZUa9JGr-zsadaqsN=K0P71t-1L2t2=MQFDMc4GuQ@mail.gmail.com>
 <ZfzLsiXbguTDatiZ@momjian.us>
 <a2463df1-be45-4a76-b90f-7676d778e7b1@technowledgy.de>
 <Zf2JU0_GDdbeBm5j@momjian.us>
 <Zf3fnKpHIGpe5mOi@momjian.us>
 <2293691d-2adb-4502-b956-73e79dc43c55@technowledgy.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2293691d-2adb-4502-b956-73e79dc43c55@technowledgy.de>
Archived-At: 
 <https://www.postgresql.org/message-id/ZgH8GiD0CqYrTPQq%40momjian.us>
Precedence: bulk

On Mon, Mar 25, 2024 at 10:58:30PM +0100, walther@technowledgy.de wrote:
> Bruce Momjian:
> > With no one "hoping this patch dies in a fire"*, I have updated it with
> > more details, which I now think is committable to master.  Is this
> > something to backpatch?  Seems too rare a bug to me.
> 
> I would like to see this backpatched to be able to run the regression tests
> easily on all stable branches.

You want to risk destabilizing Postgres by backpatching something this
complex so the regression tests can be run on all stable branches?  I
think you are overestimating our desire to take on risk.

Also, in my patch, the parentheses here:

	#if defined(__linux__) && (! defined(__GLIBC__) && ! defined(__UCLIBC__))

are unnecessary so they should be removed:

	#if defined(__linux__) && ! defined(__GLIBC__) && ! defined(__UCLIBC__)

I am only willing to apply my patch, and only to master.  Other
committers might be more willing.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.