Date: Mon, 25 Mar 2024 18:51:09 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: walther@technowledgy.de, Thomas Munro <thomas.munro@gmail.com>,
	Christophe Pettus <xof@thebuild.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	PostgreSQL Bugs <pgsql-bugs@lists.postgresql.org>,
	Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be
 loaded
Message-ID: <ZgH_3QXEWI5jFBUC@momjian.us>
References: <ZfrmN4WHuJgD95fw@momjian.us>
 <CA+hUKGJzC4rr2Yr=QZyx9W83Wv=TVJHndKF1anjNLNXVUM7TqQ@mail.gmail.com>
 <f98cd8de-1c66-491a-8409-e62c09932080@technowledgy.de>
 <36690fcf-f0c8-4d60-af49-6a7efa0e2b14@technowledgy.de>
 <CA+hUKGJAkTZUa9JGr-zsadaqsN=K0P71t-1L2t2=MQFDMc4GuQ@mail.gmail.com>
 <ZfzLsiXbguTDatiZ@momjian.us>
 <a2463df1-be45-4a76-b90f-7676d778e7b1@technowledgy.de>
 <Zf2JU0_GDdbeBm5j@momjian.us>
 <Zf3fnKpHIGpe5mOi@momjian.us>
 <443430b4-0c10-49f3-8c8a-e5e76602f309@eisentraut.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <443430b4-0c10-49f3-8c8a-e5e76602f309@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/ZgH_3QXEWI5jFBUC%40momjian.us>
Precedence: bulk

On Mon, Mar 25, 2024 at 11:46:09PM +0100, Peter Eisentraut wrote:
> On 22.03.24 20:44, Bruce Momjian wrote:
> > +				 * linking (dlopen) might fail.  Here, we truncate the update
> > +				 * of the process title when either of two important dynamic
> > +				 * linking environment variables are set.  Musl does not
> > +				 * define any compiler symbols, so we have to do this for
> > +				 * any Linux libc we don't know is safe.
> > +				 */
> > +				if (strstr(environ[i], "LD_LIBRARY_PATH=") == environ[i] ||
> > +					strstr(environ[i], "LD_PRELOAD=") == environ[i])
> 
> What determines which variables require this treatment?

Thomas Munro came up with that part of the patch.  I just combined his
patch with the macro test.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.