Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 23 Apr 2024 14:37:56 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	keith.fiske@crunchydata.com, ejberdecia@yahoo.com,
	david.rowley@2ndquadrant.com, amitlangote09@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15954: Unable to alter partitioned table to set logged
Message-ID: <ZidJNJzvnDVLsgtB@paquier.xyz>
References: <1703025078.5205270.1565786782053@mail.yahoo.com>
 <CAODZiv58QvbbHCfh9MbbM6Bfuj7uSNjdCpt8r_H4VpmAOZ_9Qw@mail.gmail.com>
 <20190821134434.GA9383@paquier.xyz>
 <20190822.171439.14634665.horikyota.ntt@gmail.com>
 <CAKFQuwZHFOQDcx1tnyjV=kT9ss5dPDk8AKbCPv3ughhUJh5yHg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="UYqjHh8GW8ejX2YV"
Content-Disposition: inline
In-Reply-To: 
 <CAKFQuwZHFOQDcx1tnyjV=kT9ss5dPDk8AKbCPv3ughhUJh5yHg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZidJNJzvnDVLsgtB%40paquier.xyz>
Precedence: bulk


--UYqjHh8GW8ejX2YV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 22, 2024 at 12:36:20PM -0700, David G. Johnston wrote:
> There is little upside to preventing the existence of an unlogged
> partitioned table at this point.  I have just submitted a doc patch to deal
> with that side of the equation.

I would not object to that.  However, now that we're five years into
this problem, I'd rather treat that as a new entire feature than
change the existing behavior in the back branches.

Not changing unlogged property of a partitioned table on ALTER TABLE
is of course no good.  However, we also ignore the fact that a
partitioned table is unlogged when we create its partitions, and there
is a point in making partitions inherit this property from the parent.
So, my take would be:
- To switch the relpersistence of a partitioned table on ALTER TABLE,
without touching any of its partitions.
- New partitions should inherit the unlogged property of the parent.
- pg_dump should not need tweaks to be able to cope with that, as
loggedness is part of the CREATE queries.

Compared to the recent experiences around tablespaces and table AMs,
this should be less complicated with code paths for relations without
storage in tablecmds.c.
--
Michael

--UYqjHh8GW8ejX2YV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmYnSTQACgkQnvQgOdby
QH0TZxAAlVbCxudVLyk0qQCspvE7xVnPj/wZGKOXpuDoAcDkVwHzQewiUTD24ag8
aaq2aovRCp6zRTnmCtNeRX7xi7N2Xie4u6JFx3tsHChdLAcK+B4/QPx7fgP9/sUk
Y4MWUBt7PVacqxgEw5BwqviiyNqg81NZUPF7Juvu3Ce+jGrsjlJQIUudsUbSFoeN
rYvyZFD2iU1tMjGnRcq46utmhJDwWF5zz6Pkgu6dr4nz7EsFqdpPaya08qBXj2Kx
grp6Pjh6zTP3K6DP/RUweYe+R3vtOpom5RtNhBy1Z51mOWtCC8KOSgeYGSOKdZUK
dT0jd9qQNDzVEduqFpvpOKRpqLdmLGdd3J6uoM2i3Y27tcU1hhe8NVO2ocpr8BsA
6m96Q+tmjnDrQDr3dnLBo45X6ANZ3nxsZaecSPNhTfVZVwgNUHiNfqVv4CZnIYu7
u+ii7s2NK3hdgkvXl7YyepuK4vdNMn0Gdv1fRAu7M1Ebkpc/mwdOedGkbjXxdmUt
AxT/ZsfAYG15g5gYfnmH00nlyomtOjf3SC9fT8LVx6mE3Oq4gbAP8ESEKux0M3R/
Hgxu4DfoofQej99g+kRtU/yIj/d3xG9ddjk4Ym1YFNxVAL2KVcX656w0DbDXF3bA
CJCQVCb4uqAKKG1/r/9Gv/1VTdAQGy37Rds1LGiMV9c6IV5dz10=
=nTRz
-----END PGP SIGNATURE-----

--UYqjHh8GW8ejX2YV--