Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 24 Apr 2024 16:24:19 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	"keith.fiske@crunchydata.com" <keith.fiske@crunchydata.com>,
	"ejberdecia@yahoo.com" <ejberdecia@yahoo.com>,
	"david.rowley@2ndquadrant.com" <david.rowley@2ndquadrant.com>,
	"amitlangote09@gmail.com" <amitlangote09@gmail.com>,
	"pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15954: Unable to alter partitioned table to set logged
Message-ID: <Ziizo3ML2KwsuE9U@paquier.xyz>
References: <1703025078.5205270.1565786782053@mail.yahoo.com>
 <CAODZiv58QvbbHCfh9MbbM6Bfuj7uSNjdCpt8r_H4VpmAOZ_9Qw@mail.gmail.com>
 <20190821134434.GA9383@paquier.xyz>
 <20190822.171439.14634665.horikyota.ntt@gmail.com>
 <CAKFQuwZHFOQDcx1tnyjV=kT9ss5dPDk8AKbCPv3ughhUJh5yHg@mail.gmail.com>
 <ZidJNJzvnDVLsgtB@paquier.xyz>
 <CAKFQuwaEdwXv3=UsFUuNBvVg9r3MJzW-U-04E76ovi8LQFqvVQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kQgLqiBqGZ4VbBkb"
Content-Disposition: inline
In-Reply-To: 
 <CAKFQuwaEdwXv3=UsFUuNBvVg9r3MJzW-U-04E76ovi8LQFqvVQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Ziizo3ML2KwsuE9U%40paquier.xyz>
Precedence: bulk


--kQgLqiBqGZ4VbBkb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Apr 23, 2024 at 05:33:00AM -0700, David G. Johnston wrote:
> Correct, it is an outright bug that I see no reason not to just fix and
> back-patch.  The new feature needs its own thread so as not to have this
> one see the same fate it had 5 years ago.

The semantics have become much more complicated than 5 years ago
because partitioned tables have gained support for more things, one
being the recent addition of identity columns.  While I've analyzed
the whole, I have asked myself a couple of questions about what the
best user-friendly behavior would be, implemented one and mentioned
the rest.  Anyway, a new thread has been created about this topic, so
feel free to reply there:
https://www.postgresql.org/message-id/ZiiyGFTBNkqcMQi_%40paquier.xyz
--
Michael

--kQgLqiBqGZ4VbBkb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmYos6MACgkQnvQgOdby
QH2/wRAAitz8mia7ZdiBV/SoUIkgEi9uIpuKDEVF30y7BRcOLF1vKV8CDihY08Sn
MSYXmFJA+6xvRkDUK4/vTsllmEFbHlMSkHsHzRqltlHuXWrdblOYH3j+y5c/3xLU
zYy5QtykcC2cTjrcaxhzKMAuo/lY7Z8wp6zwFnJcUEv2yhp6jDN4podDa4kQWmUy
2QjAXUFUI8kIfr/ZycFdUp696tWQ22SjZgUzhXzwjba02SIJYXDiyvu2qDmzICpR
6CrGfIja7/9bBm6xdxVHcEbOQUdxD3m9iu0+xeyTOUxVPOvmO42pDy2AqDBi1fGw
8zz0PtrKTRPS+bFLezhj2hjpablsDUzKG3HwUSA2xxjJFNbs6k19f/Z1LTOvsm6G
rOMH8DaE3xxXHd/OtIvgosLZg8RtxjBV/35BVnCUAx/3VjqKvizIMI+FG0+0uUYx
KIDh757l4ILaf4Q561I7iBTKp5Bj81Q20qiaho6Sdn+J+uhwC/RT2gn+qngjZ3qs
+zNJBUAapIqt+ulQsighg3d0Rge+KgMe1TRPwSQmFcp6IbSueHwMbY6xXyjWviG8
CGjOtZ9BA+Zgxpgl4VNzEEQq+u0x5hDQANbOPgSXo7X9z9GgHljy9KPQN4hSWV81
Jfv9yxkTgECZ9IDjpQiSPcH/6rrB+MvDoR1WcopdjL82vW66aKk=
=uJpY
-----END PGP SIGNATURE-----

--kQgLqiBqGZ4VbBkb--