Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 4 Jun 2024 13:53:04 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Chris Travers <chris.travers@stormatics.tech>
Cc: Farooq Rashed <farooq.rashed@desc.gov.ae>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: pg_rewind fails on Windows where tablespaces are used
Message-ID: <Zl6dsK5IcNGTL0qD@paquier.xyz>
References: 
 <CA+pA0kLc5VxOaO4WfLjmh7W0V+quVvVtT5CaRVRAZMuh0zft4Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ZOV3GiYUm21DClSB"
Content-Disposition: inline
In-Reply-To: 
 <CA+pA0kLc5VxOaO4WfLjmh7W0V+quVvVtT5CaRVRAZMuh0zft4Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Zl6dsK5IcNGTL0qD%40paquier.xyz>
Precedence: bulk


--ZOV3GiYUm21DClSB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 08, 2024 at 03:02:21PM +0700, Chris Travers wrote:
> Setup is PostgreSQL on Windows with a tablespace on a separate drive.  Wh=
en
> I go to run pg_rewind it consistently fails with the following error:

(Chris has poked me regarding this issue last week in Vancouver.)

> pg_rewind: servers diverged at WAL location 39B/7EC6F60 on timeline 2
> pg_rewind: rewinding from last common checkpoint at 39B/7E8E3F8 on timeli=
ne
> 2
> pg_rewind: error: file "pg_tblspc/34244696" is of different type in source
> and target
>=20
> The file is confirmed to be a JUNCTION to the correct location on both the
> source and target.  So the error looks like a problem interacting with
> Windows and detecting JUNCTION types in this case.

I am not completely sure to follow here.  Aren't you making use of an
in-place tablespace here?  Could you provide more details about the
structure of the data folders, because these are on separate hosts,
right?  When rewinding from a live server, readlink() returns an
absolute path for a junction point, meaning that the result would not
be influenced by bf227926d22b as we would always handle such an entry
with FILE_TYPE_SYMLINK.  On Windows, the link creation would be
covered by pgsymlink(), which would create the link as a junction
point.

Note that I do not object to a backpatch of bf227926d22b, as I did not
do it for the sake of caution as in-place tablespaces are a developer
feature.  If you use it for tests of your own on stable branches,
well, why not.

> I came across the following which looks like it would fix this problem but
> don't have a proper build environment.  Please consider backporting the f=
ix
> at least as far as Postgres 15 as this bug fix does apply to non-in-place
> tablespaces on Windows.  The thread is
> https://postgrespro.com/list/thread-id/2657122

I'd suggest to use the postgresql.org reference.  This refers to
commit bf227926d22b, for the following thread:
https://www.postgresql.org/message-id/2b79d2a8-b2d5-4bd7-a15b-31e485100980.=
xiyuan.zr@alibaba-inc.com

Thanks,
--
Michael

--ZOV3GiYUm21DClSB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZenbAACgkQnvQgOdby
QH0v5xAAo3IIOZE0WWWTfWOyQT7Z54R3mcp0tx3yNPMlKJFLHNpwNvxmE8TtaHVq
mEg+GnD1Jvr7KelNYNjO32hH2p4Cd67EZ2KHOd3SsgR93cZJdntISOK0/si3D2i/
En3fRh1xOwbPkLPIG+6WsokZuUPnUNIrxxEp04eBHuXuM7nRvp6ma9BDseqpoFJT
2IFJkZCBbbCrCS6f0WBeQ9iwLO5SQs3ch99NjZ+g4VrVyXOfSLg2/lJ5DwWkO08r
V/A2lZBUp+JoJWRqcA3l10MazMZCGPWTmxpQDilIPNDn+55tPTwPIhoBRttURILd
SdvJOgjD+jq5HXggovXtcpHsPbgKVMXt4FWNqt9auwnVmRx+NeXSsA+uQdI/fsLx
q14Aux/Bx1Q9DUBl20PaJBnUHqnKtoPLU8CgmPsqtKvZhNLV9XkVobcaV/5/lvQA
F5wlYPmLXZmq2ox0pkXiQyfwo7OBPmSjJF2sMiljtcmgUWxjTi6PYL/X/FAk1A8X
Wh6jLKgnErAF6jXVD1dA/ih+XA3SHHQILXRVIhgeejnjox4nr7xhrUYm4U31P5Qi
YE6GTUjhMASs8wjTyrBDMzQWb3tf/bKW7F9K75NB1hCIpONyNwNhjfCrBvM/69Ul
zjs6e3cTBLuSi1z9qHRdPHCxYLkJ7/hWUvumO2TKHtR+RtBiMps=
=WySC
-----END PGP SIGNATURE-----

--ZOV3GiYUm21DClSB--