Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 6 Jun 2024 08:51:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Floris Van Nee <florisvannee@optiver.com>
Cc: Andres Freund <andres@anarazel.de>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	"exclusion@gmail.com" <exclusion@gmail.com>,
	"pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17947: Combination of replslots pgstat issues causes
 error/assertion failure
Message-ID: <ZmD57ld6KIhJ4Pmi@paquier.xyz>
References: <17947-b9554521ad963c9c@postgresql.org>
 <20230601.084245.1524588196504400333.horikyota.ntt@gmail.com>
 <20240505183741.5tefii3razzefvtc@awork3.anarazel.de>
 <dd4c68beba5c40c5a7946569d450ec59@Optiver.com>
 <Zl6lQ_K0-QOfqUS4@paquier.xyz>
 <a3de68e3a48c4a55a3f6f64d87486ffd@Optiver.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GutFD5T00eO8jbTe"
Content-Disposition: inline
In-Reply-To: <a3de68e3a48c4a55a3f6f64d87486ffd@Optiver.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZmD57ld6KIhJ4Pmi%40paquier.xyz>
Precedence: bulk


--GutFD5T00eO8jbTe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 05, 2024 at 10:24:43AM +0000, Floris Van Nee wrote:
> I noticed it but wasn't sure if it was necessary here due to the exceptio=
nal case here.
> It raises ereport error right after and can only reach this if the entry =
was created
> In the call to pgstat_prep_pending_entry before it, so it seems unlikely =
another
> backend holds a ref to it. I might be wrong though.

It does not prevent addressing the original issue, so pushed down to
15 after running concurrent tests for a few extra hours.

>> Attached is an updated patch with refined comments at the top of ?
>> pgstat_drop_entry(), to be applied to 15~.
>=20
> Thanks for testing the patch. Updated patch looks good to me.

I'll try to look at this one separately.
--
Michael

--GutFD5T00eO8jbTe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZg+e4ACgkQnvQgOdby
QH2FNA/+NPYD5eIZxj2n5p4TWVbTkBpaGzjUEmZD3NXspDbW0pL6ScDAAQxBKSua
Wunqc8TilfKQHh1j82caJ2JYNBG7c+v75TCkdjQe7dNfn/sERYPDbOpSNVfCoWNz
cNpuD8v48bpSZHxKHAhz3I5UhnK1+GD/xIvZUmxjIIQor8Tsw7KyaSg/4s5PVGII
OcGgRZAF5AnF5Kpcj8Yf/LayMtrJWVUEp0FlWmphbXmrsZ042uDbSHAdy9fYStSX
W4w9kiO0rG7QNZv2OczL+osRVT0NyUBldu/S+Xd/VhfObUZXCad5z902mUg+ANeq
TtOr2plBdrADb0U5PR6BHSg9apCUq8CzoeWq1nlILEk+ZVVcEhr3y9Mnk9sRJPyN
A4PVS71JYVgr5t9F63qIf35zxPTSAuc2yE4J/IiToPuHHobLhSt9lXaZtdk6Meb3
PqF4+0Ut/qd3yaFmNXGRufHJbsNRGwe3gF24SmCG4taoCe7sFWLizgXfCddS2fSL
HgJKdhbRqjMxCi+/O65nFFlMcZCjU4KgzMZHFBAScqfVUCkIMlU5ifffevUQ+Lq+
y7//tmfxT9nOMD+lOW9tyjGDgedjtIbLJZO8gqtHZ0k8AldqzJ9GIeJrx8GXKEcd
PA1qPE35TC0/W45KBR1gDhWbkWJNH13RfRKTSnovJNLQTmLvSq8=
=JgxE
-----END PGP SIGNATURE-----

--GutFD5T00eO8jbTe--