Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sJ4vo-002FPe-Tk for pgsql-bugs@arkaria.postgresql.org; Mon, 17 Jun 2024 05:29:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sJ4vm-00DPcf-Gr for pgsql-bugs@arkaria.postgresql.org; Mon, 17 Jun 2024 05:29:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sJ4vm-00DPcX-8c for pgsql-bugs@lists.postgresql.org; Mon, 17 Jun 2024 05:29:27 +0000 Received: from fhigh3-smtp.messagingengine.com ([103.168.172.154]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sJ4vk-0024YC-SV for pgsql-bugs@lists.postgresql.org; Mon, 17 Jun 2024 05:29:26 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 2728C11400FA; Mon, 17 Jun 2024 01:29:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 17 Jun 2024 01:29:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1718602163; x=1718688563; bh=bt/JEdvV02 l3OwNqG3I9Z+3a2zoWv4A2OKjKhCYcUvc=; b=JRv7/NKH7XiajnJobQW3PUeH/z U9V0JrpvszeOT3aXK2EP9TG87D9WvrqKulxueO7sP7DwZfSaCjlUpaYIJ7RJHZQ1 0gPlc5NmlfjirInqvVGy+4eeM9Gw8g9D5fFYA1ZwUMyYXJ6xLLojYgjIWXKroe4u VCeETcseMKe6H3EuQnfCK3pf8r+VM1uwOwy9UUfwyXEoYBNjkvYXsUyoAGCTCF9M 1Ks+bdE46+RZyiS+69XAbr99wbLOF5bg4+/weU455rZ4MqnByOQQHKdJUVyntgBl +QdegjP7QohzoBcWfMFHhHWb0QOTCGKV0iTFLwFIJEZnF7StCihWNa0Q7RpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1718602163; x=1718688563; bh=bt/JEdvV02l3OwNqG3I9Z+3a2zoW v4A2OKjKhCYcUvc=; b=npcWjNcvumMAKK4911/Q1H7AfF/0GZ8T0ImLRju1sec3 AOHvL/mjwU4GE7Uk59TuNdkY/5ZB4yoNGY6UpfV9b64JU9noFsPUykXYjiuMQ6x3 9Xhr71TIQizVkEEnaxUNYEWJyaRojCmOnzZ9vfTT8hUlppdcgC/wI/JMvRrHXuOm 53ylC5PniqRLrFRsAe82GZeV+317gw6KNd79opr15L2ZZKmQC2qqdd5TRaQBDmFN d2pm+KROdnPGqwRC1f3VGLVgGYKVYsRptHI1JBh5nioB1OZ2h4SQC0eAGybvfn7P LMyKju8LXm6PCT+oWgluDho3XMCczfcV5R+lWB4bhQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedvgedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvvefukfhfgggtuggjsehgtderredttddunecuhfhrohhmpefoihgthhgrvghlucfrrghq uhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvg hrnhepgfehhefgudefudfgfeelgeeiffegfefhkeefffdvheefuddtheetgeelteevkeet necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 Jun 2024 01:29:21 -0400 (EDT) Date: Mon, 17 Jun 2024 14:29:05 +0900 From: Michael Paquier To: Alexander Lakhin Cc: Tom Lane , a.kozhemyakin@postgrespro.ru, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18483: Segmentation fault in tests modules Message-ID: References: <18483-30bfff42de238000@postgresql.org> <219049.1717792376@sss.pgh.pa.us> <439c9310-1d71-f2c6-b213-a9a2ea732ba9@gmail.com> <336833.1717859243@sss.pgh.pa.us> <250a21e5-d677-6b2a-2692-cd4233785e37@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IWlKxPugcVKImUjF" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --IWlKxPugcVKImUjF Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 10, 2024 at 02:50:33PM +0900, Michael Paquier wrote: > On Sun, Jun 09, 2024 at 03:00:00PM +0300, Alexander Lakhin wrote: >> 4) >> I guess, make_tuple_indirect() could be improved with: >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 /* only work on existing, = not-null varlenas */ >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (TupleDescAttr(tupdesc,= i)->attisdropped || >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 nu= lls[i] || >> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 Tupl= eDescAttr(tupdesc, i)->attlen !=3D -1) >> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 Tupl= eDescAttr(tupdesc, i)->attlen !=3D -1 || >> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 Tupl= eDescAttr(tupdesc, i)->attstorage =3D=3D TYPSTORAGE_PLAIN) >=20 > Fun. True enough that this function is only here for toastable > values, so that makes sense. This one was indeed simple enough, so fixed it for now. -- Michael --IWlKxPugcVKImUjF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZvyaEACgkQnvQgOdby QH1X0g/8Du9+aR7QixNMAqqjpoKk5TSz9Q75gxIAblHXjwF0SjEoM3L8TpK0L/jJ QwSFP0rt6r2flgua/iF7c+DwwepkvOPKNkIqYIP9+N+jqoUUr0E/T35INyN+hcl7 a2m9/rHz3zxltkzjwqxVSTKvWzcudujjXGUQD20y8c7AQu0/Pu4v/L8Qs89EXvJ6 dMdJS5Eu3AXF2HNO1w3/GVLE6WtxTnPG0Lns/cQqN0PAECrZsRRJxSFqH+9CNj1U JNTiSSpuWjLO65lhDKnTIKXs6DuNTzV6WaHQ1sqJ/L+9BrzpNNauoOU8a0Kz+rSR wpaipKbvU2JCKj7ReKsFCZGIger9+RWw7ykmywT/S9/rSnKwGS2na8/PNl7WdGPE kn2J+WF5LVEP27saF7QWsaKSFXJHbjL8hX0UhoghILO7RI/U99iHxhU1CitAgejW OjiJGPx9hAl0RYoOy5BeqqO6jWvn8/5K1B97BWUmRshDDMOEOZToXCiCBbkhvKRk xhtwgFeQTBqaVPIY9yxIZdmBNKKidw2mD1Q3lAVI420jk6T/yxmOvN2aR6Vu++P+ AjSQRh96shgvXy9s1VZkZYaHlPTDalVApOQreLgp50P3HFB148KsiZMYgDK+O4DW SqckIxJog/85/Lq9Mpure9UXnr7mf6l8mkBSgwxr20n5fK84HNY= =Kx3e -----END PGP SIGNATURE----- --IWlKxPugcVKImUjF--