Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 29 Jun 2024 09:15:09 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tender Wang <tndrwang@gmail.com>, exclusion@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18500: Detaching a partition with an index manually
 attached to the parent's index triggers Assert
Message-ID: <Zn9SDY0r9fLTqqDO@paquier.xyz>
References: 
 <CAHewXNkyq88YBfCMbgnbquEwi+f5nyGOZ1axmo4ueLmkC=Am_A@mail.gmail.com>
 <202406281127.piekjwgnulgf@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="OIwr9j0nxuMwMBQR"
Content-Disposition: inline
In-Reply-To: <202406281127.piekjwgnulgf@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/Zn9SDY0r9fLTqqDO%40paquier.xyz>
Precedence: bulk


--OIwr9j0nxuMwMBQR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jun 28, 2024 at 01:27:17PM +0200, Alvaro Herrera wrote:
> I guess you could also fix this by adding a PK constraint to the parent
> table, so that the situation is consistent in the other direction.

Yes, I've also considered this option when thinking about this thread,
but forcing a constraint creation up to the parent felt non-intuitive
to me as we force creation of catalog entries on the children based on
the state of the parent for basically everything else.  So introducing
a new path where we would do the reverse is a recipe for more complex
code in tablecmds.c, which I'd rather avoid.

> Here's a proposed patch for master only.  It turns all three situations
> being reported into ereport(ERROR); in one case I have an XXX comment,
> because we have an alternative when attaching a partition that already
> has a PK to a partitioned table that has a non-PK index: just create a
> separate index in the partition.  But that would cause slowness, which
> is probably undesirable.  I'm inclined to just remove the XXX comment,
> but if anyone has other thoughts, they are welcome.

An error sounds saner here in the long term.

Tests for all of the code paths involved, perhaps?  ;)
--
Michael

--OIwr9j0nxuMwMBQR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZ/Ug0ACgkQnvQgOdby
QH1ZnA/9EXUlpfuC7A+O0rCa7NIti1DqVigaG3AWk3FU1EcgqFTzT5RLnToejv9l
WZzFwKl0kP6lvgzR+Sxo4ZxsZplWoqWubg3vWiY6mPhX5Kh+AV8ybBvySbLLRsax
LhBm2NjVPF3h63ZQevPDPHMfWAP9ogv9IGQftSjY3s2AhJj+FnoDP8lW5ip2ylSj
4LIkR7DfQ5/h/Ibi2lxqwEzPE6aUHHqn0qIbZjSdp14fOysCb5eIcyKDxrz/ma1B
2fBri5fnAVQUqJzVtrJkxMOF25NaRd0V66Td8qyXom/C9T3VGCRgdUgWZwh+XoCV
BVlTf5lbh1+GUSZBRNJ57ZlYVDfZTEnfBcUPgv+wfVli5misV/0luaNa+ZXWhb3S
i+u1Fw9i5Tn/Dq2PBM6lvBqhz/OFauorpD9RXqoDpQyKeAQvhxsqD5JQABqdrU//
ZPLeMGZSPUo6e44N5nm0ur5IYBThQsgqF9W/YFBe+GqUaO/Kf3+t1wPVek4qX8wa
C1ZtMMxnoJfmsrh62LUdZTxQ6XsN7V5uD42qgcM0i1xZBoRx2hJpVLnc9rlZMwFh
pQKNfqfu6x0w2Cl2Kab6WV54zkDG72icpT8kEDf9djT4gEgAU4MQTirlmiHsQJM3
yXG1wJuXCGNgdWtnytp2D5CYnSEv7vbUuRePWzAlrqFQgyhIJoY=
=6stp
-----END PGP SIGNATURE-----

--OIwr9j0nxuMwMBQR--