Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sKTTu-00AQeq-JX for pgsql-bugs@arkaria.postgresql.org; Fri, 21 Jun 2024 01:54:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sKTTs-005sY5-Qo for pgsql-bugs@arkaria.postgresql.org; Fri, 21 Jun 2024 01:54:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sKTTs-005sXt-I7 for pgsql-bugs@lists.postgresql.org; Fri, 21 Jun 2024 01:54:24 +0000 Received: from fhigh4-smtp.messagingengine.com ([103.168.172.155]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sKTTq-002kOG-O6 for pgsql-bugs@lists.postgresql.org; Fri, 21 Jun 2024 01:54:24 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 4AE781140183; Thu, 20 Jun 2024 21:54:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 20 Jun 2024 21:54:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1718934861; x=1719021261; bh=uP0+FHHq8X n4YH/iVa797vg5bm1NSDJAFOB2F4rGjaI=; b=DdPYIFfSUhsAYyHWawWq6GgrgX lsI5rlyYUkw+eJKhDJIi9I31qylyoHymEp6B1EqxkAMwJ0vQXC1CQZ9LgNIywgkH 1UYvh3GXqytVfcchX5hkezoskMULlQq9Ivrg+ACxPtHW6O/6rBlAeFTWlviVgKZA EzPw1fTqEeOQyc0upicm8f6sdkpVO9g9d5Qn+8Oz9xjRpEhWa+Z/XpxcP2RM0pq+ yA2m4TrqUDHcV58+JJm/Ytd5Wuj1knQt8AfyLjuo+1Fbqw2Cw6h77rKyd0q6ed2P 5yEHVqfXLBMcGlV9RsEbw++7OilMYjC2eOvSOXtsBzzCCga8vc58NVAL/XYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1718934861; x=1719021261; bh=uP0+FHHq8Xn4YH/iVa797vg5bm1N SDJAFOB2F4rGjaI=; b=T1XBcqWUAQIWwoMxOdcaa2AqN+1A7v8sjM0ZdsUFRp2z MSK5DoX/k3EtcIBUATxPEI+k7nZjKEwjhZyelB3HBhPzQqFVjnrHYY7h/jnYpIhA 8AG2Mw+dpAbSjsC3XaSC9u3Ex+VGJm6X/0MZFM9EvAw29AJQyjbmZi+Wmxky61NN pE13m3AEB9KcRmxsiFC461GR0DpVqY77Mii3c4IvL9XaNztRRd3xsHzbgY+SriCm 9G+6xvQwo7LDsYTJ0Kv6Hcae4sY6KRkMRpl1g3kVfgwDGbw0fotndZ9/K/+gIbIM WIcj7/9me3k+H8OISD6hQGx4Zl3OBEXgTJO57SKxCw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeeffedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghq uhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvg hrnhepteelieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdej necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Jun 2024 21:54:19 -0400 (EDT) Date: Fri, 21 Jun 2024 10:54:09 +0900 From: Michael Paquier To: Tom Lane Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18499: Reindexing spgist index concurrently triggers Assert("TransactionIdIsValid(state->myXid)") Message-ID: References: <18499-8a519c280f956480@postgresql.org> <428421.1717887173@sss.pgh.pa.us> <3030961.1718570047@sss.pgh.pa.us> <3045795.1718578372@sss.pgh.pa.us> <3050563.1718580646@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="It7ecFYJ9Q8Q5LbZ" Content-Disposition: inline In-Reply-To: <3050563.1718580646@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --It7ecFYJ9Q8Q5LbZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jun 16, 2024 at 07:30:46PM -0400, Tom Lane wrote: > Right. I was thinking that CIC wouldn't reach spginsert(), rather > spgbuild(), but it does feel a bit rickety. A separate flag would > be better. Why does it feel rickety for you? We already rely on this flag so it does not seem like a huge problem to rely on it again for the sake of this index AM. -- Michael --It7ecFYJ9Q8Q5LbZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZ03UEACgkQnvQgOdby QH2YIhAAlPZ1pN3DAaUuXDsFgBj3gjUVAoJrBggwaHp/mT8azj0Bak6wZyEmEw3e kDLbbKqd1FksfCK/yOeN3nf2B8m0dHP0siWFyz4tR4w3WVtYeWfi8C0pDzhHVAlq 1ctkMQKStPooRpWWwCnk7WmZJQinJJUo4Yp2FFsxw8vJIXJNkzIUjzG3MgCzUpB5 Z+QocL5jQIMWoQFspphRS60Gpj3bvaYZnqJh2l0bQ5lm7rXdYdN+utDg9Uml2nl0 a9FiJaXQ1Yxi+1ZPGVBlIaPZeRVyFhuvLso7wmBpHiL49aY+LnUWn9rr0IQf+Blt fpiIdCe8j7+wBPEt/KT7Al8CR9nW5/Fxy1dGLGQy1AGZ15WYTGJ5aaW97V1SZKLA SBLegt7Av2sQX44zTMQgQEbjZ8EUk3h89HAvxAZry/ILfRuP0dTcaMT9bSuTGr3U NV0cIgK+EFTWueu37w2/X8GuYEmMm6FTzDKgoiHIwdSjCwOvBYioe8pTK2qDk5U4 spx/hwiW+qGBntWmjOyLkku42ISG5ppC6QE+yEjFxd8+MA3h/ImZZ3j2IokO5JYh oY8KYFEsyU6XzR4oR0mbU8GFv997iFn7pMLiKwgS+viges9kLzD+pJPgom967IhI TM1odGJFgBXG8tfS2IQavqvi+rDvD+3fCEMYFSpRVj/VpWvPAN0= =7iPc -----END PGP SIGNATURE----- --It7ecFYJ9Q8Q5LbZ--