Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 10 Jul 2024 08:12:29 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Chris Travers <chris.travers@stormatics.tech>,
	Farooq Rashed <farooq.rashed@desc.gov.ae>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: pg_rewind fails on Windows where tablespaces are used
Message-ID: <Zo3D3Y24Kd1eTV8n@paquier.xyz>
References: 
 <CA+pA0kLc5VxOaO4WfLjmh7W0V+quVvVtT5CaRVRAZMuh0zft4Q@mail.gmail.com>
 <Zl6dsK5IcNGTL0qD@paquier.xyz>
 <5169f6d5-240e-49ec-9265-ddafa6e863bd@dunslane.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MIIlTDOwAbcOUihE"
Content-Disposition: inline
In-Reply-To: <5169f6d5-240e-49ec-9265-ddafa6e863bd@dunslane.net>
Archived-At: 
 <https://www.postgresql.org/message-id/Zo3D3Y24Kd1eTV8n%40paquier.xyz>
Precedence: bulk


--MIIlTDOwAbcOUihE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 09, 2024 at 12:01:17PM -0400, Andrew Dunstan wrote:
> The solution I came up with was to backpatch commits c5cb8f3b, 387803d8 and
> 5fc88c5d53.

The lstat() wrapper for Windows, noted.

> I don't think we need to do anything relating to in-place tablespaces. These
> are documented as a developer only option and not for production.

Okay, cool.

> The only question in my mind is whether those patches should be
> backpatched.
>
> It's a couple of hundred lines, and I think it's safe, but I'd welcome other
> opinions. If we are going to backpatch them we should also look at adding to
> adding tests for use of tablespaces with pg_rewind on the back branches.
> Ideally we'd get this done in time for the next maintenance release.

Seeing that the commits all go down to v16, meaning that these have
brewed across 3 minor releases already, I'd like to assume that we
would have already heard about problems related to them.  So that
seems like a rather safe thing to do at this stage.
--
Michael

--MIIlTDOwAbcOUihE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmaNw90ACgkQnvQgOdby
QH1XpA/9G6WKiY5lyRG4EInU+Sh8KAxeafrXimrGwo0yfMaW1K05O8MPCJYNjs66
5Q7uljohvuYHnZssNlBdxQCpbr6TqtFKNisgsxutNZWOHwrtOLOsr9Mz585ayVVb
2qyQFdj2uNaBipor+Y8t1YqYwbEBGXzTcLds0PMBPvB8ZS0yuZleyZKn2EcRvo1h
VTxwqqUt1fjB9h8JqNk5Xk4sC81eKnRXIL6oV3Ts1fyQRI60rnRJewjydfsYaVyR
KoGP8OAnAy/u278G5ONwEY+ST7hxTCshU375wh8XL58CGN4zA8RQX6UCx+N16cHj
IlK8CpRFFIAodCho81hSK6FOrgalrfdwtTKSzSsawDkupAmmfvNEWocg1n1RzK6m
13PfsFO96N4B+Zm/t7JyzPGn4ZID/RJhRRXMSqNHV9ZdjdnKkXgL17AaVIhtqsuQ
eFOiXRFaOHzSlBDM5td+UVGte1VUIk8PqIukHKuRwHX2wXcK7mcbsgFEtbCaWzOw
S2ObBUlbTj96iZuxfjjRLcNHQ46M1MiOwSfqVBg5YM80aAhybR0H5mZE4YDIfcUt
uVd+gNFgPySLUPMvRUJbEhNC99XDQTf1xiNLB75pNSNc+3b+ZPAzJ1vLmfTzeazd
Ecs9Gyf+yZsfZB/KO8N3y1hBnVF3o7r1SEMuYJmYnhEwRfEyseA=
=rH1i
-----END PGP SIGNATURE-----

--MIIlTDOwAbcOUihE--