Date: Tue, 24 Sep 2024 09:30:21 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Christophe Pettus <xof@thebuild.com>
Cc: vaibhave postgres <postgresvaibhave@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Noah Misch <noah@leadboat.com>,
	PostgreSQL Bug List <pgsql-bugs@lists.postgresql.org>,
	vsekar@microsoft.com
Subject: Re: vacuumdb: permission denied for schema "pg_temp_7"
Message-ID: <ZvLM_Rqel-t_58IQ@nathan>
References: <Zu3iMzfiGBTbg3iy@nathan>
 <20240920215030.8d.nmisch@google.com>
 <2603142.1726873660@sss.pgh.pa.us>
 <5f37ee56-14fb-44fe-9150-9eb97e10538b@oss.nttdata.com>
 <2649165.1726898595@sss.pgh.pa.us>
 <CAM_eQjyWnu_LUt6JWjh3boNFHAT9DBrcbamhG3Xy39Q4Ph=2rg@mail.gmail.com>
 <ZvGye19tHrhLCpFl@nathan>
 <E9660D68-5B26-488E-9AB2-2CA1E8EDDDA1@thebuild.com>
 <CAM_eQjxZC2RNTGZ0NZLtkZ5DVn1=L6GBrUWzt-MkU4X4k5h60g@mail.gmail.com>
 <FA25664E-EDD5-42BE-AA25-1321E0A0C8BC@thebuild.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <FA25664E-EDD5-42BE-AA25-1321E0A0C8BC@thebuild.com>
Archived-At: <https://www.postgresql.org/message-id/ZvLM_Rqel-t_58IQ%40nathan>
Precedence: bulk

On Mon, Sep 23, 2024 at 06:13:23PM -0700, Christophe Pettus wrote:
> One related but not identical thing that has come up with vacuumdb is
> that it terminates if it's not able to connect to any database that it
> finds in the initial query.  This can happen if pg_hba.conf denies the
> user that is running vacuumdb access to a database that comes up during
> --all.  Some hosting providers (in particular, Google) create restricted
> databases in the cluster that a customer role can't get access to.  This
> pretty much defeats --analyze-in-stages.  My suggested fix was to
> terminate with an error if the initial connection fails, but continue
> with a warning if further connections fail.

I think it'd be fine to continue with a warning when --all is used, but if
you specify a --dbname that you cannot connect to, then I think it should
fail.

-- 
nathan