Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 27 Sep 2024 09:45:12 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tender Wang <tndrwang@gmail.com>
Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18630: Incorrect memory access inside
 ReindexIsProcessingIndex() on VACUUM
Message-ID: <ZvYAGAdUEArQsOdA@paquier.xyz>
References: <18630-9aed99c38830657d@postgresql.org>
 <CAHewXNnNZXbq_sW=OP-O-1nnMEnpXJX6djbzF52LtDA6tOutiQ@mail.gmail.com>
 <CAHewXNkKeE3i7aT_nysWphRHhwMnyG1r55Di=RCNtLa5dRSd4Q@mail.gmail.com>
 <ZvUG1qsjXqppi2BO@paquier.xyz>
 <CAHewXNkKDAfco=7ti=pphiPb0uRb=GFM2x4Z2St1HkG7J-32RA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="aS7z2X+/JxBI+qpM"
Content-Disposition: inline
In-Reply-To: 
 <CAHewXNkKDAfco=7ti=pphiPb0uRb=GFM2x4Z2St1HkG7J-32RA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZvYAGAdUEArQsOdA%40paquier.xyz>
Precedence: bulk


--aS7z2X+/JxBI+qpM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Sep 26, 2024 at 03:24:25PM +0800, Tender Wang wrote:
> Agree. The attached patch LGTM.

I have fixed this issue and backpatched it all the way down for now.

One thing that we still lack is a set of reliable tests.  This can be
achieved with injection points, and that's much broader than only this
thread.  I'd like to get the coverage with two types of tests,
roughly:
- Isolation, with waits across the steps of REINDEX CONCURRENTLY, and
some concurrent operation.  This thread used one.
- SQL tests, where we could force errors in some code paths to get an
incorrect state.  Putting ourselves in a corner where there is an
invalid toast index is just one state.  CIC with a UNIQUE index gives
this possibility, but this just works for a "new" index, for early
stages of REINDEX CONCURRENTLY.
--
Michael

--aS7z2X+/JxBI+qpM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmb2ABgACgkQnvQgOdby
QH1HRg//SBPNZxfMb0BcC7N/oMIJVq408hnqM7RVV2ACHp46eWX+GEsIgAbWqReP
Q/e2l5P7dTyYUgKzMYmF0Xc8GjqWk4Akx1ivHcdWHvsXYdXTgwoaTo1u4+eSnJi8
lHzQJ6ST21ogKwhdQtuXCeSYWsuYXjKr03HGSJLz3ybuB2HbFqzsBtFZh2U9IF+0
POrGvY01UDSfAf/+Cb7bvPNTtv/O758bj9UIMStbUG+4J8zLio9+6wI/3m7AUr9B
ec0yOwxPGYq5dOhCATUKXrXRmJClT74OiUXOu2ODQRs7uNtfdmDyot+EFbuVrt15
FYOHzQBLYSP+MA56wncRedx0VadP2Ytuz1J6MZPuQ22x6xwq/sbIs6yEToT6oH/I
ZNF9A6fYjl4A/FStqIw6YfFZ+kZV9d4psX429zNPH18FbgMOErS7Xbfu/77jdPwX
dfW1XCLaXrjXFLsOmbokoRAMgU4QskKkupDyplsg0IQ1YLSEZ9NopoNOBnJrfvB2
d6eS2Aj2NBNfBb68uDX12hBY0EANnImT8mlWCBq0OteQU+2BxcIfxuFZUp1KrNba
wW+UJYmGp7c6ubHJ1eQSJOQmt9JNSKWyqmYaagn0CdS5K31/08+UYreW3A8C9wAk
5uli99DSp5pTSUQHoMN2TiI4LUv2YUMTJTr0IV3OBiKfKLe+wYs=
=Nit0
-----END PGP SIGNATURE-----

--aS7z2X+/JxBI+qpM--