Date: Mon, 7 Oct 2024 11:16:33 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>,
	Christophe Pettus <xof@thebuild.com>,
	vaibhave postgres <postgresvaibhave@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>,
	pgsql-bugs@lists.postgresql.org, vsekar@microsoft.com
Subject: Re: vacuumdb: permission denied for schema "pg_temp_7"
Message-ID: <ZwQJYcuPPUsF0reU@nathan>
References: <20240920215030.8d.nmisch@google.com>
 <2603142.1726873660@sss.pgh.pa.us>
 <5f37ee56-14fb-44fe-9150-9eb97e10538b@oss.nttdata.com>
 <2649165.1726898595@sss.pgh.pa.us>
 <CAM_eQjyWnu_LUt6JWjh3boNFHAT9DBrcbamhG3Xy39Q4Ph=2rg@mail.gmail.com>
 <ZvGye19tHrhLCpFl@nathan>
 <E9660D68-5B26-488E-9AB2-2CA1E8EDDDA1@thebuild.com>
 <ZvIRG6282T33q3Ku@paquier.xyz>
 <00d98a9f-bec1-4cd0-b59e-1043ae04c8bc@oss.nttdata.com>
 <ZvNG2H9GzpQ7YrFQ@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="3Oxtwi2qhLuGW5nt"
Content-Disposition: inline
In-Reply-To: <ZvNG2H9GzpQ7YrFQ@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/ZwQJYcuPPUsF0reU%40nathan>
Precedence: bulk


--3Oxtwi2qhLuGW5nt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Regarding commit 1ab67c9...

On Wed, Sep 25, 2024 at 08:10:16AM +0900, Michael Paquier wrote:
> Thanks.  As I am kind of behind this one, I'll go fix it first.  Let's
> sort out the permission bits after that one is sorted out.  REL_17_0
> is out, so this can happen across all branches.

For consistency with the surrounding code, I think we should schema-qualify
the operator and add a newline after "WHERE relpersistence != 't'".  If
folks agree, I can handle committing the attached patch.

-- 
nathan

--3Oxtwi2qhLuGW5nt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="fix_1ab67c9.patch"

diff --git a/src/bin/scripts/vacuumdb.c b/src/bin/scripts/vacuumdb.c
index 249622068a..d07ab7d67e 100644
--- a/src/bin/scripts/vacuumdb.c
+++ b/src/bin/scripts/vacuumdb.c
@@ -684,7 +684,8 @@ vacuum_one_database(ConnParams *cparams,
 	 * Exclude temporary tables, beginning the WHERE clause.
 	 */
 	appendPQExpBufferStr(&catalog_query,
-						 " WHERE c.relpersistence != " CppAsString2(RELPERSISTENCE_TEMP));
+						 " WHERE c.relpersistence OPERATOR(pg_catalog.!=) "
+						 CppAsString2(RELPERSISTENCE_TEMP) "\n");
 
 	/*
 	 * Used to match the tables or schemas listed by the user, for the WHERE

--3Oxtwi2qhLuGW5nt--