Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 18 Oct 2024 14:51:32 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bruce Momjian <bruce@momjian.us>
Cc: p.nekrasov@fobos-nt.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18614: [ECPG] out of bound in DecodeDateTime
Message-ID: <ZxH3ZGK19VxTJcpU@paquier.xyz>
References: <18614-6bbe00117352309e@postgresql.org>
 <Zw2Su7kkYYF8nHQY@momjian.us>
 <Zw8GQrLHlgJlz3Qc@paquier.xyz>
 <ZxFJX8Jjoy8T-67v@momjian.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wP200Tdrea4G8r4p"
Content-Disposition: inline
In-Reply-To: <ZxFJX8Jjoy8T-67v@momjian.us>
Archived-At: 
 <https://www.postgresql.org/message-id/ZxH3ZGK19VxTJcpU%40paquier.xyz>
Precedence: bulk


--wP200Tdrea4G8r4p
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 17, 2024 at 01:29:03PM -0400, Bruce Momjian wrote:
> Added in the attached patch. Is the output correct?

Well, no.  The result in the regression test output you are producing
is a consequence that PGTYPEStimestamp_from_asc() returns
PGTYPES_TS_BAD_TIMESTAMP as errno with 0 as result.  Hence, after
applying an offset this prints a timestamp with year 2000.  What this
should report in the regression test output is the information about
the error happening, so the output that makes no sense because the
timestamp could not be understood.

> +	ts1 = PGTYPEStimestamp_from_asc("AM95000062", NULL);
> +	text = PGTYPEStimestamp_to_asc(ts1);
> +	printf("timestamp_to_asc4: %s\n", text);
> +	PGTYPESchar_free(text);
> +
>  /*	abc-03:10:35-def-02/11/94-gh  */
>  /*      12345678901234567890123456789 */

It is not entirely the fault of this patch, because the same error is
done a couple of lines above when using an incorrect hour number with
timestamp_to_asc3.  The correct thing to do would be in the lines of
what num_test2.pgc does with its check_errno(), I think where we'd
check for the errno returned by PGTYPEStimestamp_from_asc() and
printf() its information in the output of the test.  And we should do
that for both the old timestamp_to_asc3 and your new timestamp_to_asc4
if we want to be completely correct.
--
Michael

--wP200Tdrea4G8r4p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmcR92QACgkQnvQgOdby
QH2rihAApLmdF2Eo4VoWZIJCjoecvMO5ZGGi9yk/y/tzNc+gs5zJsrsD4G3ECtok
9wzR+IMOaSDZadTVEEJtB7FRIuDJX9ElitPru3Yb+YkaHKa/PwS/rVhlVc5f9150
+zJ06j/RkcIw1pwSKhftrIGUZ2JO9589e+cgpg667fDDmLcho57rts++q0cml+0m
rXTefGaeXZgP5rmqTmW9/uOZ27kBA6W1WiO9C4quZGCHsTvGhEnWYyoTuSOZjb14
qTjaBUijr+kRqIkAaAf06t1TsN9oNUSMZ3s79/8PCenZZx3TNZB5KGTa0hph6Gk1
97/fThH+6NocTwIx8nRtjtIrfioGDT2V7/MI0ewkXKVEnyBgusUYfE1g/NmJD1Qg
aX3GnNFnL1KD/h4dUgrTKe/PxUXta7vSYbZUYMi1SPZds461Y1HnpG+eaJgtrFJs
ICXiHx3fgO/e13hQTi6af4k4d/DIiJ/AYtKi56Z8DzHDzOBLfWnjBQuncACQowIK
DiU8S3dqI+9ND513fqQzOfGmsAJ1aJfu0LDUvLKqfqDWakeVq43ALNiQsZd5aGFi
r21KVT0aCG7qWjAq1KjAhIaV+lLwxhEnrw4MllL+hsz65gknpcofZ6CF7wEY03vA
6HAgClJTOH9esjlvOBVkWmNNalkrBGz+j+afwHw96Pf6qjPrbZA=
=0WaI
-----END PGP SIGNATURE-----

--wP200Tdrea4G8r4p--