Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xFwei-00000001zyQ-3Tcx for pgsql-bugs@arkaria.postgresql.org; Sun, 11 Oct 2026 16:44:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xFweh-00000005FHq-3Ol6 for pgsql-bugs@arkaria.postgresql.org; Sun, 11 Oct 2026 16:44:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xFweh-00000005FHh-2Iom for pgsql-bugs@lists.postgresql.org; Sun, 11 Oct 2026 16:44:11 +0000 Received: from avalon.crater.ch ([83.228.206.160]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xFwee-00000001V8K-3NW8 for pgsql-bugs@lists.postgresql.org; Sun, 11 Oct 2026 16:44:10 +0000 Received: from webmail.crater.ch (avalon.crater.ch [83.228.206.160]) by avalon.crater.ch (Postfix) with ESMTPSA id 1DDCC4000C for ; Sun, 11 Oct 2026 18:44:06 +0200 (CEST) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_75a1652c2831b5d4356546f25581b1f4" Date: Sun, 11 Oct 2026 18:44:05 +0200 From: expl0it3r@my-gate.net To: pgsql-bugs@lists.postgresql.org Subject: Static libpq and ecpglib clash with PThreads4W on Windows Message-ID: X-Sender: expl0it3r@my-gate.net User-Agent: Roundcube Webmail/1.2.1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_75a1652c2831b5d4356546f25581b1f4 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi, Linking the static libpq on Windows into an application that also uses a "real" pthreads library like PThreads4W fails with duplicate symbols: pthreadVC3d.lib(pthread.o) : error LNK2005: pthread_self already defined in pq.lib(pthread-win32.c.obj) pthreadVC3d.lib(pthread.o) : error LNK2005: pthread_mutex_init already defined in pq.lib(pthread-win32.c.obj) ... libpq and ecpglib each bring a small pthread emulation on Windows (src/port/pthread-win32.h with src/interfaces/libpq/pthread-win32.c, and ecpg-pthread-win32.h with the definitions in ecpglib/misc.c), and the functions are named exactly like the official pthread ones. The static PThreads4W library is a single object file, so there's no way around it on the application side. Depending on the link order, the two emulations also run into each other. On master, the following program fails to link against the static libecpg.a, libpq.a and PThreads4W: #include #include #include extern void *ECPGget_sqlca(void); int main(void) { PGconn *conn = PQconnectdb("host=localhost port=1 connect_timeout=1"); printf("%p %p\n", ECPGget_sqlca(), (void *) pthread_self().p); PQfinish(conn); return 0; } libpq.a(pthread-win32.c.obj) : error LNK2005: pthread_mutex_init already defined in libecpg.a(misc.c.obj) libpq.a(pthread-win32.c.obj) : error LNK2005: pthread_mutex_lock already defined in libecpg.a(misc.c.obj) libpq.a(pthread-win32.c.obj) : error LNK2005: pthread_mutex_unlock already defined in libecpg.a(misc.c.obj) I ran into this through vcpkg, where pdal on the static Windows triplets pulls in libpq together with mbedtls built with pthreads. I've patched the vcpkg version, so the static Windows triplets no longer fail on CI [1]. The attached patch renames the functions with macros in the two emulation headers to pq_pthread_* and ecpg_pthread_*. The headers are included by the definitions and by every caller, and none of the functions are in exports.txt, so the call sites and the DLL ABI stay the same. The "Cleaning up threading code" thread [2] discussed essentially the same fix for the emulations, but it seems that it hasn't been implemented yet. Tested with MSVC 2026 and meson on Windows: a full build, the ecpg suite (66 subtests including the thread tests), and the program above linking and running against the static libpq, ecpglib and PThreads4W, which fails on master. [1] https://github.com/microsoft/vcpkg/pull/54377 [2] https://postgr.es/m/CA+hUKG+XpCcqoNe3-3oUzuGUeRoxAKqGnEAedvOhotsNCxuS+Q@mail.gmail.com Kind regards, Lukas --=_75a1652c2831b5d4356546f25581b1f4 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=v1-0001-Rename-the-Windows-pthread-emulation-functions-in.patch Content-Disposition: attachment; filename=v1-0001-Rename-the-Windows-pthread-emulation-functions-in.patch; size=2689 RnJvbSA5YTZiYTgzM2E4NTNlZmJhZTJlYzBiNmUzN2VkZTRmMzU5NDUwMTMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/THVrYXM9MjBEPUMzPUJDcnJlbmJlcmdlcj89 IDxlWHBsMGl0M3JAbXktZ2F0ZS5uZXQ+CkRhdGU6IFN1biwgMTEgT2N0IDIwMjYgMTI6Mjk6NDQg KzAyMDAKU3ViamVjdDogW1BBVENIIHYxXSBSZW5hbWUgdGhlIFdpbmRvd3MgcHRocmVhZCBlbXVs YXRpb24gZnVuY3Rpb25zIGluIGxpYnBxCiBhbmQgZWNwZ2xpYgoKbGlicHEgYW5kIGVjcGdsaWIg ZWFjaCBjb21lIHdpdGggYSBzbWFsbCBwdGhyZWFkIGVtdWxhdGlvbiBvbiBXaW5kb3dzLAp3aG9z ZSBmdW5jdGlvbnMgaGF2ZSB0aGUgc2FtZSBuYW1lcyBhcyB0aGUgcmVhbCBvbmVzLCBlLmcuCnB0 aHJlYWRfbXV0ZXhfbG9jay4gV2hlbiBhbiBhcHBsaWNhdGlvbiBsaW5rcyB0aGUgc3RhdGljIGxp YnJhcmllcyBhbmQKYWxzbyB1c2VzIGEgcmVhbCBwdGhyZWFkcyBsaWJyYXJ5IGxpa2UgUFRocmVh ZHM0VywgdGhlIGxpbmtlciBmaW5kcyB0aGUKc2FtZSBzeW1ib2xzIHR3aWNlIGFuZCBmYWlscyB3 aXRoIExOSzIwMDUuIERlcGVuZGluZyBvbiB0aGUgbGluayBvcmRlciwKbGlicHEncyBhbmQgZWNw Z2xpYidzIGVtdWxhdGlvbnMgYWxzbyBlbmQgdXAgY2xhc2hpbmcgd2l0aCBlYWNoIG90aGVyLgoK UmVuYW1lIHRoZSBmdW5jdGlvbnMgd2l0aCBtYWNyb3MgaW4gdGhlIHR3byBlbXVsYXRpb24gaGVh ZGVycywgd2hpY2ggYXJlCmluY2x1ZGVkIGJ5IHRoZSBkZWZpbml0aW9ucyBhbmQgYnkgZXZlcnkg Y2FsbGVyLiBOb25lIG9mIHRoZSBmdW5jdGlvbnMKYXJlIGV4cG9ydGVkIGZyb20gdGhlIERMTHMs IHNvIHRoZSBBQkkgc3RheXMgdGhlIHNhbWUuCi0tLQogc3JjL2ludGVyZmFjZXMvZWNwZy9pbmNs dWRlL2VjcGctcHRocmVhZC13aW4zMi5oIHwgIDkgKysrKysrKysrCiBzcmMvcG9ydC9wdGhyZWFk LXdpbjMyLmggICAgICAgICAgICAgICAgICAgICAgICAgfCAxMSArKysrKysrKysrKwogMiBmaWxl cyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2ludGVyZmFjZXMv ZWNwZy9pbmNsdWRlL2VjcGctcHRocmVhZC13aW4zMi5oIGIvc3JjL2ludGVyZmFjZXMvZWNwZy9p bmNsdWRlL2VjcGctcHRocmVhZC13aW4zMi5oCmluZGV4IDdiNmJhNDYuLmM3NjQ5ZjggMTAwNjQ0 Ci0tLSBhL3NyYy9pbnRlcmZhY2VzL2VjcGcvaW5jbHVkZS9lY3BnLXB0aHJlYWQtd2luMzIuaAor KysgYi9zcmMvaW50ZXJmYWNlcy9lY3BnL2luY2x1ZGUvZWNwZy1wdGhyZWFkLXdpbjMyLmgKQEAg LTIzLDYgKzIzLDE1IEBAIHR5cGVkZWYgYm9vbCBwdGhyZWFkX29uY2VfdDsKICNkZWZpbmUgUFRI UkVBRF9NVVRFWF9JTklUSUFMSVpFUgl7IDAgfQogI2RlZmluZSBQVEhSRUFEX09OQ0VfSU5JVAkJ CWZhbHNlCiAKKy8qCisgKiBSZW5hbWUgdGhlIGVtdWxhdGlvbiBmdW5jdGlvbnMsIHNvIHRoZXkg ZG9uJ3QgY2xhc2ggd2l0aCBsaWJwcSdzIG9yIHdpdGggYQorICogcmVhbCBwdGhyZWFkcyBsaWJy YXJ5LCBsaWtlIFBUaHJlYWRzNFcsIHRoYXQgZW5kcyB1cCBpbiB0aGUgc2FtZSBzdGF0aWMKKyAq IGxpbmsuCisgKi8KKyNkZWZpbmUgcHRocmVhZF9tdXRleF9pbml0IGVjcGdfcHRocmVhZF9tdXRl eF9pbml0CisjZGVmaW5lIHB0aHJlYWRfbXV0ZXhfbG9jayBlY3BnX3B0aHJlYWRfbXV0ZXhfbG9j aworI2RlZmluZSBwdGhyZWFkX211dGV4X3VubG9jayBlY3BnX3B0aHJlYWRfbXV0ZXhfdW5sb2Nr CisKIGludAkJCXB0aHJlYWRfbXV0ZXhfaW5pdChwdGhyZWFkX211dGV4X3QgKiwgdm9pZCAqYXR0 cik7CiBpbnQJCQlwdGhyZWFkX211dGV4X2xvY2socHRocmVhZF9tdXRleF90ICopOwogaW50CQkJ cHRocmVhZF9tdXRleF91bmxvY2socHRocmVhZF9tdXRleF90ICopOwpkaWZmIC0tZ2l0IGEvc3Jj L3BvcnQvcHRocmVhZC13aW4zMi5oIGIvc3JjL3BvcnQvcHRocmVhZC13aW4zMi5oCmluZGV4IDVm MzMyNjkuLjk2NjQ4ZTUgMTAwNjQ0Ci0tLSBhL3NyYy9wb3J0L3B0aHJlYWQtd2luMzIuaAorKysg Yi9zcmMvcG9ydC9wdGhyZWFkLXdpbjMyLmgKQEAgLTQsNiArNCwxNyBAQAogI2lmbmRlZiBfX1BU SFJFQURfSAogI2RlZmluZSBfX1BUSFJFQURfSAogCisvKgorICogUmVuYW1lIHRoZSBlbXVsYXRp b24gZnVuY3Rpb25zLCBzbyB0aGV5IGRvbid0IGNsYXNoIHdpdGggYSByZWFsIHB0aHJlYWRzCisg KiBsaWJyYXJ5IG9uIFdpbmRvd3MsIGxpa2UgUFRocmVhZHM0VywgdGhhdCBlbmRzIHVwIGluIHRo ZSBzYW1lIHN0YXRpYyBsaW5rLgorICovCisjZGVmaW5lIHB0aHJlYWRfc2VsZiBwcV9wdGhyZWFk X3NlbGYKKyNkZWZpbmUgcHRocmVhZF9zZXRzcGVjaWZpYyBwcV9wdGhyZWFkX3NldHNwZWNpZmlj CisjZGVmaW5lIHB0aHJlYWRfZ2V0c3BlY2lmaWMgcHFfcHRocmVhZF9nZXRzcGVjaWZpYworI2Rl ZmluZSBwdGhyZWFkX211dGV4X2luaXQgcHFfcHRocmVhZF9tdXRleF9pbml0CisjZGVmaW5lIHB0 aHJlYWRfbXV0ZXhfbG9jayBwcV9wdGhyZWFkX211dGV4X2xvY2sKKyNkZWZpbmUgcHRocmVhZF9t dXRleF91bmxvY2sgcHFfcHRocmVhZF9tdXRleF91bmxvY2sKKwogdHlwZWRlZiBVTE9ORyBwdGhy ZWFkX2tleV90OwogCiB0eXBlZGVmIHN0cnVjdCBwdGhyZWFkX211dGV4X3QKLS0gCjIuNTUuMC53 aW5kb3dzLjUKCg== --=_75a1652c2831b5d4356546f25581b1f4--