Message-ID: <a2463df1-be45-4a76-b90f-7676d778e7b1@technowledgy.de>
Date: Fri, 22 Mar 2024 09:33:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: walther@technowledgy.de
Subject: Re: Regression tests fail with musl libc because libpq.so can't be
 loaded
Content-Language: en-US
To: Bruce Momjian <bruce@momjian.us>, Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
 Christophe Pettus <xof@thebuild.com>, Andrew Dunstan <andrew@dunslane.net>,
 PostgreSQL Bugs <pgsql-bugs@lists.postgresql.org>,
 Tom Lane <tgl@sss.pgh.pa.us>
References: <4093813.1710899588@sss.pgh.pa.us>
 <CA+hUKGKNK5V8XwwJJZm36s3EUy8V51xu4XiE8=26n=Wq3OGd4A@mail.gmail.com>
 <4095435.1710900216@sss.pgh.pa.us>
 <CA+hUKGK2cSx3dveMqBD+E9N=zJ0WawBcbk_jnPqmdWBM0DT_3Q@mail.gmail.com>
 <477fa513-6bf0-456d-8d24-1e22a19df671@technowledgy.de>
 <ZfrmN4WHuJgD95fw@momjian.us>
 <CA+hUKGJzC4rr2Yr=QZyx9W83Wv=TVJHndKF1anjNLNXVUM7TqQ@mail.gmail.com>
 <f98cd8de-1c66-491a-8409-e62c09932080@technowledgy.de>
 <36690fcf-f0c8-4d60-af49-6a7efa0e2b14@technowledgy.de>
 <CA+hUKGJAkTZUa9JGr-zsadaqsN=K0P71t-1L2t2=MQFDMc4GuQ@mail.gmail.com>
 <ZfzLsiXbguTDatiZ@momjian.us>
In-Reply-To: <ZfzLsiXbguTDatiZ@momjian.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/a2463df1-be45-4a76-b90f-7676d778e7b1%40technowledgy.de>
Precedence: bulk

Bruce Momjian:
> I suggest we use the #ifdef test to continue our existing behavior for
> the libraries we know about, like glibc, and use the LD_* process title
> truncation hack for libc's we don't recognize.
> 
> Attached is a prototype patch which implements this based on previous
> patches.

The condition to check for linux/glibc in your patch is slightly off:

   #if ! defined(__linux__) || (! defined(__GLIBC__) && 
defined(__UCLIBC__ ))

should be

   #if defined(__linux__) && ! (defined(__GLIBC__) || defined(__UCLIBC__ ))

With the latter, it passes tests with musl.

Best,

Wolfgang