Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kp7zo-0005R6-Vo for pgsql-bugs@arkaria.postgresql.org; Tue, 15 Dec 2020 10:55:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kp7zn-00085H-TG for pgsql-bugs@arkaria.postgresql.org; Tue, 15 Dec 2020 10:55:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kp7Yk-0007w1-4A for pgsql-bugs@lists.postgresql.org; Tue, 15 Dec 2020 10:27:58 +0000 Received: from post5.gaz-is.ru ([194.50.152.156]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kp7Yh-0008GH-5e for pgsql-bugs@lists.postgresql.org; Tue, 15 Dec 2020 10:27:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gaz-is.ru; i=@gaz-is.ru; q=dns/txt; s=Gazinformservice; t=1608028075; x=1639564075; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uHB+ITV5nJOliOYOsh2OyW1FRbQZAri4XqF/0mb6w9Y=; b=XK4LrxZbx+8xRYaiFoUwSrWoy5ZzBlXwXC/m7FkM7dM8Ck/KfIILw6qY PXyQgWMENo4hXGDU6rDEnu0LZ0B/weUdSKE6J5TOCT5uP9vVW0qVLd5jO D1SkwuC+Qy36Jr3HosEcjDe26BSWFz5mau+UYztw/z40uENyVNJde/mLZ ndI2ny18z3DP3F8qy4G4kUJXCmaK1f4O3ybvym4XezPkrm6gcVtW+h5YV fD5AF4wwPv8xY4nyjsJFpooT0ySlNrT2vRpchUpoWNka/x+6jTrAbqBoX QWXuWUwCnHeEPe9YhNtZttVgZ4qzyjwoOFyaeo3jlKe1mh6ScP5NhyXkl Q==; X-IronPort-AV: E=Sophos;i="5.78,420,1599512400"; d="scan'208";a="5972727" Received: from srvexch00.gis.lan ([192.168.1.20]) by post5.gaz-is.ru with ESMTP; 15 Dec 2020 13:27:53 +0300 Received: from SRVEXCH00.gis.lan (192.168.1.16) by SRVEXCH00.gis.lan (192.168.1.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Tue, 15 Dec 2020 13:27:53 +0300 Received: from SRVEXCH00.gis.lan ([192.168.1.20]) by SRVEXCH00.gis.lan ([192.168.1.20]) with mapi id 15.01.2106.002; Tue, 15 Dec 2020 13:27:53 +0300 From: =?koi8-r?B?9MHSwdPP1yDnxc/Sx8nKIPfJ1MHM2MXXyd4=?= To: Stephen Frost CC: Jatoba , "pgsql-bugs@lists.postgresql.org" Subject: RE: BUG #16773: GSSAPI + Msys2/mingw64 + setenv() issue. Thread-Topic: BUG #16773: GSSAPI + Msys2/mingw64 + setenv() issue. Thread-Index: AQHW0jmZq2MqN8rA6Ea2IOwHLb9fZan2yq8AgAEffqA= Date: Tue, 15 Dec 2020 10:27:53 +0000 Message-ID: References: <16773-c0bb1bc300bde127@postgresql.org> <20201214193835.GG16415@tamriel.snowman.net> In-Reply-To: <20201214193835.GG16415@tamriel.snowman.net> Accept-Language: ru-RU, en-US Content-Language: ru-RU X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.129.35] Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Stephen, Yes, I will definitely try proposed patch. It seems obvious and in a current PG-code-style. I mean it's the same as pu= tenv()/unsetenv(). But there is some misunderstanding why it is needed to have two functions p= utenv() and setenv() doing slightly same things?? It's a question to oneself rather, not needed to discuss here.=20 Probably exist some memory issues as noted in neighebour GSSAPI threads and= threads referenced above. So. I think I can reproduce build environment and test all variants (patch/pute= nv + mingw64/msvc), but it's a work not for the one day. I am starting digging and also will track this thread and publish my result= s later. Making buildfarm agent is not possible at the moment due to the testing sta= tus of this work. But it may be possible to setup one in our infrastructure in the future if = test results will be considered as acceptable. Thank you for your reply! Regards George Tarasov -----Original Message----- From: Stephen Frost [mailto:sfrost@snowman.net]=20 Sent: Monday, December 14, 2020 10:39 PM To: Jatoba ; pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16773: GSSAPI + Msys2/mingw64 + setenv() issue. Greetings, * PG Bug reporting form (noreply@postgresql.org) wrote: > I am being engaged in PostgreSQL build process with GSSAPI support in > msys2/mingw64 environment. > Everything is good enough on REL_11_STABLE branch, but there are the=20 > following compilation and linking errors on newer versions/branches=20 > (12-stable, 13-stable, and 14-devel). >=20 > Errors connect with setenv() call that isn't supported in msys2/mingw64. Yeah, we had some discussion regarding that, as you noted. There's been a = further discussion though, here: https://postgr.es/m/CA+OCxowDNTXfHBruAryhZA0aMxHvqHL4uYk8APiZCqjWAM=3DM-w@m= ail.gmail.com Which seems to indicate that fixing the setenv() issue isn't enough to make= things actually work. I'd been hoping that Dave would get back to that th= read and provide some feedback on it, but that's not happened yet. Perhaps you could take his patch and see if it works for you though..? > Is there a plan to clean code from setenv() call and will the proposed=20 > patch [3] or its revised versions be applied ?? Would really be helpful if we could have some confidence that such a change= would actually result in things working- so, if you could test the patch t= hat Dave posted in the thread I linked to above and let us know if it works= for you, that'd certainly be helpful. > Also I have checked BuildFarm statuses and all mingw64-nodes build PG=20 > without GSSAPI/KRB5 support [4]. > It looks like the mingw64 platform is no longer being considered as=20 > LTS and will be in reduced feature list in the future. I don't think there's any reason to jump to that assumption, however.. > Am i right? .. if you'd like this to keep working then I would certainly encourage you = to set up a buildfarm animal which tests this case and register it with the= buildfarm. The lack of one certainly means it's less likely that this spe= cific platform + configuration will be tested regularly. Thanks, Stephen