Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xJivy-00000000O7o-3MZc for pgsql-bugs@arkaria.postgresql.org; Thu, 22 Oct 2026 02:53:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xJivw-000000083MR-3GZA for pgsql-bugs@arkaria.postgresql.org; Thu, 22 Oct 2026 02:53:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xJivw-000000083MJ-1xfD for pgsql-bugs@lists.postgresql.org; Thu, 22 Oct 2026 02:53:36 +0000 Received: from mail-dy1-x1335.google.com ([2607:f8b0:4864:20::1335]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xJivu-00000000KC3-2Zv5 for pgsql-bugs@lists.postgresql.org; Thu, 22 Oct 2026 02:53:35 +0000 Received: by mail-dy1-x1335.google.com with SMTP id 5a478bee46e88-353804b591eso2550423eec.0 for ; Wed, 21 Oct 2026 19:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792637613; x=1793242413; darn=lists.postgresql.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DIWEv6hSOEbDXqKxakGHtOJZS5vNpj4lYjpXZL8vK3o=; b=OJnQDDqN/g2u9K8EZJGId/C1FkiDqG8VJzWQFzl54kLcfAc2WaaT4Wyp++xMrsbjeN xKHcBD7nPmYAxF/K9ifMOc7MaSTt7DLqrSOhGwn/LZq9/sCMme20o5QKxU5jfaSHCFZt EBFtJnRFwNT/wl2CF5X9MMfl2T0DjiLaZkVmKnUrY11aY+kwhMEL3i2C9hN5cInkwd35 nCwUgRjjGU9QZihBp5F/Ltz1Sy3/xu9odZ8oqXUNzfjjXrQwi9qvzfl0UJd+cWCB/xRV ODOX1Oco5jMd1m+H2ckMkS3Yj3noqpV4BN2grmsBS+xFXPEovEeryQk3KfK7UdEsC1RC lPDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792637613; x=1793242413; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DIWEv6hSOEbDXqKxakGHtOJZS5vNpj4lYjpXZL8vK3o=; b=YUH5wAKSEylI8jOvA0Q3bLhOhVgP9xZV8Xlz5AO/s21IjQOwPqoZBsloUsp7TQiNNz Ik2FWRCWbqxAxVVW0feuNmMXPq9GJlSBk+DObiodMbtwOFE6wATRT1gR4RyciazF8fA/ Akt97zEwsKWe3qz9HbOjGC+s1s967tvnZmCDmagiCt5HMqolb8dMT0YtXU/xNdfnz8dl 66Zjq0rExLxBFwEgecfydxSsq8g2tnKyiY+f18EBu1y/0PP79WMH3erNhGUBkgBONo9z +XWbW7gf/5vCsgbz8NLvx50jCmWe8z7ideQ2OhYi+AuHfsabstfdNDk3fAyrWp7ElmSz x3Tw== X-Forwarded-Encrypted: i=1; AKwUvBxFpcKcXEWqvF6u8105zHL3x8faZmwz4+klgx4n6yhXMrAatS/hPLXzZV9U4M7hmaOZwT7uajDNcFQ7@lists.postgresql.org X-Gm-Message-State: AFq9FYJwlcFHbydqgkGFQPqEB7KCOq27fpnzpibRlJuVXkg/Tk7Bq6FV HF/jVvdRF+TmHYFx+e0jnvc5JMhkW/QKBGmpDazrNeKzD9zFI7rIUW7B X-Gm-Gg: AYBFou2jPQx88/cc3/IRuvvimERTb3GeH1rBKLVE37+0npJgUNGS4FrsxPQA6IK3ja1 Q5nck/oV6M37roH4BWex8O4VaAwBc+WXLLbGOauQfg0MoA6R73GmeL4ncH+8ELxUgSVW7fE4car 9Fu0CEOjWXz2nnp2A3du9b3dUpNUynbYPrUgFxorjKOEwLWD8vsKFIo9IQVHqAYSLgBZSFPoDvE lzpTS6yklMQC5SMEa6Jc8Kk7CbrpEzUleB4+UGIXei5UOBYNgBLB0mINS59l+q7f9XShKUV+D5+ NUJ2VHEEySuVwqucCWrNJORNEoY92tFOUArCrUBN3uupZZQrGk+YtZMYsuBLLlExQUky7wPRjd5 jmfSexjyQ0n/iqPaA/X2J1ft7dhbHawN6Y1NVmus9pWZEsO2EfUWNlm2X51C3Ap9M+LL8vplnay DwVgVwGvhzsV5729UNsWLDQya8ds9aW09Sh7y5p3uVWuYo14x7IpgzJnP3sqmjq30LuR/PyOSch UhalYvQ/FYjAtSTMXbNHfG9ZhwerreRQ+yoz7V86NOOfdnSimhXqei/nwWz6WnJeK7PuAGjuvR5 tCac5rovWIqIx9e8mWd186iDhhBVaCegj4SBng== X-Received: by 2002:a05:7301:4390:b0:366:4c26:2968 with SMTP id 5a478bee46e88-3674db4d01cmr5412565eec.26.1792637612969; Wed, 21 Oct 2026 19:53:32 -0700 (PDT) Received: from [192.168.1.19] (58-190-153-33f1.hyg1.eonet.ne.jp. [58.190.153.33]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36740cc8439sm12389946eec.11.2026.10.21.19.53.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Oct 2026 19:53:32 -0700 (PDT) Message-ID: Date: Thu, 22 Oct 2026 11:53:29 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction To: Michael Paquier , Zhijie Hou Cc: shihao zhong , Ayush Tiwari , alpkeles99@gmail.com, pgsql-bugs@lists.postgresql.org References: <5fff280b-96c4-497f-bbfc-0af95b9844b3@gmail.com> <949ad7b3-2b0e-40dc-b6ac-e84da432149b@gmail.com> Content-Language: en-US From: Takeshi Ideriha In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi > > What I am really wondering is why do we actually need to fix *two* > problems at once? The first SetHintBits() looks like a no-brainer to > me, and links to the second permutation in the test "s1_plain > s1_count" where we do a CLUSTER after an UPDATE rollbacked to a > previous savepoint. I don't think that there is a need for an > isolation test on this one, either, wouldn't a plain SQL sequence be > sufficient? > > So the first step to me would be a "Divide and Conquer" strategy, > where we should look at each problem independently instead of trying > to do too much at once. Thank you for sorting the issue out and setting the direction. I was thinking of leaving first SetHintBits() in HeapTupleSatisfiesVacuumHorizon() and moving the second SetHintBits() to heapam_relation_copy_for_cluster() to solve the performance issue. However, it would still be another API violation, wouldn't it? We also needs to figure out the multixact race issue. I'm trying to look into multixact part as much as possible. Regards, Takeshi Ideriha