Content-Type: multipart/alternative;
 boundary="------------v8EB5j4JXfzYuPVS5MUJmAm6"
Message-ID: <a37a3cea-5bd8-4385-a1d4-bb89394c079c@gmail.com>
Date: Wed, 30 Sep 2026 21:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Postmaster crashes on SIGHUP when oauth_validator_libraries holds
 only whitespace
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>,
 Jurij Grigorev <ju.grigorev@ftdata.ru>, pgsql-bugs@lists.postgresql.org
References: <0AED2C72-15A8-4ABC-90D2-88BE46BA1B6E@yesql.se>
 <49829846-44AA-4811-BC54-B5734B200655@yesql.se>
Content-Language: en-US
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <49829846-44AA-4811-BC54-B5734B200655@yesql.se>
Archived-At: 
 <https://www.postgresql.org/message-id/a37a3cea-5bd8-4385-a1d4-bb89394c079c%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------v8EB5j4JXfzYuPVS5MUJmAm6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hello Daniel,

18.09.2026 01:24, Daniel Gustafsson wrote:
> Pushed with tiny bits of tweaking and with a backpatch down to 18. Thanks!
>
> ./daniel

The test addition coined with bca67e5a3 is not very robust,
unfortunately. Buildfarm animal serinus found a way to break it [1]
as below:
#   Failed test 'oauth_validator_libraries restored'
#   at /home/bf/bf-build/serinus/HEAD/pgsql/src/test/modules/oauth_validator/t/001_server.pl line 152.
#          got: '   '
#     expected: 'validator'
# Looks like you failed 1 test of 171.

I've managed to reproduce this locally with a sleep:
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -569,6 +569,7 @@ ProcessConfigFileInternal(GucContext context, bool applySettings, int elevel)
item->name, item->value)));
                         }
                         item->applied = true;
+pg_usleep(100000);
                 }
                 else if (scres == 0)
                 {

It makes oauth_validator/001_server fail deterministically for me.

Could you take a look, please?

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=serinus&dt=2026-09-29%2013%3A57%3A41

Best regards,
Alexander
--------------v8EB5j4JXfzYuPVS5MUJmAm6
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Hello Daniel,<br>
      <br>
      18.09.2026 01:24, Daniel Gustafsson wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:49829846-44AA-4811-BC54-B5734B200655@yesql.se">
      <pre wrap="" class="moz-quote-pre">Pushed with tiny bits of tweaking and with a backpatch down to 18. Thanks!

./daniel
</pre>
    </blockquote>
    <br>
    The test addition coined with bca67e5a3 is not very robust,<br>
    unfortunately. Buildfarm animal serinus found a way to break it [1]<br>
    as below:<br>
    #   Failed test 'oauth_validator_libraries restored'<br>
    #   at
/home/bf/bf-build/serinus/HEAD/pgsql/src/test/modules/oauth_validator/t/001_server.pl
    line 152.<br>
    #          got: '   '<br>
    #     expected: 'validator'<br>
    # Looks like you failed 1 test of 171.<br>
    <br>
    I've managed to reproduce this locally with a sleep:<br>
    --- a/src/backend/utils/misc/guc.c<br>
    +++ b/src/backend/utils/misc/guc.c<br>
    @@ -569,6 +569,7 @@ ProcessConfigFileInternal(GucContext context,
    bool applySettings, int elevel)<br>
                                                                       
    item-&gt;name, item-&gt;value)));<br>
                            }<br>
                            item-&gt;applied = true;<br>
    +pg_usleep(100000);<br>
                    }<br>
                    else if (scres == 0)<br>
                    {<br>
    <br>
    It makes oauth_validator/001_server fail deterministically for me.<br>
    <br>
    Could you take a look, please?<br>
    <br>
    [1]
<a class="moz-txt-link-freetext" href="https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=serinus&amp;dt=2026-09-29%2013%3A57%3A41">https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=serinus&amp;dt=2026-09-29%2013%3A57%3A41</a><br>
    <br>
    Best regards,<br>
    Alexander<br>
  </body>
</html>

--------------v8EB5j4JXfzYuPVS5MUJmAm6--