From: Floris Van Nee <florisvannee@Optiver.com>
To: Michael Paquier <michael@paquier.xyz>
CC: Andres Freund <andres@anarazel.de>,
        Kyotaro Horiguchi
	<horikyota.ntt@gmail.com>,
        "exclusion@gmail.com" <exclusion@gmail.com>,
        "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Thread-Topic: [External] Re: BUG #17947: Combination of replslots pgstat
 issues causes error/assertion failure [External]
Thread-Index: AQHZlBmhKd6ff+auW0KpzehwxH4Xw7GK7OSAgCxGHICAAgJ4gIACBjBQ
Date: Wed, 5 Jun 2024 10:24:43 +0000
Message-ID: <a3de68e3a48c4a55a3f6f64d87486ffd@Optiver.com>
References: <17947-b9554521ad963c9c@postgresql.org>
 <20230601.084245.1524588196504400333.horikyota.ntt@gmail.com>
 <20240505183741.5tefii3razzefvtc@awork3.anarazel.de>
 <dd4c68beba5c40c5a7946569d450ec59@Optiver.com> <Zl6lQ_K0-QOfqUS4@paquier.xyz>
In-Reply-To: <Zl6lQ_K0-QOfqUS4@paquier.xyz>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: RE: BUG #17947: Combination of replslots pgstat issues causes
 error/assertion failure
Archived-At: 
 <https://www.postgresql.org/message-id/a3de68e3a48c4a55a3f6f64d87486ffd%40Optiver.com>
Precedence: bulk

>=20
> Note an extra edge case in pgstat_init_function_usage(), which should do
> the same, I guess?
>=20

I noticed it but wasn't sure if it was necessary here due to the exceptiona=
l case here.
It raises ereport error right after and can only reach this if the entry wa=
s created
In the call to pgstat_prep_pending_entry before it, so it seems unlikely an=
other
backend holds a ref to it. I might be wrong though.

> Attached is an updated patch with refined comments at the top of ?
> pgstat_drop_entry(), to be applied to 15~.

Thanks for testing the patch. Updated patch looks good to me.

-Floris