Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1psgR7-0004D4-Jl for pgsql-bugs@arkaria.postgresql.org; Sat, 29 Apr 2023 09:00:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1psgR5-0002cA-LQ for pgsql-bugs@arkaria.postgresql.org; Sat, 29 Apr 2023 09:00:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1psgR5-0002c0-Ah for pgsql-bugs@lists.postgresql.org; Sat, 29 Apr 2023 09:00:07 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1psgR2-005kBd-CN for pgsql-bugs@lists.postgresql.org; Sat, 29 Apr 2023 09:00:06 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4effb818c37so866871e87.3 for ; Sat, 29 Apr 2023 02:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682758803; x=1685350803; h=in-reply-to:references:cc:to:from:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=fibIrygO2H8Lpp7N9u3HgQM72mwfm1WJk2okVE6dIDM=; b=NfO9TGS51WG8lYlgwFq8pjCSXW8HMhRb8fMqw60B7w3R1fWsYOUUHWo4I5QV7oaiag /9Fzn5PXycXSnO5ygNq85RV8fPk672leKvfIWpdFAtByKPMkdscz9QKc+St47wU97rUX rIiZa5Qf7TvCNCPnUhckncSw9NHLPlYNcA8u5SjfaWmdEKRZQNgUrWaH9fU5bGbSbBuc 3zfFGvsvuqiOzFPnazrnh20UUi7qJhEoI2w6C0vaXDBGYcSIHdv3DmeGs9G93jFBAptL VEx0gSY4OmA9x8Xy62F0BAGKko2F0nP6xYqGQdyWbiwVyzvbumjTYQKU6G8+6t7LiWJE Tz7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682758803; x=1685350803; h=in-reply-to:references:cc:to:from:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fibIrygO2H8Lpp7N9u3HgQM72mwfm1WJk2okVE6dIDM=; b=OXAWptPKNHfoHWDLYZzwWXKoMZgZwtgeTUdH1Zp3uaT2IIwqohR/LCf/cQBHBjXoZO rWNwqGvDHfpzNjSh7ZBmLLzvqWMOx5LHTPd7vef814CkucV6JM1TFc9S8habEX0ybsH+ JVmFJLSAr07UzztFnybldh4+5byVk4PVNlGWkcPOkeTBCfvDFWxrsxbB9YOvMg5FAtm9 dvar9F8VBmPB6qr5M1EBUNXXvuzrj+9oSzjxIL0NexV4ALI+fegRL9rs1ySSYqc6anYe pOYxanpI1nsCoMcfqgK04t/oo7LlFHNorGChDVVEIbFEeNUND5fuKGpouqwKXlV/UHQA 3Vhg== X-Gm-Message-State: AC+VfDyiecwf+XaC4GFhdV1qgHM4NVmiF+yBHYE4PtYbVQEo7syR43vh VKMBsWoi38pUQ+ErqFcfAEw= X-Google-Smtp-Source: ACHHUZ6KMA99S4+i2Vmzu/vXW6MlWanvHAOZ08hsbFToX2r6K9hL6E/yZUR7XbGtbdWsO1/i0rba+Q== X-Received: by 2002:ac2:5d6c:0:b0:4ea:f8f0:545f with SMTP id h12-20020ac25d6c000000b004eaf8f0545fmr2455651lft.52.1682758802584; Sat, 29 Apr 2023 02:00:02 -0700 (PDT) Received: from [1.0.0.7] ([178.155.28.115]) by smtp.gmail.com with ESMTPSA id z2-20020ac25de2000000b004ec89c94f04sm3674083lfq.155.2023.04.29.02.00.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Apr 2023 02:00:01 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------oMz6883FBsZcwDuEeiVazon3" Message-ID: Date: Sat, 29 Apr 2023 12:00:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: BUG #17798: Incorrect memory access occurs when using BEFORE ROW UPDATE trigger Content-Language: en-US From: Alexander Lakhin To: Tom Lane Cc: pgsql-bugs@lists.postgresql.org, Richard Guo References: <17798-0907404928dcf0dd@postgresql.org> <87fe6c28-80b2-f709-a8db-d105e5240e39@gmail.com> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------oMz6883FBsZcwDuEeiVazon3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello Tom, 20.04.2023 13:00, Alexander Lakhin wrote: > > 19.04.2023 11:29, Richard Guo wrote: >> I have a second look at this issue and now I think the fix in v1 patch >> is correct.  I think the comment needs to be updated for this change, >> maybe something like >> > > I've updated the comment based on your suggestion. Please look at the patch > attached. > Could you please confirm the issue, Richard's and my conclusions, and the correctness of the patch, in light of the upcoming May releases? Maybe I'm wrong, but I think that this bug can lead to data corruption in databases where BRU triggers are used. If the defect is real, but the patch proposed is not good enough, I would register it on the commitfest to continue working on it. Best regards, Alexander --------------oMz6883FBsZcwDuEeiVazon3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
Hello Tom,

20.04.2023 13:00, Alexander Lakhin wrote:

19.04.2023 11:29, Richard Guo wrote:
I have a second look at this issue and now I think the fix in v1 patch
is correct.  I think the comment needs to be updated for this change,
maybe something like


I've updated the comment based on your suggestion. Please look at the patch
attached.


Could you please confirm the issue, Richard's and my conclusions, and the
correctness of the patch, in light of the upcoming May releases?
Maybe I'm wrong, but I think that this bug can lead to data corruption in
databases where BRU triggers are used.

If the defect is real, but the patch proposed is not good enough, I would
register it on the commitfest to continue working on it.

Best regards,
Alexander
--------------oMz6883FBsZcwDuEeiVazon3--