Content-Type: multipart/mixed; boundary="------------exRUXIdLuX0odVz30LiSIGBu"
Message-ID: <a5559c95-52c3-5eea-cd63-9b4f1c70ff96@gmail.com>
Date: Fri, 23 Dec 2022 16:54:56 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Content-Language: en-US
In-Reply-To: <20220805131731.jhtscj2tonbglxz6@alvherre.pgsql>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: =?UTF-8?B?546L5rW35rSL?= <wanghaiyang.001@bytedance.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-bugs@lists.postgresql.org
From: Karina Litskevich <litskevichkarina@gmail.com>
Subject: [PATCH] BUG FIX: inconsistent page found in BRIN_REGULAR_PAGE
Archived-At: 
 <https://www.postgresql.org/message-id/a5559c95-52c3-5eea-cd63-9b4f1c70ff96%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------exRUXIdLuX0odVz30LiSIGBu
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Alvaro!

Is there any special reason to read WAL records until the last inserted 
record?

+my $end_lsn = $whiskey->lsn('insert');
+
+my ($ret, $out, $err) = $whiskey->psql(
+    'postgres', qq{
+    select count(*) from pg_get_wal_records_info('$start_lsn', '$end_lsn')
+    where resource_manager = 'BRIN' AND
+    record_type ILIKE '%revmap%'
+    });
+cmp_ok($out, '>=', 1);

It seems that in some rare situations on slower machines this test can 
fail. If
any background process inserts a WAL record before lsn('insert') and 
this record
isn't flushed before pg_get_wal_records_info('$start_lsn', '$end_lsn'),
pg_get_wal_records_info('$start_lsn', '$end_lsn') ends with ERROR 
"cannot accept
future end LSN" as it works only if record with end LSN is inserted.

I attached two patches with two ways of fixing this minor issue.

Best regards,
Karina Litskevich
Postgres Professional: http://postgrespro.com/

--------------exRUXIdLuX0odVz30LiSIGBu
Content-Type: text/x-patch; charset=UTF-8;
 name="v1-0001-prevent-test-from-failing-on-slower-machines.patch"
Content-Disposition: attachment;
 filename*0="v1-0001-prevent-test-from-failing-on-slower-machines.patch"
Content-Transfer-Encoding: base64

RnJvbSA3NWE1NmU3YmQ1YmM3MTg0ODEwOTliZGEzNjY4ODU1ZjljMjAwZTk4IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLYXJpbmEgTGl0c2tldmljaCA8bGl0c2tldmljaGth
cmluYUBnbWFpbC5jb20+CkRhdGU6IEZyaSwgMjMgRGVjIDIwMjIgMTY6MzU6MjMgKzAzMDAK
U3ViamVjdDogW1BBVENIIHYxXSBwcmV2ZW50IHRlc3QgZnJvbSBmYWlsaW5nIG9uIHNsb3dl
ciBtYWNoaW5lcwoKLS0tCiBzcmMvdGVzdC9tb2R1bGVzL2JyaW4vdC8wMl93YWxfY29uc2lz
dGVuY3kucGwgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVs
ZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9tb2R1bGVzL2JyaW4vdC8wMl93YWxf
Y29uc2lzdGVuY3kucGwgYi9zcmMvdGVzdC9tb2R1bGVzL2JyaW4vdC8wMl93YWxfY29uc2lz
dGVuY3kucGwKaW5kZXggZjdkYmIwZDAxNC4uY2JjMjY5YjFkZiAxMDA2NDQKLS0tIGEvc3Jj
L3Rlc3QvbW9kdWxlcy9icmluL3QvMDJfd2FsX2NvbnNpc3RlbmN5LnBsCisrKyBiL3NyYy90
ZXN0L21vZHVsZXMvYnJpbi90LzAyX3dhbF9jb25zaXN0ZW5jeS5wbApAQCAtNjAsNyArNjAs
NyBAQCBiZWdpbgogZW5kCiAkJDsKIH0pOwotbXkgJGVuZF9sc24gPSAkd2hpc2tleS0+bHNu
KCdpbnNlcnQnKTsKK215ICRlbmRfbHNuID0gJHdoaXNrZXktPmxzbignZmx1c2gnKTsKIAog
bXkgKCRyZXQsICRvdXQsICRlcnIpID0gJHdoaXNrZXktPnBzcWwoCiAJJ3Bvc3RncmVzJywg
cXF7Ci0tIAoyLjI1LjEKCg==
--------------exRUXIdLuX0odVz30LiSIGBu
Content-Type: text/x-patch; charset=UTF-8;
 name="v2-0001-prevent-test-from-failing-on-slower-machines.patch"
Content-Disposition: attachment;
 filename*0="v2-0001-prevent-test-from-failing-on-slower-machines.patch"
Content-Transfer-Encoding: base64

RnJvbSBlNGFmZjIxMGM5NWVkNTQ4ZjRjNTRmOTMxNGM0YjU4NTgwNjYzYTc0IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLYXJpbmEgTGl0c2tldmljaCA8bGl0c2tldmljaGth
cmluYUBnbWFpbC5jb20+CkRhdGU6IEZyaSwgMjMgRGVjIDIwMjIgMTY6NDE6NDggKzAzMDAK
U3ViamVjdDogW1BBVENIIHYyXSBwcmV2ZW50IHRlc3QgZnJvbSBmYWlsaW5nIG9uIHNsb3dl
ciBtYWNoaW5lcwoKLS0tCiBzcmMvdGVzdC9tb2R1bGVzL2JyaW4vdC8wMl93YWxfY29uc2lz
dGVuY3kucGwgfCAzICstLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyIGRl
bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L21vZHVsZXMvYnJpbi90LzAyX3dh
bF9jb25zaXN0ZW5jeS5wbCBiL3NyYy90ZXN0L21vZHVsZXMvYnJpbi90LzAyX3dhbF9jb25z
aXN0ZW5jeS5wbAppbmRleCBmN2RiYjBkMDE0Li5hN2FlYWRmNGJiIDEwMDY0NAotLS0gYS9z
cmMvdGVzdC9tb2R1bGVzL2JyaW4vdC8wMl93YWxfY29uc2lzdGVuY3kucGwKKysrIGIvc3Jj
L3Rlc3QvbW9kdWxlcy9icmluL3QvMDJfd2FsX2NvbnNpc3RlbmN5LnBsCkBAIC02MCwxMSAr
NjAsMTAgQEAgYmVnaW4KIGVuZAogJCQ7CiB9KTsKLW15ICRlbmRfbHNuID0gJHdoaXNrZXkt
PmxzbignaW5zZXJ0Jyk7CiAKIG15ICgkcmV0LCAkb3V0LCAkZXJyKSA9ICR3aGlza2V5LT5w
c3FsKAogCSdwb3N0Z3JlcycsIHFxewotCXNlbGVjdCBjb3VudCgqKSBmcm9tIHBnX2dldF93
YWxfcmVjb3Jkc19pbmZvKCckc3RhcnRfbHNuJywgJyRlbmRfbHNuJykKKwlzZWxlY3QgY291
bnQoKikgZnJvbSBwZ19nZXRfd2FsX3JlY29yZHNfaW5mb190aWxsX2VuZF9vZl93YWwoJyRz
dGFydF9sc24nKQogCXdoZXJlIHJlc291cmNlX21hbmFnZXIgPSAnQlJJTicgQU5ECiAJcmVj
b3JkX3R5cGUgSUxJS0UgJyVyZXZtYXAlJwogCX0pOwotLSAKMi4yNS4xCgo=

--------------exRUXIdLuX0odVz30LiSIGBu--