Message-ID: <a684b80b-f76b-49bd-ae26-d9842d8eca72@postgrespro.ru>
Date: Thu, 9 Nov 2023 18:21:46 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: BUG #18187: Unexpected error: "variable not found in subplan
 target lists" triggered by JOIN
Content-Language: en-US
To: Richard Guo <guofenglinux@gmail.com>,
 Alexander Korotkov <akorotkov@postgresql.org>
Cc: zuming.jiang@inf.ethz.ch, pgsql-bugs@lists.postgresql.org,
 PG Bug reporting form <noreply@postgresql.org>
References: <18187-831da249cbd2ff8e@postgresql.org>
 <491881ef-f1c7-4a86-b5dd-dcad55a88ab4@postgrespro.ru>
 <CAMbWs4_yrqMYXd+zXc4Y6KjnyA8xPZE6aiAW6k2Y10WaNhwRhw@mail.gmail.com>
 <e7f740cd-fcc8-4022-bb12-bb0f5f736ba6@postgrespro.ru>
 <CAMbWs4_GWUiNVzQDPPj4tm21KG4G13qV4erf9Qu5j-V430f50Q@mail.gmail.com>
From: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Organization: Postgres Professional
In-Reply-To: 
 <CAMbWs4_GWUiNVzQDPPj4tm21KG4G13qV4erf9Qu5j-V430f50Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/a684b80b-f76b-49bd-ae26-d9842d8eca72%40postgrespro.ru>
Precedence: bulk

On 9/11/2023 18:08, Richard Guo wrote:
> 
> On Thu, Nov 9, 2023 at 12:51 PM Andrei Lepikhov 
> <a.lepikhov@postgrespro.ru <mailto:a.lepikhov@postgrespro.ru>> wrote:
> 
>     ... Should we add a reference to the
>     bug that triggered the issue as a comment to the test?
> 
> 
> Yeah, we can do that.  I guess something like:
> 
> -- Check that SJE removes references from PHVs correctly (bug #18187)
> 
>     Also, to be sure,
>     maybe add column t4.code into the list of the coalesce parameters?
> 
> 
> I don't think it's necessary.  It is t3 that SJE would remove, so it's
> sufficient to have t3's Vars in the PHV expression to trigger this
> error.

Agree. I've considered the situations when something in the internal 
planner logic changes, and relations could arrive in a different order. 
In that case, we sort relids, and have determined behaviour. So, do we 
wait for Alexander's glance?

-- 
regards,
Andrei Lepikhov
Postgres Professional