Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWaG5-0002o4-HY for pgsql-bugs@arkaria.postgresql.org; Thu, 07 May 2020 06:43:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jWaG4-0004X6-D3 for pgsql-bugs@arkaria.postgresql.org; Thu, 07 May 2020 06:43:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWaG4-0004Ww-70; Thu, 07 May 2020 06:43:48 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWaG1-000344-EB; Thu, 07 May 2020 06:43:47 +0000 Received: from hnk.local (p2358024-ipbf2221funabasi.chiba.ocn.ne.jp [114.177.56.24]) by oss.nttdata.com (Postfix) with ESMTPSA id 2674A6022C; Thu, 7 May 2020 15:43:41 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.2 at oss.nttdata.com Subject: Re: Back-patch is necessary? Re: Don't try fetching future segment of a TLI. To: Amit Kapila Cc: David Steele , Kyotaro Horiguchi , psuderevsky@gmail.com, PostgreSQL Hackers , PostgreSQL mailing lists References: <792ea085-95c4-bca0-ae82-47fdc80e146d@oss.nttdata.com> <762ffb60-df9c-0efc-2714-9859219157e3@pgmasters.net> <3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com> <20200407.164801.1830442317313243264.horikyota.ntt@gmail.com> <4a461c7b-b90a-6644-64a6-80eac69c27bc@pgmasters.net> <21d2590f-2739-9f45-748f-7a68d667d7cd@oss.nttdata.com> From: Fujii Masao Message-ID: Date: Thu, 7 May 2020 15:43:40 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020/05/02 20:40, Amit Kapila wrote: > On Thu, Apr 30, 2020 at 7:46 PM Fujii Masao wrote: >> >> On 2020/04/08 1:49, Fujii Masao wrote: >>> >>> >>> On 2020/04/07 20:21, David Steele wrote: >>>> >>>> On 4/7/20 3:48 AM, Kyotaro Horiguchi wrote: >>>>> At Tue, 7 Apr 2020 12:15:00 +0900, Fujii Masao wrote in >>>>>>>> This doesn't seem a bug, so I'm thinking to merge this to next *major* >>>>>>>> version release, i.e., v13. >>>>>>> Not a bug, perhaps, but I think we do consider back-patching >>>>>>> performance problems. The rise in S3 usage has just exposed how poorly >>>>>>> this performed code in high-latency environments. >>>>>> >>>>>> I understood the situation and am fine to back-patch that. But I'm not >>>>>> sure >>>>>> if it's fair to do that. Maybe we need to hear more opinions about >>>>>> this? >>>>>> OTOH, feature freeze for v13 is today, so what about committing the >>>>>> patch >>>>>> in v13 at first, and then doing the back-patch after hearing opinions >>>>>> and >>>>>> receiving many +1? >>>>> >>>>> +1 for commit only v13 today, then back-patch if people wants and/or >>>>> accepts. >> >> Please let me revisit this. Currently Grigory Smolkin, David Steele, >> Michael Paquier and Pavel Suderevsky agree to the back-patch and >> there has been no objection to that. So we should do the back-patch? >> Or does anyone object to that? >> >> I don't think that this is a feature bug because archive recovery works >> fine from a functional perspective without this commit. OTOH, >> I understand that, without the commit, there is complaint about that >> archive recovery may be slow unnecessarily when archival storage is >> located in remote, e.g., Amazon S3 and it takes a long time to fetch >> the non-existent archive WAL file. So I'm ok to the back-patch unless >> there is no strong objection to that. >> > > I don't see any obvious problem with the changed code but we normally > don't backpatch performance improvements. I can see that the code > change here appears to be straight forward so it might be fine to > backpatch this. Have we seen similar reports earlier as well? AFAIK, > this functionality is for a long time and if people were facing this > on a regular basis then we would have seen such reports multiple > times. I mean to say if the chances of this hitting are less then we > can even choose not to backpatch this. I found the following two reports. ISTM there are not so many reports... https://www.postgresql.org/message-id/16159-f5a34a3a04dc67e0@postgresql.org https://www.postgresql.org/message-id/dd6690b0-ec03-6b3c-6fac-c963f91f87a7%40postgrespro.ru Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION