Subject: Re: BUG #16931: source code problem about commit_ts
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: zoulx1982@163.com, pgsql-bugs@lists.postgresql.org
References: <20210409224241.GA32072@alvherre.pgsql>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <a92a5d4f-4167-22fd-2aa4-3642df5cf978@oss.nttdata.com>
Date: Mon, 12 Apr 2021 00:09:45 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <20210409224241.GA32072@alvherre.pgsql>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/a92a5d4f-4167-22fd-2aa4-3642df5cf978%40oss.nttdata.com>
Precedence: bulk


On 2021/04/10 7:42, Alvaro Herrera wrote:
> On 2021-Mar-24, Fujii Masao wrote:
> 
>> diff --git a/src/backend/access/rmgrdesc/committsdesc.c b/src/backend/access/rmgrdesc/committsdesc.c
>> index 7ebd3d35ef..26bad44b96 100644
>> --- a/src/backend/access/rmgrdesc/committsdesc.c
>> +++ b/src/backend/access/rmgrdesc/committsdesc.c
>> @@ -38,31 +38,6 @@ commit_ts_desc(StringInfo buf, XLogReaderState *record)
>>   		appendStringInfo(buf, "pageno %d, oldestXid %u",
>>   						 trunc->pageno, trunc->oldestXid);
>>   	}
>> -	else if (info == COMMIT_TS_SETTS)
> 
> You have not pushed this one, right?  I think we should do it now.

Thanks for the ping! Pushed!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION