Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lxaXS-0007L1-Hi for pgsql-bugs@arkaria.postgresql.org; Sun, 27 Jun 2021 19:33:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lxaXQ-0001IO-OL for pgsql-bugs@arkaria.postgresql.org; Sun, 27 Jun 2021 19:33:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lxaXQ-0001IF-Fk for pgsql-bugs@lists.postgresql.org; Sun, 27 Jun 2021 19:33:52 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lxaXN-0004Nb-QF for pgsql-bugs@lists.postgresql.org; Sun, 27 Jun 2021 19:33:51 +0000 Received: from Andreys-MacBook-Pro.local (unknown [176.114.32.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id B474C21C880D; Sun, 27 Jun 2021 22:33:47 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1624822428; bh=nsUBr5SvcMHgbovqNtLkgeJ45uOHxsOsSx4In4785Sw=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=aEHQVh3cRb1mUyE6yG4cVnHae3UKcXNi8U0TJPyYBOMv6n1edm8zKeh90vtWRV6Ud hEtqlqOtLZcJcohNiLATZ2HSiIgxh3akd8jjGB1q9++vDIKQX4FWGbzGsCSnGeQd89 ByLCFWSZkhAnlPk8gHeY53dSCT9rVUiboNGzWOtI= Subject: Re: Assertion on create index concurrently To: Tom Lane , Michael Paquier Cc: pgsql-bugs@lists.postgresql.org References: <9b905019-5297-7372-0ad2-e1a4bb66a719@postgrespro.ru> <9238.1624808236@sss.pgh.pa.us> From: Andrey Lepikhov Organization: Postgres Professional Message-ID: Date: Sun, 27 Jun 2021 22:33:44 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <9238.1624808236@sss.pgh.pa.us> Content-Type: multipart/mixed; boundary="------------FE78BE4BA76950ABCC784C45" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------FE78BE4BA76950ABCC784C45 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 27/6/21 18:37, Tom Lane wrote: > Michael Paquier writes: >> On Sat, Jun 26, 2021 at 09:48:45PM +0300, Andrey Lepikhov wrote: >>> This problem affects PG 9.6 - 13. The master branch was fixed 9 months ago >>> by commit 83158f7, that made this operation transactional, but still. > >> This looks like a good argument for back-patching 83158f7 all the way >> down, as 813fb03 exists since 9.4. Any thoughts from others? > > +1 ... 83158f7 has survived long enough to have reasonable confidence > in it. Technically, 83158f7 is trivial patch. I think, some efforts is required only for PG9.6. I prepared a patch for this version. -- regards, Andrey Lepikhov Postgres Professional --------------FE78BE4BA76950ABCC784C45 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-Back-patch-of-83158f7-for-PG9_6.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Back-patch-of-83158f7-for-PG9_6.patch" RnJvbSAxYmNiNjAxMTlmOGRlNWY2MzE2NWU1ZGU1MTI4OTE1Njc0NzA0MWMyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiQW5kcmV5IFYuIExlcGlraG92IiA8YS5sZXBpa2hv dkBwb3N0Z3Jlc3Byby5ydT4KRGF0ZTogU3VuLCAyNyBKdW4gMjAyMSAyMjoyOTo0MCArMDMw MApTdWJqZWN0OiBbUEFUQ0hdIEJhY2stcGF0Y2ggb2YgODMxNThmNyBmb3IgUEc5XzYKCi0t LQogc3JjL2JhY2tlbmQvY2F0YWxvZy9pbmRleC5jIHwgMjMgKysrKysrKystLS0tLS0tLS0t LS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NhdGFsb2cvaW5kZXguYyBiL3NyYy9iYWNr ZW5kL2NhdGFsb2cvaW5kZXguYwppbmRleCBmMWZlNTI5OTgxLi4zNWM0NGZhMjZhIDEwMDY0 NAotLS0gYS9zcmMvYmFja2VuZC9jYXRhbG9nL2luZGV4LmMKKysrIGIvc3JjL2JhY2tlbmQv Y2F0YWxvZy9pbmRleC5jCkBAIC0zMjgxLDE4ICszMjgxLDEwIEBAIHZhbGlkYXRlX2luZGV4 X2hlYXBzY2FuKFJlbGF0aW9uIGhlYXBSZWxhdGlvbiwKICAqIGluZGV4X3NldF9zdGF0ZV9m bGFncyAtIGFkanVzdCBwZ19pbmRleCBzdGF0ZSBmbGFncwogICoKICAqIFRoaXMgaXMgdXNl ZCBkdXJpbmcgQ1JFQVRFL0RST1AgSU5ERVggQ09OQ1VSUkVOVExZIHRvIGFkanVzdCB0aGUg cGdfaW5kZXgKLSAqIGZsYWdzIHRoYXQgZGVub3RlIHRoZSBpbmRleCdzIHN0YXRlLiAgQmVj YXVzZSB0aGUgdXBkYXRlIGlzIG5vdAotICogdHJhbnNhY3Rpb25hbCBhbmQgd2lsbCBub3Qg cm9sbCBiYWNrIG9uIGVycm9yLCB0aGlzIG11c3Qgb25seSBiZSB1c2VkIGFzCi0gKiB0aGUg bGFzdCBzdGVwIGluIGEgdHJhbnNhY3Rpb24gdGhhdCBoYXMgbm90IG1hZGUgYW55IHRyYW5z YWN0aW9uYWwgY2F0YWxvZwotICogdXBkYXRlcyEKKyAqIGZsYWdzIHRoYXQgZGVub3RlIHRo ZSBpbmRleCdzIHN0YXRlLgogICoKLSAqIE5vdGUgdGhhdCBoZWFwX2lucGxhY2VfdXBkYXRl IGRvZXMgc2VuZCBhIGNhY2hlIGludmFsIG1lc3NhZ2UgZm9yIHRoZQorICogTm90ZSB0aGF0 IENhdGFsb2dUdXBsZVVwZGF0ZSgpIHNlbmRzIGEgY2FjaGUgaW52YWxpZGF0aW9uIG1lc3Nh Z2UgZm9yIHRoZQogICogdHVwbGUsIHNvIG90aGVyIHNlc3Npb25zIHdpbGwgaGVhciBhYm91 dCB0aGUgdXBkYXRlIGFzIHNvb24gYXMgd2UgY29tbWl0LgotICoKLSAqIE5COiBJbiByZWxl YXNlcyBwcmlvciB0byBQb3N0Z3JlU1FMIDkuNCwgdGhlIHVzZSBvZiBhIG5vbi10cmFuc2Fj dGlvbmFsCi0gKiB1cGRhdGUgaGVyZSB3b3VsZCBoYXZlIGJlZW4gdW5zYWZlOyBub3cgdGhh dCBNVkNDIHJ1bGVzIGFwcGx5IGV2ZW4gZm9yCi0gKiBzeXN0ZW0gY2F0YWxvZyBzY2Fucywg d2UgY291bGQgcG90ZW50aWFsbHkgdXNlIGEgdHJhbnNhY3Rpb25hbCB1cGRhdGUgaGVyZQot ICogaW5zdGVhZC4KICAqLwogdm9pZAogaW5kZXhfc2V0X3N0YXRlX2ZsYWdzKE9pZCBpbmRl eElkLCBJbmRleFN0YXRlRmxhZ3NBY3Rpb24gYWN0aW9uKQpAQCAtMzMwMCw5ICszMjkyLDcg QEAgaW5kZXhfc2V0X3N0YXRlX2ZsYWdzKE9pZCBpbmRleElkLCBJbmRleFN0YXRlRmxhZ3NB Y3Rpb24gYWN0aW9uKQogCVJlbGF0aW9uCXBnX2luZGV4OwogCUhlYXBUdXBsZQlpbmRleFR1 cGxlOwogCUZvcm1fcGdfaW5kZXggaW5kZXhGb3JtOwotCi0JLyogQXNzZXJ0IHRoYXQgY3Vy cmVudCB4YWN0IGhhc24ndCBkb25lIGFueSB0cmFuc2FjdGlvbmFsIHVwZGF0ZXMgKi8KLQlB c3NlcnQoR2V0VG9wVHJhbnNhY3Rpb25JZElmQW55KCkgPT0gSW52YWxpZFRyYW5zYWN0aW9u SWQpOworCUNhdGFsb2dJbmRleFN0YXRlIGluZHN0YXRlOwogCiAJLyogT3BlbiBwZ19pbmRl eCBhbmQgZmV0Y2ggYSB3cml0YWJsZSBjb3B5IG9mIHRoZSBpbmRleCdzIHR1cGxlICovCiAJ cGdfaW5kZXggPSBoZWFwX29wZW4oSW5kZXhSZWxhdGlvbklkLCBSb3dFeGNsdXNpdmVMb2Nr KTsKQEAgLTMzNjIsOCArMzM1MiwxMSBAQCBpbmRleF9zZXRfc3RhdGVfZmxhZ3MoT2lkIGlu ZGV4SWQsIEluZGV4U3RhdGVGbGFnc0FjdGlvbiBhY3Rpb24pCiAJCQlicmVhazsKIAl9CiAK LQkvKiAuLi4gYW5kIHdyaXRlIGl0IGJhY2sgaW4tcGxhY2UgKi8KLQloZWFwX2lucGxhY2Vf dXBkYXRlKHBnX2luZGV4LCBpbmRleFR1cGxlKTsKKwkvKiAuLi4gYW5kIHVwZGF0ZSBpdCAq LworCWluZHN0YXRlID0gQ2F0YWxvZ09wZW5JbmRleGVzKHBnX2luZGV4KTsKKwlzaW1wbGVf aGVhcF91cGRhdGUocGdfaW5kZXgsICZpbmRleFR1cGxlLT50X3NlbGYsIGluZGV4VHVwbGUp OworCUNhdGFsb2dJbmRleEluc2VydChpbmRzdGF0ZSwgaW5kZXhUdXBsZSk7CisJQ2F0YWxv Z0Nsb3NlSW5kZXhlcyhpbmRzdGF0ZSk7CiAKIAloZWFwX2Nsb3NlKHBnX2luZGV4LCBSb3dF eGNsdXNpdmVMb2NrKTsKIH0KLS0gCjIuMzEuMQoK --------------FE78BE4BA76950ABCC784C45--