Date: Thu, 15 May 2025 14:12:41 -0400
From: Nathan Bossart <nathandbossart@gmail.com>
To: jian he <jian.universality@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, phb.emaj@free.fr,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18923: pg_dump 18beta1 fails to process complex table names
Message-ID: <aCYumTym-wLvDFp8@nathan>
References: <18923-e79273f87c6bed69@postgresql.org>
 <37115.1747057899@sss.pgh.pa.us>
 <CACJufxFLUsXw2tsTLLvWSeO0cX=Wp+fnL-vKK7eiVu0=GSSnRA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="xHlpTG+cgUMwKgcC"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACJufxFLUsXw2tsTLLvWSeO0cX=Wp+fnL-vKK7eiVu0=GSSnRA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aCYumTym-wLvDFp8%40nathan>
Precedence: bulk


--xHlpTG+cgUMwKgcC
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Tue, May 13, 2025 at 07:34:51PM +0800, jian he wrote:
> On Mon, May 12, 2025 at 9:51 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> PG Bug reporting form <noreply@postgresql.org> writes:
>> > I have just run the E-Maj project regression test suite with PG18 beta1 and
>> > found a pg_dump abort when trying to dump a schema prefixed table having a
>> > complex name including single quote, double quote and space.
>>
>> Thanks for the report!  Looks like fetchAttributeStats() is completely
>> misguided about the appropriate quoting rules for array elements.

D'oh, my bad.

> re-read ReadArrayToken.
> In this context, we need to care about single-quote, double-quotes.
> for backslash, we skip it.
> 
> appendPGArray can help us handle double quotes,
> now we just need to make it also handle single quotes.

I don't think we want to teach appendPGArray() to handle single quotes.
That's meant for building a text representation of a 1-dimensional Postgres
array, which IIUC doesn't need to escape single quotes.  Take the following
example:

	postgres=# select array['nathan''s element'];
	        array
	----------------------
	 {"nathan's element"}
	(1 row)

My first instinct is that we need to build the array with appendPGArray()
and then append it to the query using appendStringLiteralAH(), as done in
the attached patch.

-- 
nathan

--xHlpTG+cgUMwKgcC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v2-0001-pg_dump-fix-quoting-in-fetchAttributeStats.patch