Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 20 May 2025 14:02:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, 707330139@qq.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18929: After the view is created, executed query against
 the view definition, reported syntax error.
Message-ID: <aCwM3RSlrD2mk1mT@paquier.xyz>
References: <18929-077d6b7093b176e2@postgresql.org>
 <349f86e9-6922-4fcc-9725-b8a6f0667bea@iki.fi>
 <c8706ea7-5a32-434b-bdc8-6cf8e2ad46c1@iki.fi>
 <614740.1747715486@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="rjsuLZOpiITBaOLZ"
Content-Disposition: inline
In-Reply-To: <614740.1747715486@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/aCwM3RSlrD2mk1mT%40paquier.xyz>
Precedence: bulk


--rjsuLZOpiITBaOLZ
Content-Type: multipart/mixed; boundary="FXr/l8gi82UAYFBl"
Content-Disposition: inline


--FXr/l8gi82UAYFBl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 20, 2025 at 12:31:26AM -0400, Tom Lane wrote:
> In the no-good-deed-goes-unpunished department: it appears from
> buildfarm reports that we need to do something about output
> mismatches in cross-version-upgrade tests due to this commit.
> I didn't yet look more closely.

Yes, the buildfarm is unhappy.

It seems to me that this needs an update of @_unused_view_qualifiers
in AdjustUpgrade.pm to update public.limit_thousand_v_5's qual, like
in the attached.  This is needed in v16 and newer branches.
--
Michael

--FXr/l8gi82UAYFBl
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="fix-upgrade-test.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm b/src/test/perl=
/PostgreSQL/Test/AdjustUpgrade.pm
index 609275e2c26d..1725fe2f9487 100644
--- a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm
+++ b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm
@@ -538,6 +538,7 @@ my @_unused_view_qualifiers =3D (
 	{ obj =3D> 'VIEW public.limit_thousand_v_2', qual =3D> 'onek' },
 	{ obj =3D> 'VIEW public.limit_thousand_v_3', qual =3D> 'onek' },
 	{ obj =3D> 'VIEW public.limit_thousand_v_4', qual =3D> 'onek' },
+	{ obj =3D> 'VIEW public.limit_thousand_v_5', qual =3D> 'onek' },
 	# Since 14
 	{ obj =3D> 'MATERIALIZED VIEW public.compressmv', qual =3D> 'cmdata1' });
=20

--FXr/l8gi82UAYFBl--

--rjsuLZOpiITBaOLZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmgsDN0ACgkQnvQgOdby
QH0umA//coZ6aWADdB2zz2UWWqPrwIvGpsEqdm3kttb5ByDpVHJ46Y5aqAz90EYY
j+jQeSCo64AAxOY2iSkDDXjGqTg6/88mBZzhR/sawvstjUaM4hAeJdeG2IDnfM1e
rz+l9ba6JE4dnUJz97riM/e/LwhSiXM8RXyY7H01tfGtlXJ9pSpWChA7Nto5+E+1
uBtqlkH2h1wET8m1fmABr8OaHgJzOBJlgqBI2uCqlD9cpBY7p+cDPwjuO5xGB1Mr
C3Hk2/YyEHBss7MoOUijCIShD+JdGNop4+03kxRBonWJmDYtNgu4j9zbH6YE42AH
rVtoGRaZrXYBZaXiEMj2wilfK271bDAfVuf4cIi8/WrwTQO96IH2+Bp/K+P8wWtX
UKhM8935fBmPClpUKrX2stUZK1hxORMVkpQmPKC0cxzWDBJ7sSSWhiyIBIvApasz
YAoB6fyGM+ujd3Y7l78FwqgoKD6DA1Y6os4MfxJOX/kc5X8U5EiuV8EXwib4HUsp
yJfGNtWZvAIiIuRNLADnVFVdnjr83KuMQdg9hV4FUJRh1AaKLsNhaBPZlx43uDav
6KaFw93jjQhRTdfFL77mrXa0PiqdaxyYgBgDeJJ5d0bMdj1WE7Ipn/NzhDlgUhmX
ah8NBantIv9sXubJlA0ZKrK1b8/iU2uz4jHYU7cqO1WlssFsIew=
=uUQ/
-----END PGP SIGNATURE-----

--rjsuLZOpiITBaOLZ--