Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 2 Jun 2025 17:13:48 +0900
From: Michael Paquier <michael@paquier.xyz>
To: n.kalinin@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Cc: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Subject: Re: BUG #18944: Assertion Failure in psql with idle_session_timeout
 Set
Message-ID: <aD1dPMIZzAwMKm7G@paquier.xyz>
References: <18944-8a926c30f68387dd@postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="WvY28HPqSx7eRfC+"
Content-Disposition: inline
In-Reply-To: <18944-8a926c30f68387dd@postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/aD1dPMIZzAwMKm7G%40paquier.xyz>
Precedence: bulk


--WvY28HPqSx7eRfC+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 02, 2025 at 06:34:12AM +0000, PG Bug reporting form wrote:
> Hello! When I execute the following query:
> psql <<EOF
> CREATE TABLE psql_pipeline(a INTEGER PRIMARY KEY, s TEXT);
> \startpipeline
> COPY psql_pipeline FROM STDIN;
> \syncpipeline
> \endpipeline
> EOF
> with `idle_session_timeout` set to, for example, 10000, I get the following
> error:
> FATAL:  terminating connection due to idle-session timeout
> psql: common.c:1501: discardAbortedPipelineResults: Assertion
> `pset.available_results > 0' failed.

Reproduced here, thanks for the report.  In this case, we are in a
PGRES_FATAL_ERROR state due to the timeout triggered by the backend,
and the loop discarding the results in discardAbortedPipelineResults()
does not take into account this case scenario: we don't have a result
to process yet, think that there is one, and kaboom.  It seems to me
that we should just add an extra case for the result = NULL case as
there is nothing pending.  A FATAL means that we need to give up
anyway.

Anthonin, what do you think?
--
Michael

--WvY28HPqSx7eRfC+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmg9XTwACgkQnvQgOdby
QH3dCxAAqmhxQ6+OH3QkYNqsQk8vhZe86FIPv+CWyDdqBfuiUvoADnp3b5HLMhdF
r2SN6hWUaBivkHI4U1c6e4SRlj922HiqyhrvWxSkLZMQhVJNsk7i0y7Cp2kcnz9l
l3dwqEqC2jGOVQdwVTHZXKgFKfd5Bhxi3M5yR8Pssf0FKSuWP5ZPYJXgFDNspNXs
DO7g3BKp8E8DuA6HG9K9VeCmh7J0nG0+lsSZ2CJ5lBXXXaQeViXlm2jCbyxVxJbU
8x4r/IfiE4yFt0uY8jAoM9M8yAg0ZdmMr04FHyRr6ZkVakJZouVc8INhHqKisvPd
JWKCfJrOA4ob5MWmPs1Ppt4eGUSOWYyp+ii5smQ8ElComRXxBFndZ+elQIeHhpjE
OHIqnrfm8wCaEIoO5+9z5E2DYPAPFhUP1G6cwD0FAUvHfb3BwfYyrxextE4Zb2KR
I5WYpCpjVl/vySBk9t1bPKIH8z4BcRhqMuB6hOHEFPXWWH4FwcMo4u+ENqx0GPfk
N+bpDGltY/i9U50VyuOgICOThwkbw0+NRATYvUbU+mh6QO9zHylGfyU/YEr+VZjm
1J4MTadTamZyGua0AXroN6gptMrx9nXHmWr1sHUK5cQkgtmej+LaI/Vs6E6+g+H6
hGVq4r1kU8jz1VcrKu21hyOrXPP2fkLoRA9nTvbNf6YjG1MCKf0=
=hG/j
-----END PGP SIGNATURE-----

--WvY28HPqSx7eRfC+--