Date: Mon, 2 Jun 2025 12:16:59 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Matheus Alcantara <matheusssilv97@gmail.com>
Cc: evsi@amazon.com, pgsql-bugs@lists.postgresql.org, peter@eisentraut.org
Subject: Re: BUG #18920: LOAD '$libdir/plugins' no longer works in 18beta1
Message-ID: <aD3ci7soqldAHtb0@nathan>
References: <18920-b350b1c0a30af006@postgresql.org>
 <CAFY6G8eGLJmdCCLP=MT9k=URegR6oG6Y1doOJXg65Efnzpz9cg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAFY6G8eGLJmdCCLP=MT9k=URegR6oG6Y1doOJXg65Efnzpz9cg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aD3ci7soqldAHtb0%40nathan>
Precedence: bulk

On Mon, Jun 02, 2025 at 11:05:12AM -0300, Matheus Alcantara wrote:
> The problem is how we are sripping the $libdir from module_pathname. I
> think that we should still strip the $libdir from module_pathname when
> expanding from a .control file, but we should not expand via LOAD
> command, since the user may explicitly specify the $libdir prefix as it
> is the case here.
> 
> Having this logic on expand_dynamic_library_name() force us to srip the
> $libdir for all scenarios, so I think that a better place to have this
> is on load_external_function() that is called when executing a SQL
> script from an extension.

Thanks for the patch.  This seems generally reasonable to me.

-- 
nathan