Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 3 Jun 2025 08:31:16 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: n.kalinin@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18944: Assertion Failure in psql with idle_session_timeout
 Set
Message-ID: <aD40RKgfY4L4wnfL@paquier.xyz>
References: <18944-8a926c30f68387dd@postgresql.org>
 <aD1dPMIZzAwMKm7G@paquier.xyz>
 <CAO6_XqrmYG+V8n1ZWvUfrBt3aHExmysRdxaMNQi0sVYjcmW_WQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="WUJlBj6LPVFv+BBZ"
Content-Disposition: inline
In-Reply-To: 
 <CAO6_XqrmYG+V8n1ZWvUfrBt3aHExmysRdxaMNQi0sVYjcmW_WQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aD40RKgfY4L4wnfL%40paquier.xyz>
Precedence: bulk


--WUJlBj6LPVFv+BBZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 02, 2025 at 07:00:26PM +0200, Anthonin Bonnefoy wrote:
> So if that's expected, we may need additional logic to avoid
> increasing piped_syncs when we're after a COPY? On the other hand,
> ignoring the SYNC seems to break the protocol spec expectation that
> "there is one and only one ReadyForQuery sent for each Sync".

Hmm.  This stuff stands as it is in the backend COPY code since
c01641f8aed0 from 2003, so there's not much we can do in the backend
or libpq.  Adding some specific logic in psql to avoid piped_syncs
seems like the correct move seen from here.

Most of that should be close to ExecQueryAndProcessResults(), don't
you think?  That's where we count the number of piped syncs.
--
Michael

--WUJlBj6LPVFv+BBZ
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmg+NEMACgkQnvQgOdby
QH0jcA/8CtfzWXLK54fpHCGGd6b/9zmsp58IytA8sv3YaJpzNZpp+CWNDZ6vfOdX
Ss8SbwiVbKejyRy5hJqJDZDP7dGHrrfH8fD8GXhvAFwhOTTQHclepzChOy2Hlkad
cjR1KlOkCAHfJl3+sDq2CEj+MQB8i/3OCC8jgUi/90g5eT0KzfiAIpMUV0gj5uYJ
bGzSm5vXH9We5x5C/PE8y764PdFXUyS3Rka5ItuqtQsj115veKL+ZeGRKh+3D9ba
1/brZfBfObG82SRT3zYfy7l62nwEmaNR0Z+FreiIFA91tzgSSUwUC0oIJ/IZrtt3
1YD48q5YtIOJhBJitWxRI66EnISlhqZfkN6jA8wGanwO2RS8bxRNqVHjm+nli5x2
IYZz9RSlSyhr3/DioD/8RG9aZFHiZ9EypMbNUo1HQPLxhdv5A0U4xkFlhTUqjkZJ
IlF60/4/xIAI1sJqQ31Ar3mcQjLEh9tC2yrxcRNjTyZTmcSMQ5254rZRipQx+dW/
x6y6d03AQNBUm4M8Rg2boF5vFQfm/6jeVFlKy+mHzwH5V1gMhj+Y/M/Bwq8VMIE+
F3Kxhd6VRX5NwM8PdndDBXeW6drki+FzBPjBqFQBPaEy9DlPwj6k4q5NqppRjra7
DPMyLWBlCKAVPQPjLofJa9bdO+8n4AbCA2K3aK1FuEnco+ke0a4=
=LZ+c
-----END PGP SIGNATURE-----

--WUJlBj6LPVFv+BBZ--