Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 28 May 2025 16:35:58 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alexey Makhmutov <a.makhmutov@postgrespro.ru>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	shveta malik <shveta.malik@gmail.com>,
	Ajin Cherian <itsajin@gmail.com>, pgsql-bugs@lists.postgresql.org
Subject: Re: Standby server with cascade logical replication could not be
 properly stopped under load
Message-ID: <aDa83q7wJt6II3Iq@paquier.xyz>
References: <52138028-7246-421c-9161-4fa108b88070@postgrespro.ru>
 <CAJpy0uA9kw9WLWETPg+upwzBu145vMB7sPZwBuR_vDrbazeuag@mail.gmail.com>
 <d9e1c765-7f83-4015-ade3-16506854d0b1@postgrespro.ru>
 <aC9DXHt/MwFCW6Is@ip-10-97-1-34.eu-west-3.compute.internal>
 <f2575904-acfe-4037-9748-61fdb4a7abe4@postgrespro.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9Ina7Ak1Wo21WnsW"
Content-Disposition: inline
In-Reply-To: <f2575904-acfe-4037-9748-61fdb4a7abe4@postgrespro.ru>
Archived-At: 
 <https://www.postgresql.org/message-id/aDa83q7wJt6II3Iq%40paquier.xyz>
Precedence: bulk


--9Ina7Ak1Wo21WnsW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, May 22, 2025 at 09:22:02PM +0300, Alexey Makhmutov wrote:
> I've tried to update method comment as well in the updated patch:
> 0001-Use-only-replayed-position-as-target-flush-point-3-pg-master.patch.
> The same patch could be applied on top of PG 17 as well.

+	if (MyWalSnd->kind == REPLICATION_KIND_PHYSICAL)
+	{
+		TimeLineID	receiveTLI;
+		XLogRecPtr	receivePtr = GetWalRcvFlushRecPtr(NULL, &receiveTLI);
+
+		if (receiveTLI == replayTLI && receivePtr > result)
+			result = receivePtr;
+	}

Looking at the patch, I am not much a fan of looking at MyWalSnd in
GetStandbyFlushRecPtr() which does not have such a dependency yet, to
then decide if the LSN retrieved by GetWalRcvFlushRecPtr() should be
removed or used.

Wouldn't it be better to extend GetStandbyFlushRecPtr() so as the
caller can directly decide if they want to include in the maths the
last LSN flushed by the WAL receiver, depending on the code path where
the routine is called?  That makes for a larger patch, of course, but
it removes the need to look at MyWalSnd inside
GetStandbyFlushRecPtr().
--
Michael

--9Ina7Ak1Wo21WnsW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmg2vN4ACgkQnvQgOdby
QH3VGg//e3FYzykAezZ2XdMfDj1IuZV29zkOg6UufoGdlfBiu2PQdHX4UkhUub0A
E9tTLy1tM1OCo/0AYKav3VGYFI+stQB3Ay2nfjLt/CnJtl8RtTDDGl9Yt44jhkmq
KB2G2mqhogLERv4HOARB2MdSN+edkXwPWl7WsYhmoLexPiS9Hry19WhD/ograF/L
yP2rsTV6jN+1pygiXsu20bJHgkBJ8x6a0znGAUyiQGZsAKqqj0nLwbHoCEX0ByQ2
NiA9peYUHNxDzdEQMLVvDACbrOW2RBaipkq+RnE2nuWeTTcQo0mL+/TPG0IJBx6O
0f4FSixKRqEDw9qGzm6LyJVrX38aK3/QsuLKvcAos1dKdMojSdwH6NcAInbCrEK6
qSFyi8ZBDXwBBEQIDvg1rRTIURbLEZs5FyvLbrO9Gv+qq6Hr5IBejnOo5H2YGZ6m
lvkyX74M78QDaRjWSibL4u/8NIIVDSR4yolkLBlU6OpsnZOSoFqj/sr0Lu8pbng8
8czQmLPeG8qa+cPhspyGqkyntriZR+TEmE9y0dTmvUIhMcJoufb9OTz4lFvJz84i
5QCYTL+1BMTCLoUFqmvQbiyxc+EOs3crH7D1rauNGSAivXM4YiJKvFSeFwYR3yUf
E77weEdxHI50Y0pOzS3MzkFb9x9sstmeUEVu8LeO7FqgpXSL0tw=
=DWUW
-----END PGP SIGNATURE-----

--9Ina7Ak1Wo21WnsW--