Feedback-ID: i0fe9450f:Fastmail
Date: Sun, 8 Jun 2025 11:39:44 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: a.kozhemyakin@postgrespro.ru, pgsql-bugs@lists.postgresql.org,
	Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Subject: Re: BUG #18947: TRAP: failed Assert("len_to_wrt >= 0") in
 pg_stat_statements
Message-ID: <aET38DIyBht33bIP@paquier.xyz>
References: <18947-cdd2668beffe02bf@postgresql.org>
 <CAFiTN-tGux5MZ9Hk2wKv5sVhk7eDq2AHaT79LxnQbVamxoRn9Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="4tmxXOHQfxRcS+oo"
Content-Disposition: inline
In-Reply-To: 
 <CAFiTN-tGux5MZ9Hk2wKv5sVhk7eDq2AHaT79LxnQbVamxoRn9Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aET38DIyBht33bIP%40paquier.xyz>
Precedence: bulk


--4tmxXOHQfxRcS+oo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Jun 07, 2025 at 10:19:53PM +0530, Dilip Kumar wrote:
> I didn't get time to debug, I might look into it tomorrow if someone
> doesn't do it before that, but I am able to reproduce the issue and
> seems like problem is with respect to computing the quer_loc in below
> loop, and due to that 'quer_loc' is becoming bigger than query_len and
> hitting the assert.

The loop in charge of assigning the constants in the queries needs to
be smarter in terms of the new locations assigned to sub-queries, here
the VALUES one.

499edb09741b is the origin of the regression, so open item assigned to
me (will look into it later), adding Anthonin in CC.
--
Michael

--4tmxXOHQfxRcS+oo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmhE9/AACgkQnvQgOdby
QH0r+A/8C7pqki6zkVt3dx7YzteVHTGx0jrUA+q/WScktD7ipDaL/FMu3HovAVnk
RNYbiHWPaYdbwvHqhYYOBbolwsKwPGmrD7JdFn6bQ65CQmDy5IdgW73iNkPSZmB2
wBcIEzaxujzm8IzXKrVrjHfuL+OlB1+xJJikHqQvZI6QSL4SHrTLI5cebkxF9dk2
4bivG95T+kpbj25PwyjO2GCqF1onXjVaHcEE9I095C24UyBh5vKod1BV9ndYRyCk
2N8WEWJlVeT29Sz6Df1Edv9k3f3TTJQHwCuBFC5zPLgrbAKrk36krslhfPcUlPdC
jbiRwU1k9kW+9Sc+y/2yuStMx0Ac+ZRuA0/S57eT2CfKGBg9/D/IPJ/FjsUYzyxv
pR6K03xq/knTkpAHo4hfhV0lSF4SwrgdLIx9mARE4menTm/1zH/+r6rnmY+79X9p
85hJY0onzA48O/Algzt4IBXz9bsq2xZ9K1+BTYApjmpdD2s+lYj5oaMTanBMz+GA
PfvMjzmDqevgrpoC/FIgP3XXrDYl81L9O72/Cu2bWLBEvbY/ak6Tp6H4bEnMvY9b
2OqNgClbMoXeyJXoqxy6fL+I+Qr7sIhxfjxhNGQcH6Zp7mmlZ07rsmgaMcuohlRX
K4Hdt35nPSMOJbpgTH19vtQpypX2PtrAerteMjbollJQ/m6ipGw=
=+stb
-----END PGP SIGNATURE-----

--4tmxXOHQfxRcS+oo--