Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 24 Jun 2025 13:58:43 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	vignesh C <vignesh21@gmail.com>,
	"pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>,
	Duncan Sands <duncan.sands@deepbluecap.com>,
	Alexander Lakhin <exclusion@gmail.com>
Subject: Re: Logical replication 'invalid memory alloc request size
 1585837200' after upgrading to 17.5
Message-ID: <aFowg2mxXDrrh8CG@paquier.xyz>
References: 
 <CAD21AoBfFEG=y=sHrhOO-EWpcFW=PmXcFhkPGYF+O0AH+bRo6w@mail.gmail.com>
 <dbf561f7-465e-4086-adfa-733b9b9a34b3@gmail.com>
 <CALDaNm0=KzQ8TTwTwSgZgvYwccWJU9rpFwTZYNFE1zAFLtSw3g@mail.gmail.com>
 <OSCPR01MB14966F91DBCAEA80EDEE67842F57CA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CALDaNm1Fx+zzudTi1aoE9nFef_p4H-qbOcvF9_qRanNLtwU-tA@mail.gmail.com>
 <CAA4eK1JjGrMsLoMdCynBLkPW5oTPsgpZKyJTP1g6YV+mmV-zWw@mail.gmail.com>
 <CAD21AoD736ECsU-FR5x+hp87vuZzOc1N3sknvSwKuW=XEz0Jgw@mail.gmail.com>
 <OSCPR01MB14966CD70FA2144C1F972647BF579A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAD21AoAf6-j0vPTpzUj-Q2ySPo-jW11+-pN3kmeSBypgwUZaSg@mail.gmail.com>
 <CAD21AoACfSCfWv=Jtq2AjDyAKspkhNHN7ePvXyASMphYuDJPuw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dgeCFjoJM7GOgWzj"
Content-Disposition: inline
In-Reply-To: 
 <CAD21AoACfSCfWv=Jtq2AjDyAKspkhNHN7ePvXyASMphYuDJPuw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aFowg2mxXDrrh8CG%40paquier.xyz>
Precedence: bulk


--dgeCFjoJM7GOgWzj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 24, 2025 at 10:24:03AM +0900, Masahiko Sawada wrote:
> I've added the patch for that idea for discussion. I considered moving
> the new cache-behavior-dependent test to another test file to minimize
> the maintenance effort but didn't do that at this stage as the test
> file has only a few tests.

The spec test file only includes two short permutations, making the
generated output really short.  A secondary output file sounds fine to
me as long as you document in the spec file the reason why the file is
around, and your patch does that.

+# This file contains cache-behavior-dependent test case. Their reults are
[..]
+# two expected-output files to cvoer both cases.=20

Two typos in three lines of comments: s/reults/results/ and
s/cvoer/cover/.
--
Michael

--dgeCFjoJM7GOgWzj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmhaMIMACgkQnvQgOdby
QH3gZg/9Htd2xgtkuhgqvHqDS3oSQUSmUPYZGE5GLtfsTnxQDbcGDSPnUp3H0YPs
BoB1pIuoqlLmBdfcHY+4IQR270NRbwTABz8RU/FR9qol5yTSZXBd5GE4NECgQq6U
8YX7uPKRmMfXxTYmdq5pyn7xH+J/d8kI5/Q81OnKQUW9dY2AtZKPcuAny/2Pmu48
8dJHgMuezjKvtXKf8dkDKNaEm43vYiwf8M6YVowJjCQC1TvT43Y/qYhBoa7UsgrS
xaxr7eY+guo09L0NWbm7TgWhYyWRr8EcubEx4sGiwzFYBUeB5UzIkMWdSBPZRgMI
xFaK90EPuFyo7BtyeNeQOva9PnaoXvBjAjiw6h/KQ5tDpEuCaTSxHY1S0l+SE+O9
qBTDhyDIVVBbeO5CEvXipPUV50kaLFjBNNVkaC626jyAwjSrZf7PSfsaNf+YfkFY
/ilqFuB7xOXGOiQxK+WQhxclBcztdgyNGfelOL75VAbnECVTXP0TTUlo95lRQ2D+
4vhvM1tgMay8zNnXs85s60XhOU2/3fstsJZniGSGzkMUVoU9AlXRuxdjTDyLf3q7
3KmQ4z8r8pcU4zfgH2/dEhHgHIncBFRH0dh+iaj9aBsu7DweXT+4xHvR8N02oLtM
0N7PwKU3S9Swt1s61SWYJY11JZY3T0BzpJ6vEvYhb0DtnIxuCzA=
=YRgr
-----END PGP SIGNATURE-----

--dgeCFjoJM7GOgWzj--