Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1udrWN-001Xof-VS for pgsql-bugs@arkaria.postgresql.org; Mon, 21 Jul 2025 14:29:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1udrWN-001Jft-0T for pgsql-bugs@arkaria.postgresql.org; Mon, 21 Jul 2025 14:29:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1udrWM-001Jfl-Or for pgsql-bugs@lists.postgresql.org; Mon, 21 Jul 2025 14:29:39 +0000 Received: from mail-il1-x132.google.com ([2607:f8b0:4864:20::132]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1udrWJ-0003NI-2C for pgsql-bugs@lists.postgresql.org; Mon, 21 Jul 2025 14:29:38 +0000 Received: by mail-il1-x132.google.com with SMTP id e9e14a558f8ab-3e290cbe6d0so15857915ab.1 for ; Mon, 21 Jul 2025 07:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753108175; x=1753712975; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZjMPNUGyOmAcaMb6In6olZUL52MSPePIAbpnibmnUQA=; b=dVx/waVdFk0KFBmKIstIn3leAK8KwHoNED/XMNIpzCgiPJH6KIJgHuvMQ3zdpB2b6j jAKFcju8uNkY6xWH3SH4IYRnf3em/QcjjHJdfN3SljD8mRxbbiCRzZSS0uzSQL/t023w /DJnKIpxUoAwObW+tdeDVMxLgyn3CXHsmn9h3S+gWPRBZM3YLyIih40iXvZp3o79dyW5 iT9gLRS9Sf/EVNOp2221u2fj/t4bc5cXd6NPCGu00I1usbpudOHk02AzRJSebqyAFkNy CAsOO90lMK9i+4ptYvIIZ6vMBtOwub9iDq6YHCVUI8iHgFaEmRg812pj523QITwZM55q rG3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753108175; x=1753712975; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZjMPNUGyOmAcaMb6In6olZUL52MSPePIAbpnibmnUQA=; b=Z+qot089f3xLIcJZFo83+a2blQ3oh5UnpSSRoACS5Szsv2f5lZDwemS7cHj17/ZZ0e HY0OqdyzUtAYiXdORDWB1dcajMZyu92V6Mv5LGIFxa8dBVkWldidZov2/UNXJ4PTIoEi S/uOzdqOP88lX+ez13mXTrGQGmKaiI5az6WKPWcSaLtrOWsrOSYktbVi5wDceKgOabAx Nv/hGc5v+1Pqr0aGPbAhwwqII+tLQXqHVTx0N01hq7B3f+ph8vbbY5t/uz6M+GRVCLbR +TAwJPkzI7Gg63rcOFR4lnbduBZ/c1lt0cq9oKFsoVtP4k6w4Z7XGMhj3wg3NodNCTs8 fupw== X-Forwarded-Encrypted: i=1; AJvYcCUE+sFmeqoKECmQcULzC89sfEdpZdOJ2+t621FlFz/AcLm4QnOQ/pgiJuHY6chD8zvWznkX1zdynIyf@lists.postgresql.org X-Gm-Message-State: AOJu0YwcstTKuef0Z7SzdEBvOlAY6KPlEXvOHbWrDy2+ImGx0U1Va1EZ htLxHd3ItRqVha8awvzEUH/g7BUyx/vonQppJul1th6TZUbsIZ+7Kpdb X-Gm-Gg: ASbGncvuSGjj03kj2RhkNiHG9H8JAD3bdBE0/JrTicR38C5W+Oghb32uXzhsj81aaFf 7BWk0A3C4A7JPlfXecOQ54Uqz7ML3wj0EZ6d8YgOK9SogoiPtF84Zmb0sJR1iD46/07hf5a+gs0 yF5KcKSQVQREsIY3zCoXeXLam1S2CcoJ6pbeBw7z82rHBTLfQLIggPe5wr00J9pLnwjtmclG8av XV2kjR5Cu8SA+YUHfFCk0SdhOu+9SmM+6nY8YyeLaxSh6UAYwze6dllluwMY0sqw26cmLKFtP7N D6CJZgRfcuIsfvsIXufiv3SCaVF24XrLehQ1LqTSfkxgTZnLh43E3/6ANNqz0ID/O2yd+DPSmt2 1D+Zeg4u0dRL/xF5NVvGAUEkl27h0WgHSSqXok5uguP2q4oNJWik0iYT3oz2ayzx1a0vueWQp/0 8qbN4Fgc6iYJei X-Google-Smtp-Source: AGHT+IFuFRsJ6PDJxae7AQJgsgrqtCJ7/G+60szc9vvUoNvb0+4n8Q4kPQp6uSnFVwNw3LvGOJllJg== X-Received: by 2002:a05:6e02:1fe4:b0:3dd:cc4f:d85a with SMTP id e9e14a558f8ab-3e28d3b88bamr177532075ab.6.1753108174784; Mon, 21 Jul 2025 07:29:34 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5084c786c5dsm1920154173.15.2025.07.21.07.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jul 2025 07:29:34 -0700 (PDT) Date: Mon, 21 Jul 2025 09:29:32 -0500 From: Nathan Bossart To: gorcom2012@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18993: [BUG] Unreachable code in pg_next_dst_boundary() Message-ID: References: <18993-fd78c35834306695@postgresql.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18993-fd78c35834306695@postgresql.org> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Jul 21, 2025 at 12:29:16PM +0000, PG Bug reporting form wrote: > In pg_next_dst_boundary() (src/timezone/localtime.c), the following > condition can never be true: > ``` > if (tcycles - icycles >= 1 || icycles - tcycles >= 1) > return -1; > ``` > This is unreachable because icycles is assigned directly from tcycles. I see the following upstream commit and discussion related to this: https://github.com/eggert/tz/commit/b0bf6d8 https://mm.icann.org/pipermail/tz/2013-August/019493.html -- nathan