Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 16 Jul 2025 19:48:55 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, y@lll.gd, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18986: SIGSEGV in nodeModifyTable.c during Parallel
 Execution
Message-ID: <aHeDl-0OuIA-MJtt@paquier.xyz>
References: <18986-e7a8aac3d339fa47@postgresql.org>
 <937261.1752603233@sss.pgh.pa.us>
 <aHbt_HkrM3TTH61j@paquier.xyz>
 <CAEZATCUj7u_9MTDYZ7hzaf4uf1WrJ+fA3_M4dQKRvua0nP8sMg@mail.gmail.com>
 <CAEZATCUahLe8Lvi7XHV6Eo=Tg46iJ2Rmfw0k6AH5GQbfOjENHQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="x4npSzoH4v4jWygf"
Content-Disposition: inline
In-Reply-To: 
 <CAEZATCUahLe8Lvi7XHV6Eo=Tg46iJ2Rmfw0k6AH5GQbfOjENHQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aHeDl-0OuIA-MJtt%40paquier.xyz>
Precedence: bulk


--x4npSzoH4v4jWygf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 16, 2025 at 11:42:33AM +0100, Dean Rasheed wrote:
> Attached is a reproducer using the merge-match-recheck isolation test.
>=20
> I believe that the bug only goes back to v17, because MERGE could not
> appear inside a CTE prior to that.

That was fast, nice!

> I think that best thing to do is pass the commandType to
> ExecBRUpdateTriggers(), except that in v17 we shouldn't change the
> signature of ExecBRUpdateTriggers(), so a wrapper function will be
> needed, similar to what 9321c79 did.

Yes, changing ExecBRUpdateTriggers() would not be a good idea on a
stable branch..  I can see that at least timescaledb does a direct
call to it.  A minor upgrade breakage would be bad for them.

> Question: Is it OK to change the signature of ExecBRUpdateTriggers()
> in v18?

We are still in beta, so that's not a problem for v18 and HEAD.
--
Michael

--x4npSzoH4v4jWygf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmh3g5cACgkQnvQgOdby
QH260Q/9Feh3Otj23FX5y0j5s5RNDhwIZCklOH83o6OXrq6xZRUJZaDeyH8sg5nN
CDNuZpxn6XlxSPtC+jrQPcCQm0qdaB6x+BbpeWCzAWel554wXo9vEeLe93IVGp37
RsMrR8LxIMrSASL6Gik+6vS0jBo2bePhBfovK7RTl24Yv1yMQRUuGe9+P3FRvFpO
sDVQYdlvnkXPgNPbd73cm9pHfIhoVksFgOJSTMdeJ6tpcGwAQ+F2zNq4IMbjMsSZ
fNORo76wI458evj4LG3erOPqMRPumCw0DZuYzomGHKT5luPNH8rNG+Yy6gqFDKMS
uz2xlml9DBKj/5XmGhoBOa+R34J5knTf/EJcHmqJVnOemeG65jDjJceAy8yNszq6
Eq9xYiYkLeewJ5QhnPumm/CppHyPtx3bhJTEPMUOgtH2rB+ZxakHUU+c8QgZ3jiw
9gmFnCxq/muiHEn/Sri7UDI3s0quBfPXa5lQ/59w4iUcP4H+Jw60s1S2k8d9og48
1edGZVzV2DNUuOcyJMVrPcEhXy4ki2gRsZNPCRGggQVDrwFmbXHNd5itoCuq1xFe
sMXRIahkZuP8Q8uz8PmxVA/O5y1ay3cNKzr6lIINpLZ0KqCyCggBjFoqsK8v4QLB
8oTEMVlox0jZQqzZ1iw/5Ef+v/l03ZdnVMrgPGNPAAHK0Cbi60I=
=woPy
-----END PGP SIGNATURE-----

--x4npSzoH4v4jWygf--