Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 17 Jul 2025 14:44:53 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, y@lll.gd, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18986: SIGSEGV in nodeModifyTable.c during Parallel
 Execution
Message-ID: <aHiN1aldYZfbAvMO@paquier.xyz>
References: <18986-e7a8aac3d339fa47@postgresql.org>
 <937261.1752603233@sss.pgh.pa.us>
 <aHbt_HkrM3TTH61j@paquier.xyz>
 <CAEZATCUj7u_9MTDYZ7hzaf4uf1WrJ+fA3_M4dQKRvua0nP8sMg@mail.gmail.com>
 <CAEZATCUahLe8Lvi7XHV6Eo=Tg46iJ2Rmfw0k6AH5GQbfOjENHQ@mail.gmail.com>
 <aHeDl-0OuIA-MJtt@paquier.xyz>
 <CAEZATCWZahtK-OT5fa2=8b=+BUuDtsspkvur4x8WkjgHbxJxkw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="IKXNPYR1qWgp7Rs1"
Content-Disposition: inline
In-Reply-To: 
 <CAEZATCWZahtK-OT5fa2=8b=+BUuDtsspkvur4x8WkjgHbxJxkw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aHiN1aldYZfbAvMO%40paquier.xyz>
Precedence: bulk


--IKXNPYR1qWgp7Rs1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 16, 2025 at 02:05:06PM +0100, Dean Rasheed wrote:
> I decided to do this by adding an extra "is_merge_update" boolean
> parameter, rather than passing the commandType because that looked
> slightly neater. It was also necessary to update
> ExecBRDeleteTriggers(), since otherwise a concurrent MERGE DELETE
> could do the wrong thing (execute the wrong action, rather than
> seg-faulting). That was picked up by an existing isolation test case
> added by 9321c79, so no need for more tests.

Looks sensible here, for the HEAD and v17 flavors.

> I haven't tested this against the OP's reproducer.

Except waiting for the OP to actually test the fix, I'm not sure if
there is much that we can do.  Anyway, the stack that one gets with
the isolation test is very close to what the OP has reported, so I'm
ready to bet a coffee that you have been able to narrow this one down.

I have also raised an issue to timescale to make them aware of the
issue.  I have no idea if this is an issue for them, just acting as a
reporter:
https://github.com/timescale/timescaledb/issues/8392
--
Michael

--IKXNPYR1qWgp7Rs1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmh4jdUACgkQnvQgOdby
QH1N9A/+ObkqLnq+KJglSA2ANrVes9/jpkjkf0zjpu44CaA3kAUDje5gf0Dq1ttN
alduk4mqBC6wV20FvvCa84P9dxAWvKKiDhNt5xXnL4MQjKwyWKNzvYdxyiEFVM4T
5fFEx6SK19TEAuYm59YmSyp+Qsx+xD+A3NzF1RGcRz+Rwru9QP+1vZBXKBdccLkL
dTWcyiJqP0bfNNNIkRGw7ch7lWeBXGui3K1dTrppSzS+eTX43dmyURgF1otLoino
zYZQ958Wsj3Kx88HmY4Is0yl3g53ABNvTM8/OJzQwrmid4plrddcCYWBdjx0xHq7
+OlaCahSc4nxxIcNfm9VTfA3mF2WoOErwi7QPA5VxSrLBLDBhJewNM1eY6DebMFB
YgMpXJSHK7itKdmf5Ppue6iGCsiSy0Z9OAFE2QIQ8jya26zp21eA+Zybyx68TBih
jd/X6obJG46C1HauVRPt0+giWp0yGChV4xJmlnZbBGQqgDebkGaiY3KxfgmKdulo
xNBc+DqqmQjIa/xQ2lewQ4+A0Aap4xiM+7v6gba9b6fi9Nwxo87IHA8HXvjIjfsR
roq43P8OwU/SMyMIz8oo5Q+vqFWOIyNinG184GC70H6NeKML6O9UEg5VnU6q1sbl
FkYrcootzhgVDJiJZyqHrfLry3CK5iAlopymjOldjlSdZiB3XXo=
=z9/O
-----END PGP SIGNATURE-----

--IKXNPYR1qWgp7Rs1--