Date: Thu, 24 Jul 2025 11:30:49 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, mert@futo.org,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18964: `ALTER DATABASE ... RESET ...` fails to reset
 extension parameters that no longer exist
Message-ID: <aIJfucaqjZ3gh-xj@nathan>
References: <18964-ba09dea8c98fccd6@postgresql.org>
 <aFW8R6Qlgtbp7TOk@nathan>
 <2474668.1750451081@sss.pgh.pa.us>
 <aFXQmZ2sveFAwdjY@nathan>
 <aFXlRTxMxVyMjfjq@nathan>
 <aFwebUErRdEKZy6i@nathan>
 <803ddef427b9016be04af9320925e9570d3fcc06.camel@cybertec.at>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="WnNNth7ekP1e9dZR"
Content-Disposition: inline
In-Reply-To: <803ddef427b9016be04af9320925e9570d3fcc06.camel@cybertec.at>
Archived-At: <https://www.postgresql.org/message-id/aIJfucaqjZ3gh-xj%40nathan>
Precedence: bulk


--WnNNth7ekP1e9dZR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 22, 2025 at 04:27:24AM +0200, Laurenz Albe wrote:
> I tested your patch, and it works as expected for

Thanks for reviewing.

> There is still one piece missing in my opinion:
> 
>   ALTER SYSTEM RESET testext.swap_limit;
>   ERROR:  invalid configuration parameter name "testext.swap_limit"
>   DETAIL:  "testext" is a reserved prefix.
> 
> I think that this case should work like the others.

Good catch.  This should be fixed in v3.

> I'd like to see regression tests for this, but I am not sure how
> to best devise them.
> One idea would be to stick them into the regression tests of some
> contrib module, even though it is not the perfect place.

Added in v3.

-- 
nathan

--WnNNth7ekP1e9dZR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v3-0001-Allow-resetting-unknown-custom-GUCs-with-reserved.patch