Date: Fri, 25 Jul 2025 09:15:17 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, mert@futo.org,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18964: `ALTER DATABASE ... RESET ...` fails to reset
 extension parameters that no longer exist
Message-ID: <aIORdQ-PJ15k-WjZ@nathan>
References: <18964-ba09dea8c98fccd6@postgresql.org>
 <aFW8R6Qlgtbp7TOk@nathan>
 <2474668.1750451081@sss.pgh.pa.us>
 <aFXQmZ2sveFAwdjY@nathan>
 <aFXlRTxMxVyMjfjq@nathan>
 <aFwebUErRdEKZy6i@nathan>
 <803ddef427b9016be04af9320925e9570d3fcc06.camel@cybertec.at>
 <aIJfucaqjZ3gh-xj@nathan>
 <8902b6f8d5c19f09f4a052295b9de41d9f6970b5.camel@cybertec.at>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="qQ7L+2WUHgUkhGpf"
Content-Disposition: inline
In-Reply-To: <8902b6f8d5c19f09f4a052295b9de41d9f6970b5.camel@cybertec.at>
Archived-At: <https://www.postgresql.org/message-id/aIORdQ-PJ15k-WjZ%40nathan>
Precedence: bulk


--qQ7L+2WUHgUkhGpf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 24, 2025 at 11:06:57PM +0200, Laurenz Albe wrote:
> On Thu, 2025-07-24 at 11:30 -0500, Nathan Bossart wrote:
>> +ALTER ROLE regress_ae_role IN DATABASE :datname RESET auto_explain.bogus;
> 
> That is perhaps a rediculous quibble, but shouldn't that be :"datname"?
> I guess the regression test database will always have a proper name...

You're right, it probably should be quoted.

> Anyway, I'll mark the patch as "ready for committer".

Thanks.  I'd like to get this fixed in the August releases, so I'm planning
to commit this sometime late next week, barring additional feedback or
objections.

-- 
nathan

--qQ7L+2WUHgUkhGpf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v4-0001-Allow-resetting-unknown-custom-GUCs-with-reserved.patch